All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v4 1/9] spl: Drop duplicate 'Jumping to U-Boot' message
Date: Sat,  6 Feb 2021 09:57:27 -0700	[thread overview]
Message-ID: <20210206165736.3491584-2-sjg@chromium.org> (raw)
In-Reply-To: <20210206165736.3491584-1-sjg@chromium.org>

This is printed twice but we only need one message, since there is very
little processing in between them. Drop the second one, since all branches
of the switch() already have output. Update the U-Boot message to include
the phase being jumped to.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v3)

Changes in v3:
- Show phase only for IH_OS_U_BOOT, drop the last debug()

 common/spl/spl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index cdd7b05f279..42004506446 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -693,7 +693,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 #endif
 	switch (spl_image.os) {
 	case IH_OS_U_BOOT:
-		debug("Jumping to U-Boot\n");
+		debug("Jumping to %s...\n", spl_phase_name(spl_next_phase()));
 		break;
 #if CONFIG_IS_ENABLED(ATF)
 	case IH_OS_ARM_TRUSTED_FIRMWARE:
@@ -740,7 +740,6 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 		debug("Failed to stash bootstage: err=%d\n", ret);
 #endif
 
-	debug("loaded - jumping to %s...\n", spl_phase_name(spl_next_phase()));
 	spl_board_prepare_for_boot();
 	jump_to_image_no_args(&spl_image);
 }
-- 
2.30.0.478.g8a0d178c01-goog

  reply	other threads:[~2021-02-06 16:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06 16:57 [PATCH v4 0/9] Various minor fixes Simon Glass
2021-02-06 16:57 ` Simon Glass [this message]
2021-03-03 19:09   ` [PATCH v4 1/9] spl: Drop duplicate 'Jumping to U-Boot' message Tom Rini
2021-02-06 16:57 ` [PATCH v4 2/9] binman: Indicate how to make binman verbose Simon Glass
2021-03-03 19:09   ` Tom Rini
2021-02-06 16:57 ` [PATCH v4 3/9] doc: describe the md command Simon Glass
2021-03-03 19:10   ` Tom Rini
2021-02-06 16:57 ` [PATCH v4 4/9] doc: Add a note about producing 'md.b' output using hexdump Simon Glass
2021-03-03 19:10   ` Tom Rini
2021-02-06 16:57 ` [PATCH v4 5/9] s5p4418_nanopi2: Drop dead code Simon Glass
2021-03-03 19:10   ` Tom Rini
2021-02-06 16:57 ` [PATCH v4 6/9] sandbox: Add os_realloc() Simon Glass
2021-03-03 19:10   ` Tom Rini
2021-02-06 16:57 ` [PATCH v4 7/9] sandbox: Avoid using malloc() for system state Simon Glass
2021-03-03 19:10   ` Tom Rini
2021-05-15 17:16   ` [BUG] " Heinrich Schuchardt
2021-02-06 16:57 ` [PATCH v4 8/9] sandbox: Write out bloblist when exiting Simon Glass
2021-03-03 19:10   ` Tom Rini
2021-02-06 16:57 ` [PATCH v4 9/9] bootm: Fix duplicate debugging in bootm_process_cmdline() Simon Glass
2021-03-03 19:10   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210206165736.3491584-2-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.