From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D95BC433E6 for ; Mon, 8 Feb 2021 09:10:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F7F364E88 for ; Mon, 8 Feb 2021 09:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231326AbhBHJKI (ORCPT ); Mon, 8 Feb 2021 04:10:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:46120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbhBHJHr (ORCPT ); Mon, 8 Feb 2021 04:07:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4A7864E5A; Mon, 8 Feb 2021 09:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612775226; bh=iebjJXK8eI03y8eH+IflFo8KMyEsriv2X5L1w60l9gA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dvChGjCbxgl5JwBOhleg19oKKhbuLcyxhlMXYQ2QNDE/z0NKoC+JvkLIgjulqkRHC VQJ5yzQEKMMWeLoSma1aStfcr4Mj3Nl/SutryeVxUmkU7Wyl5jb21i7ho7Jo1lcc6R GZ675rWAKXNvlHDy/pRESQwGrjxT2LUVn08ibIPeEcK1pKyHM1ADDuAFMkvRQmrQbE Mn1s/UzcQo+1NUbzCbeKZ5Z6KBJu0gqjLs07KgQX3sm9cYmjus9cKjMK4tr4A32Lwh n5AJNDJl2C4vGzf8TghZ8rZDw2EnGKuBRA3d6vRcND9C3YQxYkGx2P6+zYnei1RWrj D74fJ/f9l9ImA== Date: Mon, 8 Feb 2021 11:07:02 +0200 From: Leon Romanovsky To: Ido Schimmel Cc: Chris Mi , Jakub Kicinski , Cong Wang , Linux Kernel Network Developers , jiri@nvidia.com, Saeed Mahameed , kernel test robot Subject: Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency Message-ID: <20210208090702.GB20265@unreal> References: <20210128014543.521151-1-cmi@nvidia.com> <6c586e9a-b672-6e60-613b-4fb6e6db8c9a@nvidia.com> <20210129123009.3c07563d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210130144231.GA3329243@shredder.lan> <8924ef5a-a3ac-1664-ca11-5f2a1f35399a@nvidia.com> <20210201180837.GB3456040@shredder.lan> <20210208070350.GB4656@unreal> <20210208085746.GA179437@shredder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208085746.GA179437@shredder.lan> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 08, 2021 at 10:57:46AM +0200, Ido Schimmel wrote: > On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote: > > > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote: > > > > Hi Ido, > > > > > > > > On 1/30/2021 10:42 PM, Ido Schimmel wrote: > > > > > On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: > > > > > > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > > > > > > Instead of discussing it several days, maybe it's better to review > > > > > > > current patch, so that we can move forward :) > > > > > > It took you 4 revisions to post a patch which builds cleanly and now > > > > > > you want to hasten the review? My favorite kind of submission. > > > > > > > > > > > > The mlxsw core + spectrum drivers are 65 times the size of psample > > > > > > on my system. Why is the dependency a problem? > > > > > mlxsw has been using psample for ~4 years and I don't remember seeing a > > > > > single complaint about the dependency. I don't understand why this patch > > > > > is needed. > > > > Please see Saeed's comment in previous email: > > > > > > > > " > > > > > > > > The issue is with distros who ship modules independently.. having a > > > > hard dependency will make it impossible for basic mlx5_core.ko users to > > > > load the driver when psample is not installed/loaded. > > > > > > > > I prefer to have 0 dependency on external modules in a HW driver. > > > > " > > > > > > I saw it, but it basically comes down to personal preferences. > > > > It is more than personal preferences. In opposite to the mlxsw which is > > used for netdev only, the mlx5_core is used by other subsystems, e.g. RDMA, > > so Saeed's request to avoid extra dependencies makes sense. > > > > We don't need psample dependency to run RDMA traffic. > > Right, you don't need it. The dependency is "PSAMPLE || PSAMPLE=n". You > can compile out psample and RDMA will work. So do you suggest to all our HPC users recompile their distribution kernel just to make sure that psample is not called? > > > > > > > > > > > > > > We are working on a tc sample offload feature for mlx5_core. The distros > > > > are likely to request us to do this. So we address it before submitting > > > > the driver changes. > > > > > > Which distros? Can they comment here? mlxsw is in RHEL and I don't > > > remember queries from them about the psample module. > > > > There is a huge difference between being in RHEL and actively work with > > partners as mlx5 does. > > > > The open mailing list is not the right place to discuss our partnership > > relations. > > I did not ask about "partnership relations". I asked for someone more > familiar with the problem that can explain the distro issue. But if such > a basic question can't be asked, then the distro argument should not > have been made in the first place. It is not what you wrote, but if you don't want to take distro argument into account, please don't bring mlxsw either. Thanks