From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C742C433E6 for ; Mon, 8 Feb 2021 09:38:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1528064E7E for ; Mon, 8 Feb 2021 09:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbhBHJiA (ORCPT ); Mon, 8 Feb 2021 04:38:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230425AbhBHJV1 (ORCPT ); Mon, 8 Feb 2021 04:21:27 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05CDBC061793 for ; Mon, 8 Feb 2021 01:20:47 -0800 (PST) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l92in-0005yN-37; Mon, 08 Feb 2021 10:20:41 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1l92ik-0003fs-QN; Mon, 08 Feb 2021 10:20:38 +0100 Date: Mon, 8 Feb 2021 10:20:38 +0100 From: Oleksij Rempel To: Russell King - ARM Linux admin Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Fabio Estevam , Philippe Schenker , linux-imx@nxp.com, kernel@pengutronix.de, David Jander , Shawn Guo , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Subject: Re: [PATCH v1 5/7] ARM i.MX6q: remove Atheros AR8035 SmartEEE fixup Message-ID: <20210208092038.cjmnycyctsapgy7w@pengutronix.de> References: <20210203091857.16936-1-o.rempel@pengutronix.de> <20210203091857.16936-6-o.rempel@pengutronix.de> <20210203095628.GP1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210203095628.GP1463@shell.armlinux.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:03:28 up 67 days, 23:09, 39 users, load average: 0.10, 0.07, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 09:56:28AM +0000, Russell King - ARM Linux admin wrote: > On Wed, Feb 03, 2021 at 10:18:55AM +0100, Oleksij Rempel wrote: > > This fixup removes the Lpi_en bit. > > > > If this patch breaks functionality of your board, use following device > > tree properties: > > > > ethernet-phy@X { > > reg = <0xX>; > > eee-broken-1000t; > > eee-broken-100tx; > > .... > > }; > > That is the historical fix for this problem, but there is a better > solution now in net-next - configuring the Tw parameter for gigabit > connections. That solves the random link drop issue when EEE is > enabled. Do you mean this properties? qca,smarteee-tw-us-1g qca,smarteee-tw-us-100m Do you have some recommendations, which values can be here used? Are they same for all MACs? Or, can we calculate this values automatically? Beside, I have seen this patch: "ARM: dts: imx6qdl-sr-som: fix some cubox-i platforms" I had similar issue and it was triggered by the boot loader, which enabled 60 Ohm on-die termination. The fix was to remove this lines in the boot loader: wm 32 0x020e07ac 0x00000200 /* 60 Ohm ODT */ > Support for this configuration has only recently been merged into > net-next and other trees for this merge window, so I ask that you > hold off at least this patch until the next cycle. ok. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE12FC433E0 for ; Mon, 8 Feb 2021 09:22:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7541C64E85 for ; Mon, 8 Feb 2021 09:22:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7541C64E85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M3lv9jfApRIzGhu2G8S+R+UQ1v9Wp+WYl2b8MA0vtOc=; b=ew+WXFOG1sIS1rkCjQ8uGl/aa kJkAsLVQwAYh8EIbwbl0tsqfMfTbdUWzIMRphQ9NKNT/QSh7FWj5TFGTvp36Zro3jxRlaW3kZsRqB Ruxj16mP9zYs07t9dhPRxKzmGeBflS58LGVh0nk5HX+tl9VKY3uf8xH831Uar29lvf21dNGKq12Yt tbMTlF83njN8xtbJ143OV0mJNYSw1yr4OWJMJZ9fezLweg60s0VOfyOnksKuV4sc+Xk1slv2nWihW YHSrlZ7xpI8OiTxLLs8GrVYgo0YotcDLxrk7bmnL0GlsMsCq/kBsqh9x+yAsQ5YHvAVDWHSl9pWmm hF03MIG4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l92jE-0003tj-JW; Mon, 08 Feb 2021 09:21:08 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l92jC-0003tA-6F for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 09:21:07 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l92in-0005yN-37; Mon, 08 Feb 2021 10:20:41 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1l92ik-0003fs-QN; Mon, 08 Feb 2021 10:20:38 +0100 Date: Mon, 8 Feb 2021 10:20:38 +0100 From: Oleksij Rempel To: Russell King - ARM Linux admin Subject: Re: [PATCH v1 5/7] ARM i.MX6q: remove Atheros AR8035 SmartEEE fixup Message-ID: <20210208092038.cjmnycyctsapgy7w@pengutronix.de> References: <20210203091857.16936-1-o.rempel@pengutronix.de> <20210203091857.16936-6-o.rempel@pengutronix.de> <20210203095628.GP1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210203095628.GP1463@shell.armlinux.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:03:28 up 67 days, 23:09, 39 users, load average: 0.10, 0.07, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_042106_279484_E3D5B2E1 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Philippe Schenker , linux-imx@nxp.com, kernel@pengutronix.de, David Jander , Shawn Guo , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 09:56:28AM +0000, Russell King - ARM Linux admin wrote: > On Wed, Feb 03, 2021 at 10:18:55AM +0100, Oleksij Rempel wrote: > > This fixup removes the Lpi_en bit. > > > > If this patch breaks functionality of your board, use following device > > tree properties: > > > > ethernet-phy@X { > > reg = <0xX>; > > eee-broken-1000t; > > eee-broken-100tx; > > .... > > }; > > That is the historical fix for this problem, but there is a better > solution now in net-next - configuring the Tw parameter for gigabit > connections. That solves the random link drop issue when EEE is > enabled. Do you mean this properties? qca,smarteee-tw-us-1g qca,smarteee-tw-us-100m Do you have some recommendations, which values can be here used? Are they same for all MACs? Or, can we calculate this values automatically? Beside, I have seen this patch: "ARM: dts: imx6qdl-sr-som: fix some cubox-i platforms" I had similar issue and it was triggered by the boot loader, which enabled 60 Ohm on-die termination. The fix was to remove this lines in the boot loader: wm 32 0x020e07ac 0x00000200 /* 60 Ohm ODT */ > Support for this configuration has only recently been merged into > net-next and other trees for this merge window, so I ask that you > hold off at least this patch until the next cycle. ok. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel