From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stafford Horne Date: Mon, 8 Feb 2021 21:16:48 +0900 Subject: [OpenRISC] [PATCH v2] openrisc: use device tree to determine present cpus In-Reply-To: References: <20210129221643.GZ2002709@lianli.shorne-pla.net> <2a018afc-d797-3a91-ffab-e55ae3b0a795@rwth-aachen.de> <20210130230310.GC2002709@lianli.shorne-pla.net> <20210131212752.GG2002709@lianli.shorne-pla.net> <6dbc27f8-5261-59c5-acba-70f6c6a74ba1@rwth-aachen.de> <20210205144317.GK2002709@lianli.shorne-pla.net> <20210205223651.GL2002709@lianli.shorne-pla.net> Message-ID: <20210208121648.GN2002709@lianli.shorne-pla.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Sat, Feb 06, 2021 at 10:33:24AM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Fri, Feb 5, 2021 at 11:36 PM Stafford Horne wrote: > > On Fri, Feb 05, 2021 at 05:07:51PM +0100, Geert Uytterhoeven wrote: > > > On Fri, Feb 5, 2021 at 3:43 PM Stafford Horne wrote: > > > > On Mon, Feb 01, 2021 at 12:49:31PM +0100, Jan Henrik Weinstock wrote: > > > > > Use the device tree to determine the present cpus instead of assuming all > > > > > CONFIG_NRCPUS are actually present in the system. > > > > > > > > > > Signed-off-by: Jan Henrik Weinstock > > > > > > > > I cannot apply this patch, it seems you somehow sent it signed as a multipart > > > > message via Thunderbird. > > > > > > > > This causes errors when trying to apply, even after I tried to manually fix the > > > > patch mail: > > > > > > > > Applying: openrisc: use device tree to determine present cpus > > > > error: sha1 information is lacking or useless (arch/openrisc/kernel/smp.c). > > > > error: could not build fake ancestor > > > > Patch failed at 0001 openrisc: use device tree to determine present cpus > > > > > > > > Can you send this using 'git send-email?' > > > > > > > > If not I can get it applied with some work, otherwise you can point me to a git > > > > repo which I can pull it from. > > > > > > "b4 am 6dbc27f8-5261-59c5-acba-70f6c6a74ba1 at rwth-aachen.de" works > > > fine for me. > > > > > > git://git.kernel.org/pub/scm/utils/b4/b4.git > > > > Did it work? For me I got, base not found. > > > > Looking up > > https://lore.kernel.org/r/6dbc27f8-5261-59c5-acba-70f6c6a74ba1%40rwth-aachen.de > > Grabbing thread from lore.kernel.org/lkml > > Analyzing 9 messages in the thread > > Will use the latest revision: v2 > > You can pick other revisions using the -vN flag > > --- > > Writing > > ./v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx > > [PATCH v2] openrisc: use device tree to determine present cpus > > --- > > Total patches: 1 > > --- > > Link: > > https://lore.kernel.org/r/6dbc27f8-5261-59c5-acba-70f6c6a74ba1 at rwth-aachen.de > > Base: not found > > That just means the patch contains no information w.r.t. its base, i.e. > against which tree/commit it applies to. To be ignored. > > > git am > > ./v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx > > Just run the above command ;-) > > In addition, you can run "formail -s scripts/checkpatch.pl < *mbx" first, to > run the mbox (which could contain multiple patches) through checkpatch. Hi Geert, Thanks for your help, but this is still not working. See that attached patch. If your patch doesn't have this corruption then please forward it. If Jan could point to a git repo or reset with 'git send-email' that would be great too. It seems that the mailer has corrupted the patch by adding and removing whitespace to each line. I don't have a 'formail' command, but I did try 'git am' and 'checkpatch.pl' and it shows: < shorne@lianli ~/work/linux > git am v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx Applying: openrisc: use device tree to determine present cpus error: corrupt patch at line 62 Patch failed at 0001 openrisc: use device tree to determine present cpus hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". < shorne@lianli ~/work/linux > ./scripts/checkpatch.pl v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx ERROR: "foo* bar" should be "foo *bar" #38: FILE: arch/openrisc/kernel/smp.c:64: + struct device_node* cpu; WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc #49: FILE: arch/openrisc/kernel/smp.c:73: + if (cpu_id < NR_CPUS) ERROR: patch seems to be corrupt (line wrapped?) #81: FILE: arch/openrisc/kernel/smp.c:90: 2.17.1 total: 2 errors, 1 warnings, 49 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx has style problems, please review. -Stafford -------------- next part --------------