From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B30C43381 for ; Mon, 8 Feb 2021 15:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AD1E64E15 for ; Mon, 8 Feb 2021 15:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233915AbhBHPfD (ORCPT ); Mon, 8 Feb 2021 10:35:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhBHPcc (ORCPT ); Mon, 8 Feb 2021 10:32:32 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DB13C061793; Mon, 8 Feb 2021 07:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tdwCgKoyLdHxRuD+Ock+CY1gFHQqJYRvjdWG9ShjOkY=; b=zU/66JgRfM3qSDf+yVQGplFKy 365CNDWp7LAaZkjasaEkkS9zdxY9mFrU7lvKhaut2GV1Ldn4/Fij0JXoLSfivEaHY9RLDom9KJ3dD MA3nRv/2W6bgJRVSxydYqGIjiNQR5Q23I0A91aNIdjgp8TcdQwsFxmWf2l7PMpgPZ0YqZaoAgXA2B cpr8PNOGalTRQrkS5nsYuJTuPJDt/PcJoLAx42ZUSBpyVY9im2aHU4b3wjeCPzzcCZpNB2rxJBFfg jCTsl0+X7RuBRskZz01elt+0+w3Ww0lp+GfXzhiyDE4wGLYeIYG6LiS6mmEdUv13JUT9xjeSpFtSn LnmJIFeXQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40812) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l98VN-0002Bx-JF; Mon, 08 Feb 2021 15:31:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l98VL-00039T-3P; Mon, 08 Feb 2021 15:31:11 +0000 Date: Mon, 8 Feb 2021 15:31:11 +0000 From: Russell King - ARM Linux admin To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Andy Shevchenko , Florian Fainelli , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Laurentiu Tudor , linux-kernel@vger.kernel.org, linux.cj@gmail.com, Diana Madalina Craciun , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, "David S. Miller" , Heiner Kallweit , Jakub Kicinski Subject: Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() Message-ID: <20210208153111.GK1463@shell.armlinux.org.uk> References: <20210208151244.16338-1-calvin.johnson@oss.nxp.com> <20210208151244.16338-14-calvin.johnson@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208151244.16338-14-calvin.johnson@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > +int phylink_fwnode_phy_connect(struct phylink *pl, > + struct fwnode_handle *fwnode, > + u32 flags) > +{ > + struct fwnode_handle *phy_fwnode; > + struct phy_device *phy_dev; > + int ret; > + > + if (is_of_node(fwnode)) { > + /* Fixed links and 802.3z are handled without needing a PHY */ > + if (pl->cfg_link_an_mode == MLO_AN_FIXED || > + (pl->cfg_link_an_mode == MLO_AN_INBAND && > + phy_interface_mode_is_8023z(pl->link_interface))) > + return 0; This difference between ACPI and DT really needs to be described in the commit description. For example, why is it acceptable to have a PHY in fixed-link mode if we're using ACPI, and not DT? If we look at the phylink code, accepting a PHY when in fixed-link mode is basically not supported... so why should ACPI allow this? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484B7C433DB for ; Mon, 8 Feb 2021 15:32:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF32064E15 for ; Mon, 8 Feb 2021 15:32:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF32064E15 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pfvzWoziLSOTCUXr7T18Gv0O4hV6uqDJPhRmxFcZuCI=; b=Lsv7eu3Cj8sLDp8JO5Cq4ZDaN Douq/k9fLYjU90QSuDeiA9R4pGaVu69kTeFchvXXVdaWsZXkC0vD/cHVKiPG23wVVz3mGVrRT6uwx 8vtYE5jcMpizrqSO/CIxkGKi8NGDuCIGAuPM2xIGbjneQBgS2awcaRLgYQ9fzYVf0Vo9uYk2ZEELT pemGerkk+AYZ4VcoOu7fGVzHhF1fj24+NKSBl27u2l2dKuqV+qEOTOXM+OOipcurrjaOfe8c/TYNb bH1ZhCgzKjBuigWTZkNNLO6Rc/6B9XX1yQnuuTjIVK2PIOCoAH6Va/G2J+4IYwZV9Y7CQYMSJEl45 9COtKipHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l98Vq-0002Zm-1w; Mon, 08 Feb 2021 15:31:42 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l98Vm-0002Z6-MA for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 15:31:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tdwCgKoyLdHxRuD+Ock+CY1gFHQqJYRvjdWG9ShjOkY=; b=zU/66JgRfM3qSDf+yVQGplFKy 365CNDWp7LAaZkjasaEkkS9zdxY9mFrU7lvKhaut2GV1Ldn4/Fij0JXoLSfivEaHY9RLDom9KJ3dD MA3nRv/2W6bgJRVSxydYqGIjiNQR5Q23I0A91aNIdjgp8TcdQwsFxmWf2l7PMpgPZ0YqZaoAgXA2B cpr8PNOGalTRQrkS5nsYuJTuPJDt/PcJoLAx42ZUSBpyVY9im2aHU4b3wjeCPzzcCZpNB2rxJBFfg jCTsl0+X7RuBRskZz01elt+0+w3Ww0lp+GfXzhiyDE4wGLYeIYG6LiS6mmEdUv13JUT9xjeSpFtSn LnmJIFeXQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40812) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l98VN-0002Bx-JF; Mon, 08 Feb 2021 15:31:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l98VL-00039T-3P; Mon, 08 Feb 2021 15:31:11 +0000 Date: Mon, 8 Feb 2021 15:31:11 +0000 From: Russell King - ARM Linux admin To: Calvin Johnson Subject: Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() Message-ID: <20210208153111.GK1463@shell.armlinux.org.uk> References: <20210208151244.16338-1-calvin.johnson@oss.nxp.com> <20210208151244.16338-14-calvin.johnson@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208151244.16338-14-calvin.johnson@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_103138_812579_ECC7C2F1 X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J . Wysocki" , Grant Likely , Ioana Ciornei , Florian Fainelli , Saravana Kannan , Jon , Diana Madalina Craciun , linux-acpi@vger.kernel.org, Andy Shevchenko , Jakub Kicinski , Florin Laurentiu Chiculita , Madalin Bucur , Pieter Jansen Van Vuuren , Marcin Wojtas , linux-arm-kernel@lists.infradead.org, Laurentiu Tudor , netdev@vger.kernel.org, Randy Dunlap , linux-kernel@vger.kernel.org, Jeremy Linton , Cristi Sovaiala , linux.cj@gmail.com, "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > +int phylink_fwnode_phy_connect(struct phylink *pl, > + struct fwnode_handle *fwnode, > + u32 flags) > +{ > + struct fwnode_handle *phy_fwnode; > + struct phy_device *phy_dev; > + int ret; > + > + if (is_of_node(fwnode)) { > + /* Fixed links and 802.3z are handled without needing a PHY */ > + if (pl->cfg_link_an_mode == MLO_AN_FIXED || > + (pl->cfg_link_an_mode == MLO_AN_INBAND && > + phy_interface_mode_is_8023z(pl->link_interface))) > + return 0; This difference between ACPI and DT really needs to be described in the commit description. For example, why is it acceptable to have a PHY in fixed-link mode if we're using ACPI, and not DT? If we look at the phylink code, accepting a PHY when in fixed-link mode is basically not supported... so why should ACPI allow this? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel