From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D516C433DB for ; Mon, 8 Feb 2021 23:29:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11E2964E25 for ; Mon, 8 Feb 2021 23:29:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11E2964E25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Fy6-0006yO-UE for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 18:29:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9BCt-0003jR-Jp for qemu-devel@nongnu.org; Mon, 08 Feb 2021 13:24:19 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:36806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9BCp-0006Nb-9x for qemu-devel@nongnu.org; Mon, 08 Feb 2021 13:24:16 -0500 Received: by mail-wr1-x42d.google.com with SMTP id u14so18423752wri.3 for ; Mon, 08 Feb 2021 10:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I2Aph69adGLflQzOi00r3lbWRxRLJVNf2GcXimWPXvU=; b=NDaD1VG6ilh1S+I8WCxrGpQQMaii2+qUXEE2DdKTMicN9jIMvZ2LKw14g3VL0swj2/ lytrgeStxTcGFc9H81CcPQ1fp3Xlu7uh1BFiC0x6ZzCTEcAfd9MwuX7YsI6HVRRiOtQx Jneu5GdIkH47vl5WUVqOUciGOceZGj9K1FTMaoQXr6vBzQBcaOQqX9KW16tNsqfKeqha XvMFiIKpqUh9fZYtVq99JLkvsm2AsVNBtmn6csvClLZI9h67fhSCXbqFElGe8Il9p9jh 6Nxf6bIhwwc+HdytOWVL1nA5NQWhiKi01tYj3lMThjooiRFgS8CSFZdSLVEciTQyGB5+ Yegw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=I2Aph69adGLflQzOi00r3lbWRxRLJVNf2GcXimWPXvU=; b=EoVPF50v/YCIvY57gU5y2kTNSdzI/Ku+m1jvx9QGxVTtd7zCSnZtkwoa5fXBwMKvjT kQq+s6diEQ6nvag3AH/or+dRxLR7nDofT5bMkkeKd3bapbvzrgYbThSESsVAlk8FKU9t idZrguFGr7UmQFhNkv4kAkWThCIZo6LQHDgrGjqEvZv6SKRdQeZlR3ovVLMdjFEhuo/W rf8HfSZmQQjKPffSTM4g46ZDBZYSS94SyprqrPw73hBsgt2AK8ZPr3LXfsWEepDXllfy 5G+9AV7jI45eEiam6wZJcews6vUOfF6wfxNA/01+mEruyFjUArz9e9NKYMgrwUwxb0mj 8rzA== X-Gm-Message-State: AOAM533tQJsP/rGsBp6SEjuCre1rYMs+TvOiEvc/jKtrgBzxP0nTYikh rFHd/k12mhLYa42Zba5QqAB3UVOCMymixA== X-Google-Smtp-Source: ABdhPJwZN8zLSBj5SGcZYcsa0/lwTSGBQ/F8XohP0fNFg9Pp3gdNI/IwNZP8/a/n+2lE3US9bfyzsw== X-Received: by 2002:a05:6000:1806:: with SMTP id m6mr12811676wrh.320.1612808651363; Mon, 08 Feb 2021 10:24:11 -0800 (PST) Received: from avogadro.redhat.com ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x22sm19670wmc.25.2021.02.08.10.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 10:24:10 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 40/46] prep: add ppc-parity write method Date: Mon, 8 Feb 2021 19:23:25 +0100 Message-Id: <20210208182331.58897-41-pbonzini@redhat.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210208182331.58897-1-pbonzini@redhat.com> References: <20210208182331.58897-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=paolo.bonzini@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lei Sun , Li Qiang , Prasad J Pandit , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Prasad J Pandit Add ppc-parity mmio write method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Acked-by: David Gibson Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang Message-Id: <20200811114133.672647-5-ppandit@redhat.com> Signed-off-by: Paolo Bonzini --- hw/ppc/prep_systemio.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/ppc/prep_systemio.c b/hw/ppc/prep_systemio.c index 4e48ef245c..b2bd783248 100644 --- a/hw/ppc/prep_systemio.c +++ b/hw/ppc/prep_systemio.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/irq.h" #include "hw/isa/isa.h" #include "hw/qdev-properties.h" @@ -235,8 +236,15 @@ static uint64_t ppc_parity_error_readl(void *opaque, hwaddr addr, return val; } +static void ppc_parity_error_writel(void *opaque, hwaddr addr, + uint64_t data, unsigned size) +{ + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid access\n", __func__); +} + static const MemoryRegionOps ppc_parity_error_ops = { .read = ppc_parity_error_readl, + .write = ppc_parity_error_writel, .valid = { .min_access_size = 4, .max_access_size = 4, -- 2.29.2