From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E87C433E6 for ; Mon, 8 Feb 2021 20:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A890564DF6 for ; Mon, 8 Feb 2021 20:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236837AbhBHU1V (ORCPT ); Mon, 8 Feb 2021 15:27:21 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:42212 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234466AbhBHTD5 (ORCPT ); Mon, 8 Feb 2021 14:03:57 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118Ig3VL139458; Mon, 8 Feb 2021 19:02:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Wf1goJTBSSWI4TQ+CnoSP72sPATBhea/Oy07byYA2aQ=; b=YiQ7qbtaQJpNs7E8LDkAGAGWx3f8c0gDQWzg5UuJpL3eX89ErwSg/ruvjtTsX9HtGoTS /gm4pdPPC3on+FKKrn5Ku/qjfRpKDcyV5N+8mzpBF3UZ37owN+e8PvDa74ftVH+PKwDN LPRSTaIQI6MruzrXQPwx1pIURr3ev9vGmQBrDF7QM+Xgl9zo3agZ3dZOdgbMSMjdbEi7 yWvCwBN3/jMOZzLubY7N/KmrQybO+Nyqzp/m/IY/seLCkkHy9IsYfkBNJQZsGOevMUCo Rt1i0IOsSlmOItkydxdVVcggcUUBdqWLl6VQDXBkDPuiCuHX82iYrOMdWqozzigHPfwv 5w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 36hkrmvypp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:58 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118IfOsS124606; Mon, 8 Feb 2021 19:02:56 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 36j5107qst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:56 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 118J2q92015415; Mon, 8 Feb 2021 19:02:52 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Feb 2021 11:02:52 -0800 Date: Mon, 8 Feb 2021 22:02:37 +0300 From: Dan Carpenter To: Sascha Hauer Cc: Youling Tang , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] staging: fix ignoring return value warning Message-ID: <20210208190237.GN20820@kadam> References: <1612689808-30985-1-git-send-email-tangyouling@loongson.cn> <20210208134517.GG2696@kadam> <20210208150618.GI8233@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208150618.GI8233@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2021 at 04:06:18PM +0100, Sascha Hauer wrote: > Hi Dan, > > On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > > Fix the below ignoring return value warning for device_reset. > > > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > drivers/staging/ralink-gdma/ralink-gdma.c:836:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > > > > > We can't really do this sort of fix without the hardware to test it. > > This could be the correct fix or perhaps switching to device_reset_optional() > > is the correct fix. We can't know unless we have the hardware to test. > > When device_reset() is the wrong function then adding a return value > check will turn this into a runtime error for those who have the > hardware which will hopefully trigger them to tell us why reset_device > is wrong for them. > At least for a staging driver I find this procedure opportune. > That seems like sort of a jerk move... What's the rush? Someone will eventually be able to test this if we just wait around for a bit. Otherwise if no one has the hardware then eventually the driver will be deleted. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04A1C433DB for ; Mon, 8 Feb 2021 19:03:05 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36EF664E59 for ; Mon, 8 Feb 2021 19:03:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36EF664E59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D90962094C; Mon, 8 Feb 2021 19:03:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gvb0Y7N5cdbW; Mon, 8 Feb 2021 19:03:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id BDC5521080; Mon, 8 Feb 2021 19:03:02 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D89671BF2A9 for ; Mon, 8 Feb 2021 19:03:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D529E85E85 for ; Mon, 8 Feb 2021 19:03:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RNrV4K_XmfZN for ; Mon, 8 Feb 2021 19:03:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 5737885DFC for ; Mon, 8 Feb 2021 19:03:01 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118Ig3VL139458; Mon, 8 Feb 2021 19:02:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Wf1goJTBSSWI4TQ+CnoSP72sPATBhea/Oy07byYA2aQ=; b=YiQ7qbtaQJpNs7E8LDkAGAGWx3f8c0gDQWzg5UuJpL3eX89ErwSg/ruvjtTsX9HtGoTS /gm4pdPPC3on+FKKrn5Ku/qjfRpKDcyV5N+8mzpBF3UZ37owN+e8PvDa74ftVH+PKwDN LPRSTaIQI6MruzrXQPwx1pIURr3ev9vGmQBrDF7QM+Xgl9zo3agZ3dZOdgbMSMjdbEi7 yWvCwBN3/jMOZzLubY7N/KmrQybO+Nyqzp/m/IY/seLCkkHy9IsYfkBNJQZsGOevMUCo Rt1i0IOsSlmOItkydxdVVcggcUUBdqWLl6VQDXBkDPuiCuHX82iYrOMdWqozzigHPfwv 5w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 36hkrmvypp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:58 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118IfOsS124606; Mon, 8 Feb 2021 19:02:56 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 36j5107qst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:56 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 118J2q92015415; Mon, 8 Feb 2021 19:02:52 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Feb 2021 11:02:52 -0800 Date: Mon, 8 Feb 2021 22:02:37 +0300 From: Dan Carpenter To: Sascha Hauer Subject: Re: [PATCH] staging: fix ignoring return value warning Message-ID: <20210208190237.GN20820@kadam> References: <1612689808-30985-1-git-send-email-tangyouling@loongson.cn> <20210208134517.GG2696@kadam> <20210208150618.GI8233@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208150618.GI8233@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Youling Tang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Feb 08, 2021 at 04:06:18PM +0100, Sascha Hauer wrote: > Hi Dan, > > On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > > Fix the below ignoring return value warning for device_reset. > > > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > drivers/staging/ralink-gdma/ralink-gdma.c:836:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > > > > > We can't really do this sort of fix without the hardware to test it. > > This could be the correct fix or perhaps switching to device_reset_optional() > > is the correct fix. We can't know unless we have the hardware to test. > > When device_reset() is the wrong function then adding a return value > check will turn this into a runtime error for those who have the > hardware which will hopefully trigger them to tell us why reset_device > is wrong for them. > At least for a staging driver I find this procedure opportune. > That seems like sort of a jerk move... What's the rush? Someone will eventually be able to test this if we just wait around for a bit. Otherwise if no one has the hardware then eventually the driver will be deleted. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72430C433E0 for ; Mon, 8 Feb 2021 19:03:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01CAB64E59 for ; Mon, 8 Feb 2021 19:03:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01CAB64E59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bYcCKElU1gFW6cGTAeLQBx5XsI2fQmpetbFB11IG94w=; b=RxCd0W1SdSUlIlykuvb70oSha C2wVGlMZ+CrO2QV53VzuTy98p4TtMbhw//6ucnS1K/UMCQWt7FaufLd9ZRvp/d/zj5A8eNMdxwFQJ zF6IlH/V82Pw+42BV1hWqymixHkZe7pQdNZ48AO0zBYyWjxWifY3FAyIL9au0mqSGXzUTo0sw0syy rKbmwPFwp+8AUWIClR3HLRyt2VwTmOTmpvQmqLvXle/g39KVcUkV1RkyHV0O+5Booy8mIpDhir8MU oYSXGjeAVWxS31xMYxXV/Y/lX/gLaZOVQw+VNd5sJSmhbduirmifmVSpI3oatdAcXi9ZxsuSE0oFm 0w7kCbZ2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9BoV-0002fs-E0; Mon, 08 Feb 2021 19:03:11 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9BoS-0002ee-CG; Mon, 08 Feb 2021 19:03:09 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118Ig3VL139458; Mon, 8 Feb 2021 19:02:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Wf1goJTBSSWI4TQ+CnoSP72sPATBhea/Oy07byYA2aQ=; b=YiQ7qbtaQJpNs7E8LDkAGAGWx3f8c0gDQWzg5UuJpL3eX89ErwSg/ruvjtTsX9HtGoTS /gm4pdPPC3on+FKKrn5Ku/qjfRpKDcyV5N+8mzpBF3UZ37owN+e8PvDa74ftVH+PKwDN LPRSTaIQI6MruzrXQPwx1pIURr3ev9vGmQBrDF7QM+Xgl9zo3agZ3dZOdgbMSMjdbEi7 yWvCwBN3/jMOZzLubY7N/KmrQybO+Nyqzp/m/IY/seLCkkHy9IsYfkBNJQZsGOevMUCo Rt1i0IOsSlmOItkydxdVVcggcUUBdqWLl6VQDXBkDPuiCuHX82iYrOMdWqozzigHPfwv 5w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 36hkrmvypp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:58 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118IfOsS124606; Mon, 8 Feb 2021 19:02:56 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 36j5107qst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:56 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 118J2q92015415; Mon, 8 Feb 2021 19:02:52 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Feb 2021 11:02:52 -0800 Date: Mon, 8 Feb 2021 22:02:37 +0300 From: Dan Carpenter To: Sascha Hauer Subject: Re: [PATCH] staging: fix ignoring return value warning Message-ID: <20210208190237.GN20820@kadam> References: <1612689808-30985-1-git-send-email-tangyouling@loongson.cn> <20210208134517.GG2696@kadam> <20210208150618.GI8233@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208150618.GI8233@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_140308_610845_AEAD4485 X-CRM114-Status: GOOD ( 28.33 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Youling Tang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 04:06:18PM +0100, Sascha Hauer wrote: > Hi Dan, > > On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > > Fix the below ignoring return value warning for device_reset. > > > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > drivers/staging/ralink-gdma/ralink-gdma.c:836:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > > > > > We can't really do this sort of fix without the hardware to test it. > > This could be the correct fix or perhaps switching to device_reset_optional() > > is the correct fix. We can't know unless we have the hardware to test. > > When device_reset() is the wrong function then adding a return value > check will turn this into a runtime error for those who have the > hardware which will hopefully trigger them to tell us why reset_device > is wrong for them. > At least for a staging driver I find this procedure opportune. > That seems like sort of a jerk move... What's the rush? Someone will eventually be able to test this if we just wait around for a bit. Otherwise if no one has the hardware then eventually the driver will be deleted. regards, dan carpenter _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D043C433E0 for ; Mon, 8 Feb 2021 19:04:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A9D364E73 for ; Mon, 8 Feb 2021 19:04:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A9D364E73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cdMQOPCGrBQFfAeCbY7bnOB6NmTX6/ZfTK34vv69GF8=; b=GgYp6rUkHwqPT64i7HKvYlvao y1kCHmLjPDIZlTTbA9ju0sruWQa+TEvtskLwcawPi/6eDYDaHo50HLakvNJvgItnEZwZxaP5flcK8 923aOI8SmydaMgvlslKUm0qqfYlj8XFqYGK+zwhat6BzeFxg2+bn7Sn3mOL5/GLCMU7ioheGb9+Pe va+4I3Qw8dkvQvmZ3iV8zefjpnplnLdgD9ilX7r3s+Sx/saq8Tx9FftJdQf+747z/LzLt9fH8ohs2 APxkRHLljmBJF/fshNeHfJHhdAJ3hsgyWB90Dp5TzZCzq/7cGbl9U8lHdMd3bR2Ko/fH0aOEHLtdv potW7K4Mg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9BoX-0002gS-0D; Mon, 08 Feb 2021 19:03:13 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9BoS-0002ee-CG; Mon, 08 Feb 2021 19:03:09 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118Ig3VL139458; Mon, 8 Feb 2021 19:02:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Wf1goJTBSSWI4TQ+CnoSP72sPATBhea/Oy07byYA2aQ=; b=YiQ7qbtaQJpNs7E8LDkAGAGWx3f8c0gDQWzg5UuJpL3eX89ErwSg/ruvjtTsX9HtGoTS /gm4pdPPC3on+FKKrn5Ku/qjfRpKDcyV5N+8mzpBF3UZ37owN+e8PvDa74ftVH+PKwDN LPRSTaIQI6MruzrXQPwx1pIURr3ev9vGmQBrDF7QM+Xgl9zo3agZ3dZOdgbMSMjdbEi7 yWvCwBN3/jMOZzLubY7N/KmrQybO+Nyqzp/m/IY/seLCkkHy9IsYfkBNJQZsGOevMUCo Rt1i0IOsSlmOItkydxdVVcggcUUBdqWLl6VQDXBkDPuiCuHX82iYrOMdWqozzigHPfwv 5w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 36hkrmvypp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:58 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 118IfOsS124606; Mon, 8 Feb 2021 19:02:56 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 36j5107qst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Feb 2021 19:02:56 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 118J2q92015415; Mon, 8 Feb 2021 19:02:52 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Feb 2021 11:02:52 -0800 Date: Mon, 8 Feb 2021 22:02:37 +0300 From: Dan Carpenter To: Sascha Hauer Subject: Re: [PATCH] staging: fix ignoring return value warning Message-ID: <20210208190237.GN20820@kadam> References: <1612689808-30985-1-git-send-email-tangyouling@loongson.cn> <20210208134517.GG2696@kadam> <20210208150618.GI8233@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208150618.GI8233@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9889 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080114 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_140308_610845_AEAD4485 X-CRM114-Status: GOOD ( 28.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Youling Tang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 04:06:18PM +0100, Sascha Hauer wrote: > Hi Dan, > > On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > > Fix the below ignoring return value warning for device_reset. > > > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > drivers/staging/ralink-gdma/ralink-gdma.c:836:2: warning: ignoring return value > > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > > device_reset(&pdev->dev); > > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > > > > > We can't really do this sort of fix without the hardware to test it. > > This could be the correct fix or perhaps switching to device_reset_optional() > > is the correct fix. We can't know unless we have the hardware to test. > > When device_reset() is the wrong function then adding a return value > check will turn this into a runtime error for those who have the > hardware which will hopefully trigger them to tell us why reset_device > is wrong for them. > At least for a staging driver I find this procedure opportune. > That seems like sort of a jerk move... What's the rush? Someone will eventually be able to test this if we just wait around for a bit. Otherwise if no one has the hardware then eventually the driver will be deleted. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel