* [PATCH] ext4: delete some unused tracepoint definitions
@ 2021-02-09 22:19 Eric Whitney
2021-02-16 19:18 ` Eric Whitney
0 siblings, 1 reply; 2+ messages in thread
From: Eric Whitney @ 2021-02-09 22:19 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, Eric Whitney
A number of tracepoint instances have been removed from ext4 by past
patches but the definitions of those tracepoints have not.
All instances of ext4_ext_in_cache and ext4_ext_put_in_cache were
removed by "ext4: remove single extent cache" (69eb33dc24dc).
ext4_get_reserved_cluster_alloc was removed by
"ext4: reduce reserved cluster count by number of allocated clusters"
(b6bf9171ef5c).
ext4_find_delalloc_range was removed by
"ext4: reimplement ext4_find_delay_alloc_range on extent status tree"
(7d1b1fbc95eb).
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
include/trace/events/ext4.h | 118 ------------------------------------
1 file changed, 118 deletions(-)
diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
index 70ae5497b73a..3c3f40605391 100644
--- a/include/trace/events/ext4.h
+++ b/include/trace/events/ext4.h
@@ -1962,124 +1962,6 @@ TRACE_EVENT(ext4_get_implied_cluster_alloc_exit,
__entry->len, show_mflags(__entry->flags), __entry->ret)
);
-TRACE_EVENT(ext4_ext_put_in_cache,
- TP_PROTO(struct inode *inode, ext4_lblk_t lblk, unsigned int len,
- ext4_fsblk_t start),
-
- TP_ARGS(inode, lblk, len, start),
-
- TP_STRUCT__entry(
- __field( dev_t, dev )
- __field( ino_t, ino )
- __field( ext4_lblk_t, lblk )
- __field( unsigned int, len )
- __field( ext4_fsblk_t, start )
- ),
-
- TP_fast_assign(
- __entry->dev = inode->i_sb->s_dev;
- __entry->ino = inode->i_ino;
- __entry->lblk = lblk;
- __entry->len = len;
- __entry->start = start;
- ),
-
- TP_printk("dev %d,%d ino %lu lblk %u len %u start %llu",
- MAJOR(__entry->dev), MINOR(__entry->dev),
- (unsigned long) __entry->ino,
- (unsigned) __entry->lblk,
- __entry->len,
- (unsigned long long) __entry->start)
-);
-
-TRACE_EVENT(ext4_ext_in_cache,
- TP_PROTO(struct inode *inode, ext4_lblk_t lblk, int ret),
-
- TP_ARGS(inode, lblk, ret),
-
- TP_STRUCT__entry(
- __field( dev_t, dev )
- __field( ino_t, ino )
- __field( ext4_lblk_t, lblk )
- __field( int, ret )
- ),
-
- TP_fast_assign(
- __entry->dev = inode->i_sb->s_dev;
- __entry->ino = inode->i_ino;
- __entry->lblk = lblk;
- __entry->ret = ret;
- ),
-
- TP_printk("dev %d,%d ino %lu lblk %u ret %d",
- MAJOR(__entry->dev), MINOR(__entry->dev),
- (unsigned long) __entry->ino,
- (unsigned) __entry->lblk,
- __entry->ret)
-
-);
-
-TRACE_EVENT(ext4_find_delalloc_range,
- TP_PROTO(struct inode *inode, ext4_lblk_t from, ext4_lblk_t to,
- int reverse, int found, ext4_lblk_t found_blk),
-
- TP_ARGS(inode, from, to, reverse, found, found_blk),
-
- TP_STRUCT__entry(
- __field( dev_t, dev )
- __field( ino_t, ino )
- __field( ext4_lblk_t, from )
- __field( ext4_lblk_t, to )
- __field( int, reverse )
- __field( int, found )
- __field( ext4_lblk_t, found_blk )
- ),
-
- TP_fast_assign(
- __entry->dev = inode->i_sb->s_dev;
- __entry->ino = inode->i_ino;
- __entry->from = from;
- __entry->to = to;
- __entry->reverse = reverse;
- __entry->found = found;
- __entry->found_blk = found_blk;
- ),
-
- TP_printk("dev %d,%d ino %lu from %u to %u reverse %d found %d "
- "(blk = %u)",
- MAJOR(__entry->dev), MINOR(__entry->dev),
- (unsigned long) __entry->ino,
- (unsigned) __entry->from, (unsigned) __entry->to,
- __entry->reverse, __entry->found,
- (unsigned) __entry->found_blk)
-);
-
-TRACE_EVENT(ext4_get_reserved_cluster_alloc,
- TP_PROTO(struct inode *inode, ext4_lblk_t lblk, unsigned int len),
-
- TP_ARGS(inode, lblk, len),
-
- TP_STRUCT__entry(
- __field( dev_t, dev )
- __field( ino_t, ino )
- __field( ext4_lblk_t, lblk )
- __field( unsigned int, len )
- ),
-
- TP_fast_assign(
- __entry->dev = inode->i_sb->s_dev;
- __entry->ino = inode->i_ino;
- __entry->lblk = lblk;
- __entry->len = len;
- ),
-
- TP_printk("dev %d,%d ino %lu lblk %u len %u",
- MAJOR(__entry->dev), MINOR(__entry->dev),
- (unsigned long) __entry->ino,
- (unsigned) __entry->lblk,
- __entry->len)
-);
-
TRACE_EVENT(ext4_ext_show_extent,
TP_PROTO(struct inode *inode, ext4_lblk_t lblk, ext4_fsblk_t pblk,
unsigned short len),
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: delete some unused tracepoint definitions
2021-02-09 22:19 [PATCH] ext4: delete some unused tracepoint definitions Eric Whitney
@ 2021-02-16 19:18 ` Eric Whitney
0 siblings, 0 replies; 2+ messages in thread
From: Eric Whitney @ 2021-02-16 19:18 UTC (permalink / raw)
To: Eric Whitney; +Cc: linux-ext4, tytso
* Eric Whitney <enwlinux@gmail.com>:
> A number of tracepoint instances have been removed from ext4 by past
> patches but the definitions of those tracepoints have not.
>
> All instances of ext4_ext_in_cache and ext4_ext_put_in_cache were
> removed by "ext4: remove single extent cache" (69eb33dc24dc).
> ext4_get_reserved_cluster_alloc was removed by
> "ext4: reduce reserved cluster count by number of allocated clusters"
> (b6bf9171ef5c).
> ext4_find_delalloc_range was removed by
> "ext4: reimplement ext4_find_delay_alloc_range on extent status tree"
> (7d1b1fbc95eb).
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
> ---
> include/trace/events/ext4.h | 118 ------------------------------------
> 1 file changed, 118 deletions(-)
>
> diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> index 70ae5497b73a..3c3f40605391 100644
> --- a/include/trace/events/ext4.h
> +++ b/include/trace/events/ext4.h
> @@ -1962,124 +1962,6 @@ TRACE_EVENT(ext4_get_implied_cluster_alloc_exit,
> __entry->len, show_mflags(__entry->flags), __entry->ret)
> );
>
> -TRACE_EVENT(ext4_ext_put_in_cache,
> - TP_PROTO(struct inode *inode, ext4_lblk_t lblk, unsigned int len,
> - ext4_fsblk_t start),
> -
> - TP_ARGS(inode, lblk, len, start),
> -
> - TP_STRUCT__entry(
> - __field( dev_t, dev )
> - __field( ino_t, ino )
> - __field( ext4_lblk_t, lblk )
> - __field( unsigned int, len )
> - __field( ext4_fsblk_t, start )
> - ),
> -
> - TP_fast_assign(
> - __entry->dev = inode->i_sb->s_dev;
> - __entry->ino = inode->i_ino;
> - __entry->lblk = lblk;
> - __entry->len = len;
> - __entry->start = start;
> - ),
> -
> - TP_printk("dev %d,%d ino %lu lblk %u len %u start %llu",
> - MAJOR(__entry->dev), MINOR(__entry->dev),
> - (unsigned long) __entry->ino,
> - (unsigned) __entry->lblk,
> - __entry->len,
> - (unsigned long long) __entry->start)
> -);
> -
> -TRACE_EVENT(ext4_ext_in_cache,
> - TP_PROTO(struct inode *inode, ext4_lblk_t lblk, int ret),
> -
> - TP_ARGS(inode, lblk, ret),
> -
> - TP_STRUCT__entry(
> - __field( dev_t, dev )
> - __field( ino_t, ino )
> - __field( ext4_lblk_t, lblk )
> - __field( int, ret )
> - ),
> -
> - TP_fast_assign(
> - __entry->dev = inode->i_sb->s_dev;
> - __entry->ino = inode->i_ino;
> - __entry->lblk = lblk;
> - __entry->ret = ret;
> - ),
> -
> - TP_printk("dev %d,%d ino %lu lblk %u ret %d",
> - MAJOR(__entry->dev), MINOR(__entry->dev),
> - (unsigned long) __entry->ino,
> - (unsigned) __entry->lblk,
> - __entry->ret)
> -
> -);
> -
> -TRACE_EVENT(ext4_find_delalloc_range,
> - TP_PROTO(struct inode *inode, ext4_lblk_t from, ext4_lblk_t to,
> - int reverse, int found, ext4_lblk_t found_blk),
> -
> - TP_ARGS(inode, from, to, reverse, found, found_blk),
> -
> - TP_STRUCT__entry(
> - __field( dev_t, dev )
> - __field( ino_t, ino )
> - __field( ext4_lblk_t, from )
> - __field( ext4_lblk_t, to )
> - __field( int, reverse )
> - __field( int, found )
> - __field( ext4_lblk_t, found_blk )
> - ),
> -
> - TP_fast_assign(
> - __entry->dev = inode->i_sb->s_dev;
> - __entry->ino = inode->i_ino;
> - __entry->from = from;
> - __entry->to = to;
> - __entry->reverse = reverse;
> - __entry->found = found;
> - __entry->found_blk = found_blk;
> - ),
> -
> - TP_printk("dev %d,%d ino %lu from %u to %u reverse %d found %d "
> - "(blk = %u)",
> - MAJOR(__entry->dev), MINOR(__entry->dev),
> - (unsigned long) __entry->ino,
> - (unsigned) __entry->from, (unsigned) __entry->to,
> - __entry->reverse, __entry->found,
> - (unsigned) __entry->found_blk)
> -);
> -
> -TRACE_EVENT(ext4_get_reserved_cluster_alloc,
> - TP_PROTO(struct inode *inode, ext4_lblk_t lblk, unsigned int len),
> -
> - TP_ARGS(inode, lblk, len),
> -
> - TP_STRUCT__entry(
> - __field( dev_t, dev )
> - __field( ino_t, ino )
> - __field( ext4_lblk_t, lblk )
> - __field( unsigned int, len )
> - ),
> -
> - TP_fast_assign(
> - __entry->dev = inode->i_sb->s_dev;
> - __entry->ino = inode->i_ino;
> - __entry->lblk = lblk;
> - __entry->len = len;
> - ),
> -
> - TP_printk("dev %d,%d ino %lu lblk %u len %u",
> - MAJOR(__entry->dev), MINOR(__entry->dev),
> - (unsigned long) __entry->ino,
> - (unsigned) __entry->lblk,
> - __entry->len)
> -);
> -
> TRACE_EVENT(ext4_ext_show_extent,
> TP_PROTO(struct inode *inode, ext4_lblk_t lblk, ext4_fsblk_t pblk,
> unsigned short len),
> --
> 2.20.1
>
Please ignore this patch - I've posted an updated v2.
Thanks,
Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-16 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 22:19 [PATCH] ext4: delete some unused tracepoint definitions Eric Whitney
2021-02-16 19:18 ` Eric Whitney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.