From: Herbert Xu <herbert@gondor.apana.org.au>
To: Meng Yu <yumeng18@huawei.com>
Cc: davem@davemloft.net, marcel@holtmann.org,
johan.hedberg@gmail.com, luiz.dentz@gmail.com,
tudor.ambarus@microchip.com, linux-crypto@vger.kernel.org,
xuzaibo@huawei.com, wangzhou1@hisilicon.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/9] crypto: atmel-ecc - move curve_id of ECDH from the key to algorithm name
Date: Wed, 10 Feb 2021 15:56:30 +1100 [thread overview]
Message-ID: <20210210045630.GA7510@gondor.apana.org.au> (raw)
In-Reply-To: <1612777137-51067-4-git-send-email-yumeng18@huawei.com>
On Mon, Feb 08, 2021 at 05:38:51PM +0800, Meng Yu wrote:
> As curve id of ECDH will be moved from its key into algorithm name,
> we cannot use 'curve_id' in 'struct ecdh', so we should modify ECDH
> driver in atmel, and make ECDH algorithm name be the same as crypto
> (like 'ecdh-nist-pxxx');
>
> Signed-off-by: Meng Yu <yumeng18@huawei.com>
> Reviewed-by: Zaibo Xu <xuzaibo@huawei.com>
> ---
> drivers/crypto/atmel-ecc.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Patches 3-5 need to be squashed into one in order to avoid future
bisection failures.
The alternative is to let the new/old names coexist but it's probably
not worth it for this case as the number of drivers impacted is small.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-02-10 4:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 9:38 [PATCH v8 0/9] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Meng Yu
2021-02-08 9:38 ` [PATCH v8 1/9] crypto: hisilicon/hpre - add version adapt to new algorithms Meng Yu
2021-02-08 9:38 ` [PATCH v8 2/9] crypto: hisilicon/hpre - add algorithm type Meng Yu
2021-02-08 9:38 ` [PATCH v8 3/9] crypto: atmel-ecc - move curve_id of ECDH from the key to algorithm name Meng Yu
2021-02-10 4:56 ` Herbert Xu [this message]
2021-02-18 2:14 ` yumeng
2021-02-08 9:38 ` [PATCH v8 4/9] net/bluetooth: modify ECDH name in 'crypto_alloc_kpp' Meng Yu
2021-02-08 9:38 ` [PATCH v8 5/9] crypto: move curve_id of ECDH to algorithm name Meng Yu
2021-02-09 3:48 ` kernel test robot
2021-02-09 3:48 ` kernel test robot
2021-02-09 5:33 ` kernel test robot
2021-02-09 5:33 ` kernel test robot
2021-02-08 9:38 ` [PATCH v8 6/9] crypto: add new ecc curve and expose them Meng Yu
2021-02-08 9:38 ` [PATCH v8 7/9] crypto: hisilicon/hpre - add 'ECDH' algorithm Meng Yu
2021-02-10 4:57 ` Herbert Xu
2021-02-18 2:24 ` yumeng
2021-02-18 20:01 ` Herbert Xu
2021-02-19 1:25 ` yumeng
2021-02-19 4:01 ` Herbert Xu
2021-02-08 9:38 ` [PATCH v8 8/9] crypto: add curve25519 params and expose them Meng Yu
2021-02-08 9:38 ` [PATCH v8 9/9] crypto: hisilicon/hpre - add 'CURVE25519' algorithm Meng Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210045630.GA7510@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=tudor.ambarus@microchip.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=yumeng18@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.