From: Vladimir Oltean <olteanv@gmail.com>
To: George McCollister <george.mccollister@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/4] net: hsr: generate supervision frame without HSR/PRP tag
Date: Wed, 10 Feb 2021 11:33:10 +0200 [thread overview]
Message-ID: <20210210093310.c3el4m57hmso4kya@skbuf> (raw)
In-Reply-To: <20210210010213.27553-2-george.mccollister@gmail.com>
On Tue, Feb 09, 2021 at 07:02:10PM -0600, George McCollister wrote:
> For a switch to offload insertion of HSR/PRP tags, frames must not be
> sent to the CPU facing switch port with a tag. Generate supervision frames
> (eth type ETH_P_PRP) without HSR v1 (ETH_P_HSR)/PRP tag and rely on
> create_tagged_frame which inserts it later. This will allow skipping the
> tag insertion for all outgoing frames in the future which is required for
> HSR v1/PRP tag insertions to be offloaded.
>
> HSR v0 supervision frames always contain tag information so insertion of
> the tag can't be offloaded. IEC 62439-3 Ed.2.0 (HSR v1) specifically
> notes that this was changed since v0 to allow offloading.
>
> Signed-off-by: George McCollister <george.mccollister@gmail.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Tested-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2021-02-10 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 1:02 [PATCH net-next v3 0/4] add HSR offloading support for DSA switches George McCollister
2021-02-10 1:02 ` [PATCH net-next v3 1/4] net: hsr: generate supervision frame without HSR/PRP tag George McCollister
2021-02-10 9:33 ` Vladimir Oltean [this message]
2021-02-10 1:02 ` [PATCH net-next v3 2/4] net: hsr: add offloading support George McCollister
2021-02-10 9:37 ` Vladimir Oltean
2021-02-10 1:02 ` [PATCH net-next v3 3/4] net: dsa: add support for offloading HSR George McCollister
2021-02-10 4:04 ` Florian Fainelli
2021-02-10 9:44 ` Vladimir Oltean
2021-02-10 1:02 ` [PATCH net-next v3 4/4] net: dsa: xrs700x: add HSR offloading support George McCollister
2021-02-10 4:11 ` Florian Fainelli
2021-02-10 9:49 ` Vladimir Oltean
2021-02-11 22:00 ` [PATCH net-next v3 0/4] add HSR offloading support for DSA switches patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210093310.c3el4m57hmso4kya@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.