From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [android-common:android12-5.10 3/5] drivers/dma-buf/heaps/page_pool.c:242:5: warning: no previous prototype for 'dmabuf_page_pool_init_shrinker'
Date: Wed, 10 Feb 2021 11:21:48 +0800 [thread overview]
Message-ID: <202102101106.bBw5BMzc-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2791 bytes --]
CC: kbuild-all(a)lists.01.org
TO: cros-kernel-buildreports(a)googlegroups.com
tree: https://android.googlesource.com/kernel/common android12-5.10
head: d50b67ac7551b81ae82e70c6f2811073ba3575ba
commit: 23762f02e172f146ccd160e36ed43483f2304aaf [3/5] ANDROID: dma-buf: system_heap: Add pagepool support to system heap
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: i386-randconfig-s002-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android12-5.10
git checkout 23762f02e172f146ccd160e36ed43483f2304aaf
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/dma-buf/heaps/page_pool.c:242:5: warning: no previous prototype for 'dmabuf_page_pool_init_shrinker' [-Wmissing-prototypes]
242 | int dmabuf_page_pool_init_shrinker(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"sparse warnings: (new ones prefixed by >>)"
>> drivers/dma-buf/heaps/page_pool.c:235:17: sparse: sparse: symbol 'pool_shrinker' was not declared. Should it be static?
>> drivers/dma-buf/heaps/page_pool.c:242:5: sparse: sparse: symbol 'dmabuf_page_pool_init_shrinker' was not declared. Should it be static?
Please review and possibly fold the followup patch.
vim +/dmabuf_page_pool_init_shrinker +242 drivers/dma-buf/heaps/page_pool.c
e7dac4c3231c0e John Stultz 2020-10-02 234
e7dac4c3231c0e John Stultz 2020-10-02 @235 struct shrinker pool_shrinker = {
e7dac4c3231c0e John Stultz 2020-10-02 236 .count_objects = dmabuf_page_pool_shrink_count,
e7dac4c3231c0e John Stultz 2020-10-02 237 .scan_objects = dmabuf_page_pool_shrink_scan,
e7dac4c3231c0e John Stultz 2020-10-02 238 .seeks = DEFAULT_SEEKS,
e7dac4c3231c0e John Stultz 2020-10-02 239 .batch = 0,
e7dac4c3231c0e John Stultz 2020-10-02 240 };
e7dac4c3231c0e John Stultz 2020-10-02 241
e7dac4c3231c0e John Stultz 2020-10-02 @242 int dmabuf_page_pool_init_shrinker(void)
:::::: The code at line 242 was first introduced by commit
:::::: e7dac4c3231c0e8adeef8dbb732b2cde7c162b14 ANDROID: dma-buf: heaps: Add a shrinker controlled page pool
:::::: TO: John Stultz <john.stultz@linaro.org>
:::::: CC: Hridya Valsaraju <hridya@google.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34642 bytes --]
next reply other threads:[~2021-02-10 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 3:21 kernel test robot [this message]
2021-02-10 3:21 ` [RFC PATCH android-common] ANDROID: dma-buf: system_heap: pool_shrinker can be static kernel test robot
2021-02-10 12:14 [android-common:android12-5.10 3/5] drivers/dma-buf/heaps/page_pool.c:242:5: warning: no previous prototype for 'dmabuf_page_pool_init_shrinker' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102101106.bBw5BMzc-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.