From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4291C43381 for ; Wed, 10 Feb 2021 14:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB14164E9D for ; Wed, 10 Feb 2021 14:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231650AbhBJOLG (ORCPT ); Wed, 10 Feb 2021 09:11:06 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:20830 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbhBJOKz (ORCPT ); Wed, 10 Feb 2021 09:10:55 -0500 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11AE0OIr011326; Wed, 10 Feb 2021 06:10:04 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=PWnnzGuk/ieIQSw2dLZPjY03chHqOhLoJqWbCzDUdbY=; b=cHHRItzhU3ry59G5WG8+/Q42T/304ozlhLOoCwFye3P+Okorn6VIuF4xAWRE4N4A5Q++ liLFynWyAxJq+flG/sKFvSgQSzTAoQl9w4TvEFyPqBiwjKcLsp+FKDm5A7Jz3Q4uxrA0 JavTjXTddEJC2oviktAOJPsdNr1GP23HO1J4IRBGUcarZTn7Nm/EMb0NEzaPSedD1GJy A2SX8DGD/yHZLQnCF6jkN+YWYDA4CtPYnw+WUstlwRWNak4eP+8vxPOCnOcTK2pfCA/j UBC+z8lhZeFCtzZvhOVYoyLX/9KmUPHtvSUU9SyIdP5Z8zU82HiLk2jAl73oiHiydg9K EQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com with ESMTP id 36hugqbryv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 10 Feb 2021 06:10:04 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Feb 2021 06:10:02 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 10 Feb 2021 06:10:02 -0800 Received: from octopus.marvell.com (octopus.marvell.com [10.5.24.3]) by maili.marvell.com (Postfix) with ESMTP id 8DC043F703F; Wed, 10 Feb 2021 06:09:59 -0800 (PST) From: To: , , CC: , , , , , , , , , , "Konstantin Porotchkin" Subject: [PATCH v2 02/12] dts: mvebu: Update A8K AP806/AP807 SDHCI settings Date: Wed, 10 Feb 2021 16:09:39 +0200 Message-ID: <20210210140949.32515-3-kostap@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210210140949.32515-1-kostap@marvell.com> References: <20210210140949.32515-1-kostap@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-10_05:2021-02-10,2021-02-10 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Porotchkin Select the AP SDHCI PHY slow mode for AP806 die only (move it from armada-ap80x.dtsi to armada-ap806.dtsi). This will allow running AP807 based devices at HS400 speed. Remove Ap SDHCI slow mode property from MacchiatoBin board DTS since it is already selected on the SoC level. Signed-off-by: Konstantin Porotchkin --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 5 ----- arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 12 ++++++++++++ arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 1 - 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi index 73733b4126e2..69653de998e2 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -109,11 +109,6 @@ &ap_sdhci0 { bus-width = <8>; - /* - * Not stable in HS modes - phy needs "more calibration", so add - * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes. - */ - marvell,xenon-phy-slow-mode; no-1-8-v; no-sd; no-sdio; diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi index 866628679ac7..828cd539173b 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi @@ -28,3 +28,15 @@ reg = <0x278 0xa30>; }; }; + +&ap_sdhci0 { + /* + * SoC based on AP806 revision A0, A1 and A2 should use slow mode + * settings for Ap SDHCI due to HW Erratum HWE-7296210 + * AP806 revesion B0 and later has this erratum fixed and the slow + * mode could be removed in board DTS: + * /delete-property/marvell,xenon-phy-slow-mode; + * Starting from B0 revision, the AP SDHCI can run with HS400 timing. + */ + marvell,xenon-phy-slow-mode; +}; diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi index 12e477f1aeb9..edd6131a0587 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi @@ -257,7 +257,6 @@ clock-names = "core"; clocks = <&ap_clk 4>; dma-coherent; - marvell,xenon-phy-slow-mode; status = "disabled"; }; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7887BC433E0 for ; Wed, 10 Feb 2021 14:11:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CD0164E6F for ; Wed, 10 Feb 2021 14:11:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CD0164E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jDxZKvGOuQ9U9OOVqUiEuJ2N/TNYRMkwKHoGhk8TaLY=; b=Ll+mQ6bI2pAYzFLRgQlXGQftn yeE+feILPCC8vSnznJ5iOO7RQtYsjhfyGql1abbsTUQeYy0sTZS8X40yBtZfDCOYFL+GHrARAdw6Y Fg2CFkpQ8FASkycB0WUyMYNuYCpB9YQYGfVao0KMRtw//NmuFjhRQZxATArreBsNbShJNEy5jfxXV IRn3aQAzoibXbLbBINC0SBIie+MOPFtwvNrLu2bD3EkFuifvhkT/6P+v1OVhcxpU3YUBKn+W5Jqbd D0ZiPGXkFUweoMhHIOjNE+WoleRueZwBH9Q4+OYE0La3VcbeW9M76lODwhz1bry0Nf3j77vjBdBYL Cz7NRd3bQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qC9-0006TH-2q; Wed, 10 Feb 2021 14:10:17 +0000 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qC2-0006S3-8w for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 14:10:11 +0000 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11AE0OIr011326; Wed, 10 Feb 2021 06:10:04 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=PWnnzGuk/ieIQSw2dLZPjY03chHqOhLoJqWbCzDUdbY=; b=cHHRItzhU3ry59G5WG8+/Q42T/304ozlhLOoCwFye3P+Okorn6VIuF4xAWRE4N4A5Q++ liLFynWyAxJq+flG/sKFvSgQSzTAoQl9w4TvEFyPqBiwjKcLsp+FKDm5A7Jz3Q4uxrA0 JavTjXTddEJC2oviktAOJPsdNr1GP23HO1J4IRBGUcarZTn7Nm/EMb0NEzaPSedD1GJy A2SX8DGD/yHZLQnCF6jkN+YWYDA4CtPYnw+WUstlwRWNak4eP+8vxPOCnOcTK2pfCA/j UBC+z8lhZeFCtzZvhOVYoyLX/9KmUPHtvSUU9SyIdP5Z8zU82HiLk2jAl73oiHiydg9K EQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com with ESMTP id 36hugqbryv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 10 Feb 2021 06:10:04 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Feb 2021 06:10:02 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 10 Feb 2021 06:10:02 -0800 Received: from octopus.marvell.com (octopus.marvell.com [10.5.24.3]) by maili.marvell.com (Postfix) with ESMTP id 8DC043F703F; Wed, 10 Feb 2021 06:09:59 -0800 (PST) From: To: , , Subject: [PATCH v2 02/12] dts: mvebu: Update A8K AP806/AP807 SDHCI settings Date: Wed, 10 Feb 2021 16:09:39 +0200 Message-ID: <20210210140949.32515-3-kostap@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210210140949.32515-1-kostap@marvell.com> References: <20210210140949.32515-1-kostap@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.737 definitions=2021-02-10_05:2021-02-10, 2021-02-10 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_091010_418170_5ACAB833 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jaz@semihalf.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, nadavh@marvell.com, robh+dt@kernel.org, Konstantin Porotchkin , stefanc@marvell.com, mw@semihalf.com, bpeled@marvell.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Konstantin Porotchkin Select the AP SDHCI PHY slow mode for AP806 die only (move it from armada-ap80x.dtsi to armada-ap806.dtsi). This will allow running AP807 based devices at HS400 speed. Remove Ap SDHCI slow mode property from MacchiatoBin board DTS since it is already selected on the SoC level. Signed-off-by: Konstantin Porotchkin --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 5 ----- arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 12 ++++++++++++ arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 1 - 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi index 73733b4126e2..69653de998e2 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -109,11 +109,6 @@ &ap_sdhci0 { bus-width = <8>; - /* - * Not stable in HS modes - phy needs "more calibration", so add - * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes. - */ - marvell,xenon-phy-slow-mode; no-1-8-v; no-sd; no-sdio; diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi index 866628679ac7..828cd539173b 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi @@ -28,3 +28,15 @@ reg = <0x278 0xa30>; }; }; + +&ap_sdhci0 { + /* + * SoC based on AP806 revision A0, A1 and A2 should use slow mode + * settings for Ap SDHCI due to HW Erratum HWE-7296210 + * AP806 revesion B0 and later has this erratum fixed and the slow + * mode could be removed in board DTS: + * /delete-property/marvell,xenon-phy-slow-mode; + * Starting from B0 revision, the AP SDHCI can run with HS400 timing. + */ + marvell,xenon-phy-slow-mode; +}; diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi index 12e477f1aeb9..edd6131a0587 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi @@ -257,7 +257,6 @@ clock-names = "core"; clocks = <&ap_clk 4>; dma-coherent; - marvell,xenon-phy-slow-mode; status = "disabled"; }; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel