From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE9DC433DB for ; Wed, 10 Feb 2021 14:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26D1F64E7A for ; Wed, 10 Feb 2021 14:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhBJOST (ORCPT ); Wed, 10 Feb 2021 09:18:19 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58681 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhBJOSQ (ORCPT ); Wed, 10 Feb 2021 09:18:16 -0500 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 399F660019; Wed, 10 Feb 2021 14:17:29 +0000 (UTC) Date: Wed, 10 Feb 2021 15:17:28 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Lars Povlsen , Linus Walleij , Steen Hegelund , Microchip Linux Driver Support , "open list:GPIO SUBSYSTEM" , Linux ARM , "open list:BROADCOM NVRAM DRIVER" , Linux Kernel Mailing List Subject: Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII Message-ID: <20210210141728.GO351084@piout.net> References: <20210210132751.1422386-1-geert+renesas@glider.be> <87mtwcujd0.fsf@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen wrote: > > Geert Uytterhoeven writes: > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > > driver when configuring a kernel without support for these SoCs. > > > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > drivers/pinctrl/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > > --- a/drivers/pinctrl/Kconfig > > > +++ b/drivers/pinctrl/Kconfig > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > > > config PINCTRL_MICROCHIP_SGPIO > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > > - depends on OF > > > - depends on HAS_IOMEM > > > + depends on OF && HAS_IOMEM > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > > select GPIOLIB > > > select GPIOLIB_IRQCHIP > > > select GENERIC_PINCONF > > > > Thank you for your patch. Unfortunately, it makes it impossible to use > > the driver across PCIe - which is a specifically desired configuration. > > > > Could you add CONFIG_PCI to the || chain? > > Sure. > > Is PCIe the only other transport over which the register can be accessed? > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) so this is also available over SPI. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A859C433DB for ; Wed, 10 Feb 2021 14:18:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 246BF64D9E for ; Wed, 10 Feb 2021 14:18:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 246BF64D9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JD0gP13X5H6MzAYAA18c9wAuGVWXQMsOluZJFKCvBBU=; b=aepfQ+c0BMTBVm3AeJbSeAlbU cmsiczrk1dcMqYG1FT3Y3z85Vh5x/cPfleiYLJWYW2aMEyWtu0KFOHIIDxV9b1VFDNQpnNPTvWOxi Rgr3LPGV+EJjir8jwML5DJpgPrAXz5Aik3lUUvY6glvDH3DjPQ8drf7fhmKbhwq96mE0eGtt4PA1K mV5lS4HHcRbSXjpkurMlQ7ePWi1ivn3UCYuzpXnQiyRgjfQVpv7RqJmazsMPupVDmr61fZvDs5Poi NSk+F5HlcFFloFf1Xozp1zpWUpECRXMIMn7QsLz4Qsg57B9PydT/YK04VYDKNc8HcDk0XpxvXQleX fXYOMzkRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qJJ-0001ix-Aq; Wed, 10 Feb 2021 14:17:41 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qJC-0001fN-IX for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 14:17:36 +0000 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 399F660019; Wed, 10 Feb 2021 14:17:29 +0000 (UTC) Date: Wed, 10 Feb 2021 15:17:28 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Subject: Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII Message-ID: <20210210141728.GO351084@piout.net> References: <20210210132751.1422386-1-geert+renesas@glider.be> <87mtwcujd0.fsf@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_091734_798072_018C3FA0 X-CRM114-Status: GOOD ( 26.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , Linus Walleij , "open list:BROADCOM NVRAM DRIVER" , Microchip Linux Driver Support , "open list:GPIO SUBSYSTEM" , Lars Povlsen , Steen Hegelund , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen wrote: > > Geert Uytterhoeven writes: > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > > driver when configuring a kernel without support for these SoCs. > > > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > drivers/pinctrl/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > > --- a/drivers/pinctrl/Kconfig > > > +++ b/drivers/pinctrl/Kconfig > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > > > config PINCTRL_MICROCHIP_SGPIO > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > > - depends on OF > > > - depends on HAS_IOMEM > > > + depends on OF && HAS_IOMEM > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > > select GPIOLIB > > > select GPIOLIB_IRQCHIP > > > select GENERIC_PINCONF > > > > Thank you for your patch. Unfortunately, it makes it impossible to use > > the driver across PCIe - which is a specifically desired configuration. > > > > Could you add CONFIG_PCI to the || chain? > > Sure. > > Is PCIe the only other transport over which the register can be accessed? > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) so this is also available over SPI. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel