From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB3BDC433DB for ; Wed, 10 Feb 2021 14:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A225664D87 for ; Wed, 10 Feb 2021 14:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbhBJOlj (ORCPT ); Wed, 10 Feb 2021 09:41:39 -0500 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:41419 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbhBJOlg (ORCPT ); Wed, 10 Feb 2021 09:41:36 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 635665802C7; Wed, 10 Feb 2021 09:40:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 10 Feb 2021 09:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=P2ztjygVeFiKQ5BAJ/ZTctF2Gnz 2GbSXv/Mu4NHHWRY=; b=qEwIJymZrzmFRVK+c/s0yGIOxBOAX8YD/jfThN686uK rhdyNG0FvMMULp9fIB1bahDTLdRpb4K5/mf89fufSPe3dX2YS8W2jBr842ftq4hR oCprmSXWC6hgv7H5q8GIEe/yjq6+2/9lJ9ezHYFYV3MJAz9SwnmrARQLKIaieD7m obeqB6AuVmoB56NAKXfGfnOKeaHDDSjHj+ZhvKYhWOnOR/9NIU0zwvYbo2X1dyj0 1HTGLVH1Aab+sdlQBlOF2NgsjGFyiu5NT9fJ57LCvb1npFT439wa7Dz0Ijb/Y9F8 FNclmmBP4rcWT8KnfVpMmzxFzhi1JJrzN30CdtMpLqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=P2ztjy gVeFiKQ5BAJ/ZTctF2Gnz2GbSXv/Mu4NHHWRY=; b=okRq03+9FqXZb+M4do/47P dyKgB9g+Zqzf9lDjb+Nq/Zr1gRQUUuWy0pgjYxkxN4yaPhlmBx7fQn8oJlk5f/WK lgHVyHxclHwNnkug0BEdDSkHETiO7vRcLmY3qN/nUhGmhtv4+RZJ7VfQpm+6ylgc jZwOv92bQYpoY3IrUfrcg0Znlv06pcVZ00ypvQlRgV8Sv6worDIIt38hIMxYxa0g xecMWzlDeI3uwgsFrl/W63A+1aPewE5JRWzgSpuKQqk4z5WV3Yn3khsYn2oIvqqb c10QlxE1g3Ntr36C2+M6ercVZn/q2n+wJFCGf3H7baVdrlLqUPcXUIFP28V0YNxw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheejgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C8D08240062; Wed, 10 Feb 2021 09:40:45 -0500 (EST) Date: Wed, 10 Feb 2021 15:40:43 +0100 From: Maxime Ripard To: Dave Stevenson , Thomas Gleixner , Marc Zyngier Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Hans Verkuil , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Mauro Carvalho Chehab , Linux Media Mailing List , Florian Fainelli , Nicolas Saenz Julienne Subject: Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller Message-ID: <20210210144043.s4plyc7ekwnnu7k4@gilmour> References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-15-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="56a5x6qoevnvgc6k" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --56a5x6qoevnvgc6k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On Tue, Feb 09, 2021 at 09:49:05AM +0000, Dave Stevenson wrote: > On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > > > The BSC controllers used for the HDMI DDC have an interrupt controller > > shared between both instances. Let's add it to avoid polling. >=20 > This seems to have unintended side effects. > GIC interrupt 117 is shared between the standard I2C controllers > (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. >=20 > Whilst i2c-bcm2835 requests the interrupt with IRQF_SHARED, that > doesn't appear to be an option for l2-intc registering as an interrupt > controller. i2c-bcm2835 therefore loses out and fails to register for > the interrupt. >=20 > Is there an equivalent flag that an interrupt controller can add to > say that the parent interrupt is shared? Is that even supported? Indeed, it looks like setting an equivalent to IRQF_SHARED would be the solution, but I couldn't find anything that would allow us to in the irqchip code. Marc, Thomas, is it something that is allowed? Thanks! Maxime --56a5x6qoevnvgc6k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYCPwawAKCRDj7w1vZxhR xfz5AP9mEfV4z4O2puDJLRbQ7vq8rgfauEvYgK4B2X6lJbqcTQD/faR5cryNEgGR UJkYFI2Z8uuR9+us+5z3CVcV6wOolQU= =tX0n -----END PGP SIGNATURE----- --56a5x6qoevnvgc6k-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93055C433DB for ; Wed, 10 Feb 2021 14:42:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5566964D87 for ; Wed, 10 Feb 2021 14:42:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5566964D87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=puLWhW/+YcPbb0XZdPA4vgUB+V8sU+ScRmR91UArM9s=; b=Yrsw0RFzJ4L5Zm3JqVWVBm3x7 QQS65my9cKvMxFeBXiTraeOmjJL6AY51aiFVZUlLycj241V0tPSOyGuTaSjBiKCmVDC4UA7hQ4rQJ FPVny7ZCM+/FQU4RzacR9qLBwVifakJdR5c0YSzcYlUtAQG2tgoEUa9fPOZ7/dac0pneh7GdvsHSn k4pU5KASvi8oV2IKoUCvw5cOT6T2TURLA3DmbBqyl76WTAnr4bxWMCgtGdNZmzoqNRm9CxOdJdHRs aOaPh8SC3ZsMWJP0gfrDEcg8kIZrv7feI2f+Qm6z2dpSWwW4tnXUFZvdIE0LHYRfwToYQYu7RbU4l sYE3EiXAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qfp-0004rZ-5I; Wed, 10 Feb 2021 14:40:57 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qfm-0004q4-1g; Wed, 10 Feb 2021 14:40:55 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 635665802C7; Wed, 10 Feb 2021 09:40:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 10 Feb 2021 09:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=P2ztjygVeFiKQ5BAJ/ZTctF2Gnz 2GbSXv/Mu4NHHWRY=; b=qEwIJymZrzmFRVK+c/s0yGIOxBOAX8YD/jfThN686uK rhdyNG0FvMMULp9fIB1bahDTLdRpb4K5/mf89fufSPe3dX2YS8W2jBr842ftq4hR oCprmSXWC6hgv7H5q8GIEe/yjq6+2/9lJ9ezHYFYV3MJAz9SwnmrARQLKIaieD7m obeqB6AuVmoB56NAKXfGfnOKeaHDDSjHj+ZhvKYhWOnOR/9NIU0zwvYbo2X1dyj0 1HTGLVH1Aab+sdlQBlOF2NgsjGFyiu5NT9fJ57LCvb1npFT439wa7Dz0Ijb/Y9F8 FNclmmBP4rcWT8KnfVpMmzxFzhi1JJrzN30CdtMpLqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=P2ztjy gVeFiKQ5BAJ/ZTctF2Gnz2GbSXv/Mu4NHHWRY=; b=okRq03+9FqXZb+M4do/47P dyKgB9g+Zqzf9lDjb+Nq/Zr1gRQUUuWy0pgjYxkxN4yaPhlmBx7fQn8oJlk5f/WK lgHVyHxclHwNnkug0BEdDSkHETiO7vRcLmY3qN/nUhGmhtv4+RZJ7VfQpm+6ylgc jZwOv92bQYpoY3IrUfrcg0Znlv06pcVZ00ypvQlRgV8Sv6worDIIt38hIMxYxa0g xecMWzlDeI3uwgsFrl/W63A+1aPewE5JRWzgSpuKQqk4z5WV3Yn3khsYn2oIvqqb c10QlxE1g3Ntr36C2+M6ercVZn/q2n+wJFCGf3H7baVdrlLqUPcXUIFP28V0YNxw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheejgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C8D08240062; Wed, 10 Feb 2021 09:40:45 -0500 (EST) Date: Wed, 10 Feb 2021 15:40:43 +0100 From: Maxime Ripard To: Dave Stevenson , Thomas Gleixner , Marc Zyngier Subject: Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller Message-ID: <20210210144043.s4plyc7ekwnnu7k4@gilmour> References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-15-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_094054_259726_1C8AE0AF X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , David Airlie , Nicolas Saenz Julienne , Maarten Lankhorst , LKML , DRI Development , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Type: multipart/mixed; boundary="===============2924393885505439624==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2924393885505439624== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="56a5x6qoevnvgc6k" Content-Disposition: inline --56a5x6qoevnvgc6k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On Tue, Feb 09, 2021 at 09:49:05AM +0000, Dave Stevenson wrote: > On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > > > The BSC controllers used for the HDMI DDC have an interrupt controller > > shared between both instances. Let's add it to avoid polling. >=20 > This seems to have unintended side effects. > GIC interrupt 117 is shared between the standard I2C controllers > (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. >=20 > Whilst i2c-bcm2835 requests the interrupt with IRQF_SHARED, that > doesn't appear to be an option for l2-intc registering as an interrupt > controller. i2c-bcm2835 therefore loses out and fails to register for > the interrupt. >=20 > Is there an equivalent flag that an interrupt controller can add to > say that the parent interrupt is shared? Is that even supported? Indeed, it looks like setting an equivalent to IRQF_SHARED would be the solution, but I couldn't find anything that would allow us to in the irqchip code. Marc, Thomas, is it something that is allowed? Thanks! Maxime --56a5x6qoevnvgc6k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYCPwawAKCRDj7w1vZxhR xfz5AP9mEfV4z4O2puDJLRbQ7vq8rgfauEvYgK4B2X6lJbqcTQD/faR5cryNEgGR UJkYFI2Z8uuR9+us+5z3CVcV6wOolQU= =tX0n -----END PGP SIGNATURE----- --56a5x6qoevnvgc6k-- --===============2924393885505439624== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2924393885505439624==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80AD5C433E0 for ; Wed, 10 Feb 2021 14:40:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 320A864E42 for ; Wed, 10 Feb 2021 14:40:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320A864E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80E656EC92; Wed, 10 Feb 2021 14:40:53 +0000 (UTC) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by gabe.freedesktop.org (Postfix) with ESMTPS id D21946EC92 for ; Wed, 10 Feb 2021 14:40:51 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 635665802C7; Wed, 10 Feb 2021 09:40:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 10 Feb 2021 09:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=P2ztjygVeFiKQ5BAJ/ZTctF2Gnz 2GbSXv/Mu4NHHWRY=; b=qEwIJymZrzmFRVK+c/s0yGIOxBOAX8YD/jfThN686uK rhdyNG0FvMMULp9fIB1bahDTLdRpb4K5/mf89fufSPe3dX2YS8W2jBr842ftq4hR oCprmSXWC6hgv7H5q8GIEe/yjq6+2/9lJ9ezHYFYV3MJAz9SwnmrARQLKIaieD7m obeqB6AuVmoB56NAKXfGfnOKeaHDDSjHj+ZhvKYhWOnOR/9NIU0zwvYbo2X1dyj0 1HTGLVH1Aab+sdlQBlOF2NgsjGFyiu5NT9fJ57LCvb1npFT439wa7Dz0Ijb/Y9F8 FNclmmBP4rcWT8KnfVpMmzxFzhi1JJrzN30CdtMpLqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=P2ztjy gVeFiKQ5BAJ/ZTctF2Gnz2GbSXv/Mu4NHHWRY=; b=okRq03+9FqXZb+M4do/47P dyKgB9g+Zqzf9lDjb+Nq/Zr1gRQUUuWy0pgjYxkxN4yaPhlmBx7fQn8oJlk5f/WK lgHVyHxclHwNnkug0BEdDSkHETiO7vRcLmY3qN/nUhGmhtv4+RZJ7VfQpm+6ylgc jZwOv92bQYpoY3IrUfrcg0Znlv06pcVZ00ypvQlRgV8Sv6worDIIt38hIMxYxa0g xecMWzlDeI3uwgsFrl/W63A+1aPewE5JRWzgSpuKQqk4z5WV3Yn3khsYn2oIvqqb c10QlxE1g3Ntr36C2+M6ercVZn/q2n+wJFCGf3H7baVdrlLqUPcXUIFP28V0YNxw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheejgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C8D08240062; Wed, 10 Feb 2021 09:40:45 -0500 (EST) Date: Wed, 10 Feb 2021 15:40:43 +0100 From: Maxime Ripard To: Dave Stevenson , Thomas Gleixner , Marc Zyngier Subject: Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller Message-ID: <20210210144043.s4plyc7ekwnnu7k4@gilmour> References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-15-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , David Airlie , Nicolas Saenz Julienne , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Type: multipart/mixed; boundary="===============0668395412==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0668395412== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="56a5x6qoevnvgc6k" Content-Disposition: inline --56a5x6qoevnvgc6k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On Tue, Feb 09, 2021 at 09:49:05AM +0000, Dave Stevenson wrote: > On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > > > The BSC controllers used for the HDMI DDC have an interrupt controller > > shared between both instances. Let's add it to avoid polling. >=20 > This seems to have unintended side effects. > GIC interrupt 117 is shared between the standard I2C controllers > (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. >=20 > Whilst i2c-bcm2835 requests the interrupt with IRQF_SHARED, that > doesn't appear to be an option for l2-intc registering as an interrupt > controller. i2c-bcm2835 therefore loses out and fails to register for > the interrupt. >=20 > Is there an equivalent flag that an interrupt controller can add to > say that the parent interrupt is shared? Is that even supported? Indeed, it looks like setting an equivalent to IRQF_SHARED would be the solution, but I couldn't find anything that would allow us to in the irqchip code. Marc, Thomas, is it something that is allowed? Thanks! Maxime --56a5x6qoevnvgc6k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYCPwawAKCRDj7w1vZxhR xfz5AP9mEfV4z4O2puDJLRbQ7vq8rgfauEvYgK4B2X6lJbqcTQD/faR5cryNEgGR UJkYFI2Z8uuR9+us+5z3CVcV6wOolQU= =tX0n -----END PGP SIGNATURE----- --56a5x6qoevnvgc6k-- --===============0668395412== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0668395412==--