CC: kbuild-all(a)lists.01.org In-Reply-To: <1612906019-31724-3-git-send-email-bupadhaya@marvell.com> References: <1612906019-31724-3-git-send-email-bupadhaya@marvell.com> TO: Bhaskar Upadhaya TO: netdev(a)vger.kernel.org TO: kuba(a)kernel.org TO: aelior(a)marvell.com TO: irusskikh(a)marvell.com CC: davem(a)davemloft.net CC: bupadhaya(a)marvell.com Hi Bhaskar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Bhaskar-Upadhaya/qede-add-netpoll-and-per-queue-coalesce-support/20210210-080747 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56 :::::: branch date: 9 hours ago :::::: commit date: 9 hours ago config: i386-randconfig-m021-20210209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/qlogic/qede/qede_ethtool.c:2188 qede_get_per_coalesce() warn: assigning (-22) to unsigned variable 'rc' Old smatch warnings: drivers/net/ethernet/qlogic/qede/qede_ethtool.c:2193 qede_get_per_coalesce() warn: assigning (-22) to unsigned variable 'rc' vim +/rc +2188 drivers/net/ethernet/qlogic/qede/qede_ethtool.c 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2170 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2171 static int qede_get_per_coalesce(struct net_device *dev, 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2172 u32 queue, 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2173 struct ethtool_coalesce *coal) 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2174 { 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2175 void *rx_handle = NULL, *tx_handle = NULL; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2176 struct qede_dev *edev = netdev_priv(dev); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2177 u16 rx_coal, tx_coal, rc = 0; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2178 struct qede_fastpath *fp; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2179 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2180 rx_coal = QED_DEFAULT_RX_USECS; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2181 tx_coal = QED_DEFAULT_TX_USECS; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2182 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2183 memset(coal, 0, sizeof(struct ethtool_coalesce)); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2184 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2185 __qede_lock(edev); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2186 if (queue >= edev->num_queues) { 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2187 DP_INFO(edev, "Invalid queue\n"); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 @2188 rc = -EINVAL; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2189 goto out; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2190 } 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2191 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2192 if (edev->state != QEDE_STATE_OPEN) { 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2193 rc = -EINVAL; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2194 goto out; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2195 } 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2196 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2197 fp = &edev->fp_array[queue]; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2198 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2199 if (fp->type & QEDE_FASTPATH_RX) 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2200 rx_handle = fp->rxq->handle; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2201 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2202 rc = edev->ops->get_coalesce(edev->cdev, &rx_coal, 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2203 rx_handle); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2204 if (rc) { 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2205 DP_INFO(edev, "Read Rx coalesce error\n"); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2206 goto out; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2207 } 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2208 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2209 fp = &edev->fp_array[queue]; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2210 if (fp->type & QEDE_FASTPATH_TX) 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2211 tx_handle = fp->txq->handle; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2212 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2213 rc = edev->ops->get_coalesce(edev->cdev, &tx_coal, 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2214 tx_handle); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2215 if (rc) 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2216 DP_INFO(edev, "Read Tx coalesce error\n"); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2217 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2218 out: 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2219 __qede_unlock(edev); 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2220 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2221 coal->rx_coalesce_usecs = rx_coal; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2222 coal->tx_coalesce_usecs = tx_coal; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2223 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2224 return rc; 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2225 } 75a56157c75052 Bhaskar Upadhaya 2021-02-09 2226 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org