From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [RFC PATCH v2 2/4] iotests: Update 245 to support replacing files with x-blockdev-reopen
Date: Wed, 10 Feb 2021 18:17:24 +0100 [thread overview]
Message-ID: <20210210171724.GI5144@merkur.fritz.box> (raw)
In-Reply-To: <74cbe313dce107f6100751f1c42296769f05a7ef.1612809837.git.berto@igalia.com>
Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> + def test_insert_throttle_filter(self):
> + hd0_opts = hd_opts(0)
> + result = self.vm.qmp('blockdev-add', conv_keys = False, **hd0_opts)
> + self.assert_qmp(result, 'return', {})
> +
> + opts = { 'qom-type': 'throttle-group', 'id': 'group0',
> + 'props': { 'limits': { 'iops-total': 1000 } } }
Please don't add new users of 'props', it's deprecated. Instead, specify
'limits' on the top level.
Kevin
next prev parent reply other threads:[~2021-02-10 17:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 18:44 [RFC PATCH v2 0/4] Allow changing bs->file on reopen Alberto Garcia
2021-02-08 18:44 ` [RFC PATCH v2 1/4] block: " Alberto Garcia
2021-02-09 7:37 ` Vladimir Sementsov-Ogievskiy
2021-02-10 16:52 ` Kevin Wolf
2021-02-16 12:06 ` Alberto Garcia
2021-02-08 18:44 ` [RFC PATCH v2 2/4] iotests: Update 245 to support replacing files with x-blockdev-reopen Alberto Garcia
2021-02-10 17:17 ` Kevin Wolf [this message]
2021-02-08 18:44 ` [RFC PATCH v2 3/4] block: Support multiple reopening " Alberto Garcia
2021-02-09 8:03 ` Vladimir Sementsov-Ogievskiy
2021-02-16 16:33 ` Alberto Garcia
2021-02-24 12:33 ` Kevin Wolf
2021-02-25 17:02 ` Vladimir Sementsov-Ogievskiy
2021-03-01 11:07 ` Kevin Wolf
2021-03-01 11:57 ` Vladimir Sementsov-Ogievskiy
2021-03-01 12:21 ` Peter Krempa
2021-02-26 11:51 ` Alberto Garcia
2021-02-08 18:44 ` [RFC PATCH v2 4/4] iotests: Test reopening multiple devices at the same time Alberto Garcia
2021-02-09 7:15 ` [RFC PATCH v2 0/4] Allow changing bs->file on reopen Vladimir Sementsov-Ogievskiy
2021-02-10 17:26 ` Kevin Wolf
2021-02-12 14:41 ` Peter Krempa
2021-02-16 16:36 ` Alberto Garcia
2021-02-16 16:48 ` Kevin Wolf
2021-02-16 17:25 ` Alberto Garcia
2021-02-16 17:51 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210171724.GI5144@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.