From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Icenowy Zheng <icenowy@aosc.io>,
Chengguang Xu <cgxu519@mykernel.net>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 0/5] Tests for overlayfs immutable/append-only files
Date: Wed, 10 Feb 2021 21:03:29 +0200 [thread overview]
Message-ID: <20210210190334.1212210-1-amir73il@gmail.com> (raw)
Eryu,
Overlayfs never had full support for immutable/append-only files.
Whatever works is covered by generic/079 and overlay/030 tests.
Both tests cover only upper files and directories.
generic/079 is notrun on kernel < 5.10 and passes on >= 5.10.
This series improves the t_immutable test program and adds two new
tests.
overlay/075 tests immutable/append-only lower files and directories -
the test fails on upstream kernel. Fixing this requires some VFS API
changes that Miklos has proposed [1].
overlay/076 is a "dangerous" test that triggers a deadlock.
The deadlock was fixed in master and in stable kernel v5.10.15.
Thanks,
Amir.
Changes since v1:
- Split the dangerous test
- Document fix commit
- Fix Eryu's minor review comments on t_immutable
[1] https://lore.kernel.org/linux-fsdevel/20210203124112.1182614-1-mszeredi@redhat.com/
Amir Goldstein (5):
overlay/030: Update comment w.r.t upstream kernel
src/t_immutable: factor out some helpers
src/t_immutable: Allow setting flags on existing files
overlay: Test lost immutable/append-only flags on copy-up
overlay: Regression test for deadlock on directory ioctl
src/t_immutable.c | 241 +++++++++++++++++++++---------------------
tests/overlay/030 | 7 +-
tests/overlay/075 | 92 ++++++++++++++++
tests/overlay/075.out | 11 ++
tests/overlay/076 | 66 ++++++++++++
tests/overlay/076.out | 2 +
tests/overlay/group | 2 +
7 files changed, 301 insertions(+), 120 deletions(-)
create mode 100755 tests/overlay/075
create mode 100644 tests/overlay/075.out
create mode 100644 tests/overlay/076
create mode 100644 tests/overlay/076.out
--
2.25.1
next reply other threads:[~2021-02-10 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:03 Amir Goldstein [this message]
2021-02-10 19:03 ` [PATCH v2 1/5] overlay/030: Update comment w.r.t upstream kernel Amir Goldstein
2021-02-10 19:03 ` [PATCH v2 2/5] src/t_immutable: factor out some helpers Amir Goldstein
2021-02-10 19:03 ` [PATCH v2 3/5] src/t_immutable: Allow setting flags on existing files Amir Goldstein
2021-02-10 19:03 ` [PATCH v2 4/5] overlay: Test lost immutable/append-only flags on copy-up Amir Goldstein
2021-02-10 19:03 ` [PATCH v2 5/5] overlay: Regression test for deadlock on directory ioctl Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210190334.1212210-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=cgxu519@mykernel.net \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=icenowy@aosc.io \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.