From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77621C433E0 for ; Wed, 10 Feb 2021 20:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 240D164EDC for ; Wed, 10 Feb 2021 20:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232556AbhBJUsI (ORCPT ); Wed, 10 Feb 2021 15:48:08 -0500 Received: from mga05.intel.com ([192.55.52.43]:55007 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232045AbhBJUsH (ORCPT ); Wed, 10 Feb 2021 15:48:07 -0500 IronPort-SDR: LUQnrxFF90Ccit3/4s8Yne5ZJZxS7MVzoo5rxwSEBr+9VurlqCc0/9qGs0b+RI9QCCLAwpU0XE JCKSmRXbwgmw== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="266989951" X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="266989951" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 12:46:21 -0800 IronPort-SDR: lfrxqcEe4qvK2F9xrVIUg5SgwA6wit7M6Xgz98/oT3Fah64JTxbj6tKKPv0iOV1pfP/FvwJha4 JjfuD5G3DL9w== X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="578541017" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 12:46:17 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id B021E2011B; Wed, 10 Feb 2021 22:46:15 +0200 (EET) Date: Wed, 10 Feb 2021 22:46:15 +0200 From: Sakari Ailus To: Wolfram Sang , linux-i2c@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , rajmohan.mani@intel.com, Tomasz Figa , Bartosz Golaszewski , Bingbu Cao , Chiranjeevi Rapolu , Hyungwoo Yang , linux-media@vger.kernel.org Subject: Re: [PATCH v10 2/7] i2c: Allow an ACPI driver to manage the device's power state during probe Message-ID: <20210210204615.GC3@paasikivi.fi.intel.com> References: <20210205132505.20173-1-sakari.ailus@linux.intel.com> <20210205132505.20173-3-sakari.ailus@linux.intel.com> <20210209210410.GA2380@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209210410.GA2380@kunai> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Wolfram, On Tue, Feb 09, 2021 at 10:04:10PM +0100, Wolfram Sang wrote: > > > + * @I2C_DRV_FL_ALLOW_LOW_POWER_PROBE: Let the ACPI driver manage the device's > > + * power state during probe and remove > > Well, for the functional change, I am happy if the ACPI guys are happy. > The only minor nit for me would be removing the "_FL" snipplet from the > name of the define because I think it is clear enough that this is a > flag. If you need to resend anyhow, maybe it is worth a thought. It is I'll remove _FL for v11. > not a big issue, so anyway: > > Acked-by: Wolfram Sang Thank you! > > because I assume this will go in via the ACPI tree? I think so, yes, if no-one has objections. Most of the changes are for ACPI framework and docs. -- Kind regards, Sakari Ailus