From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FFAEC433DB for ; Wed, 10 Feb 2021 22:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EAD864EBB for ; Wed, 10 Feb 2021 22:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbhBJWpA (ORCPT ); Wed, 10 Feb 2021 17:45:00 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:39296 "EHLO mail-oi1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbhBJWo5 (ORCPT ); Wed, 10 Feb 2021 17:44:57 -0500 Received: by mail-oi1-f176.google.com with SMTP id l19so3966092oih.6; Wed, 10 Feb 2021 14:44:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3M0msBaL9p/7nJ6GlqMOEs3GDwMywxHD5jz1IJHrbdE=; b=RxKbdr1Oanjt+axrW26lPwXeDsJhnCnnSJ7qzQL0bUHiIf2Q0mCH8vKSutudhYUFIP i81GobnoIGNv/R73y2uB/sN0cEq84BaChnLtpZKClevkcLSKnACkWUGoWQoRl+j+WJhT LrPIdSy2uJXEvk2G1ZDB3e1qUhuPXy4L03u+kMvu4vqBFwbzC/+HM+zcbXdu8AVowqMP DkvTm9zMQj9x10PRunB4+NuVix8zJVKXpOI5XNNm+8sZL+PVHHmdDpw8ULQjHp6amJMI kSWXj9nOFfixIFfC0UNlPeGSM4BhLJvT/KYaC+AnpodY718WMykQseNn4rr+kcwRufI7 kX0w== X-Gm-Message-State: AOAM532Q0eCzBdrZXb/SvoJ8lVTFj92viSUb/upyszZmZIGab9WVUX3e zq2mWR5wkszULqTKKmSRqQ== X-Google-Smtp-Source: ABdhPJxy+3o6WWoRuZXvNqoGfKln05oXvoDI2zQTSg/JoBEmpJWdCKyHSLC63mr2/0y9Tg4Ezi62HQ== X-Received: by 2002:aca:4d55:: with SMTP id a82mr883173oib.23.1612997056503; Wed, 10 Feb 2021 14:44:16 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i20sm644411otl.78.2021.02.10.14.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 14:44:15 -0800 (PST) Received: (nullmailer pid 2949448 invoked by uid 1000); Wed, 10 Feb 2021 22:44:13 -0000 Date: Wed, 10 Feb 2021 16:44:13 -0600 From: Rob Herring To: Nicolas Saenz Julienne Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com, wahrenst@gmx.net, linux-arm-kernel@lists.infradead.org, mripard@kernel.org, eric@anholt.net, devicetree@vger.kernel.org Subject: Re: [RFC/PATCH v2 02/16] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names Message-ID: <20210210224413.GA2919056@robh.at.kernel.org> References: <20210209125912.3398-1-nsaenzjulienne@suse.de> <20210209125912.3398-3-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209125912.3398-3-nsaenzjulienne@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 01:58:58PM +0100, Nicolas Saenz Julienne wrote: > Anticipating the introduction of BCM2711, of which we'll need to support > its new Argon ASB, introduce reg-names into bcm2835-pm's binding. This > will help to have a consistent mapping between resources and their > meaning. > > Signed-off-by: Nicolas Saenz Julienne > --- > .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > index 8bc65e5f62a7..1dbe3657c690 100644 > --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > @@ -26,8 +26,13 @@ properties: > reg: > minItems: 1 > maxItems: 2 > - description: Specifies base physical address and size of the two register > - ranges, "PM" and "ASYNC_BRIDGE" in that order. Ah, it's okay this way if you have -names. Or have items to give a bit more detail. > + > + reg-names: > + minItems: 1 > + maxItems: 2 > + items: > + - const: pm > + - const: rpivid_asb Not really clear how this corresponds to 'ASYNC_BRIDGE'. 'asb' I guess? > > "#power-domain-cells": > const: 1 > @@ -54,6 +59,7 @@ properties: > required: > - compatible > - reg > + - reg-names You can't really make added properties required. > - "#power-domain-cells" > - "#reset-cells" > - clocks > @@ -70,6 +76,7 @@ examples: > #reset-cells = <1>; > reg = <0x7e100000 0x114>, > <0x7e00a000 0x24>; > + reg-names = "pm", "rpivid_asb"; > clocks = <&clocks BCM2835_CLOCK_V3D>, > <&clocks BCM2835_CLOCK_PERI_IMAGE>, > <&clocks BCM2835_CLOCK_H264>, > -- > 2.30.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7EAC433DB for ; Wed, 10 Feb 2021 22:45:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA67664E8A for ; Wed, 10 Feb 2021 22:45:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA67664E8A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/xMCXX4MU9AwmGuGjabaN2UfREZl8Tkk97LZD9o6BII=; b=rvk2d6FbLFycYIU6rV78+9lMg MHVwO0rHy8gn3xLQKLcvU7Q90TVXWNgtIVm0chko8G5liHJo1qchXVY4q5jooRRv5kbuIUDjeMNOd o6EMkTpcZCq3a9RUAnydz3zGtelbPao8G+mM0rxywzt58zA/r7TLWG93bhln2bdtkjwycI+UIYwNq cBeevQretiO1afcg5DWt8bfOmzvzj5MgLbVb6pYXj+k6IgBuOCsD/AJuJSOB4mL8ZRHEA177ClV3k fMhr8GDx9fp8Juf96xUNCaEg9mArYipWzqevNX8suLS8WIh3tR/ubs7fl+aoYb6b7rOgoVEfDgivV fIH6chdFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9yDc-000877-Fw; Wed, 10 Feb 2021 22:44:20 +0000 Received: from mail-oi1-f176.google.com ([209.85.167.176]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9yDZ-00086g-J5; Wed, 10 Feb 2021 22:44:18 +0000 Received: by mail-oi1-f176.google.com with SMTP id 18so3964973oiz.7; Wed, 10 Feb 2021 14:44:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3M0msBaL9p/7nJ6GlqMOEs3GDwMywxHD5jz1IJHrbdE=; b=I2Dqw3twSTaAzD5XuBBWfOuNJN+j9UNSvGoYnITlJq0IdcaUpIhVCtGNKplWl0mw/D beeTxK5I923bZC+W+tG8h2gUmCU63d5lNdKrIG35Wl4bIA2m9fZeueh0XtWWR0j3o1No ivpPDUkLudGCtCvArRVREdH3toX8q8XNhB0UbIRUuVXzVt/vWogWcdIVz1LOJNtJbvxg T3pqXnFdKJE3eOChKwpgZVeL+bX6o0ooJRDmN+IeGZxQF7Qp5lGbQu3VAFNkvXLlLFRg G8RcUrmN+XDCMsP5ij4q0b4JaSrtfaUR6Z4cmy97sguK1hZW9Lru4MTLo0U89ppflE7O VdKg== X-Gm-Message-State: AOAM533Vsq6a2Wj4VbmLvbHtG4I1gXJNZ7QdVW1Z2ZNBvhY5Xstat1o+ 4coPrlX/LhGif6WXULubVF5MHrqY9w== X-Google-Smtp-Source: ABdhPJxy+3o6WWoRuZXvNqoGfKln05oXvoDI2zQTSg/JoBEmpJWdCKyHSLC63mr2/0y9Tg4Ezi62HQ== X-Received: by 2002:aca:4d55:: with SMTP id a82mr883173oib.23.1612997056503; Wed, 10 Feb 2021 14:44:16 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i20sm644411otl.78.2021.02.10.14.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 14:44:15 -0800 (PST) Received: (nullmailer pid 2949448 invoked by uid 1000); Wed, 10 Feb 2021 22:44:13 -0000 Date: Wed, 10 Feb 2021 16:44:13 -0600 From: Rob Herring To: Nicolas Saenz Julienne Subject: Re: [RFC/PATCH v2 02/16] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names Message-ID: <20210210224413.GA2919056@robh.at.kernel.org> References: <20210209125912.3398-1-nsaenzjulienne@suse.de> <20210209125912.3398-3-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209125912.3398-3-nsaenzjulienne@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_174418_066927_A86B998D X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com, Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, mripard@kernel.org, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, wahrenst@gmx.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 09, 2021 at 01:58:58PM +0100, Nicolas Saenz Julienne wrote: > Anticipating the introduction of BCM2711, of which we'll need to support > its new Argon ASB, introduce reg-names into bcm2835-pm's binding. This > will help to have a consistent mapping between resources and their > meaning. > > Signed-off-by: Nicolas Saenz Julienne > --- > .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > index 8bc65e5f62a7..1dbe3657c690 100644 > --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > @@ -26,8 +26,13 @@ properties: > reg: > minItems: 1 > maxItems: 2 > - description: Specifies base physical address and size of the two register > - ranges, "PM" and "ASYNC_BRIDGE" in that order. Ah, it's okay this way if you have -names. Or have items to give a bit more detail. > + > + reg-names: > + minItems: 1 > + maxItems: 2 > + items: > + - const: pm > + - const: rpivid_asb Not really clear how this corresponds to 'ASYNC_BRIDGE'. 'asb' I guess? > > "#power-domain-cells": > const: 1 > @@ -54,6 +59,7 @@ properties: > required: > - compatible > - reg > + - reg-names You can't really make added properties required. > - "#power-domain-cells" > - "#reset-cells" > - clocks > @@ -70,6 +76,7 @@ examples: > #reset-cells = <1>; > reg = <0x7e100000 0x114>, > <0x7e00a000 0x24>; > + reg-names = "pm", "rpivid_asb"; > clocks = <&clocks BCM2835_CLOCK_V3D>, > <&clocks BCM2835_CLOCK_PERI_IMAGE>, > <&clocks BCM2835_CLOCK_H264>, > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel