From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF2FC433E0 for ; Thu, 11 Feb 2021 11:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFA9464E26 for ; Thu, 11 Feb 2021 11:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231551AbhBKL7S (ORCPT ); Thu, 11 Feb 2021 06:59:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbhBKLnt (ORCPT ); Thu, 11 Feb 2021 06:43:49 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 261A3C061786; Thu, 11 Feb 2021 03:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=171MwOUvsWIHzLzoF2D6HOassCV+3rcVeB4dQ2ccn18=; b=k5ICOV/XdwTZJ4niWN8HTCoP/ 5ng/qZfsr3O8KnopiOljtDXzBDBRfEJ//77OY87zPaMX/gHd2Sg6DcbLbRKnsNVZ8In6UKhi604+q 39zsZnr1+3NDkD3lgfCDVX82oPffh7MneFYKZTynSG+e6M+rjp21iNuz4Wpg+SmpWpRK+7nHq4oZB nkwDHzQcCKiMP9bCE1bd+TniuFWGofkQxwk3zzktsdELvBVzJ+9s9eGgHZZDK/t1jko6J2wd1RaQw kVqyegJH9YRiAqswESTn2woWI7EJnbbMIqiXoWcAO+Tk4Ti2B7kTq/kpsgb64r3G2b55xgqbLkcI1 8ndn+QDSw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42010) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAAMr-00064X-RN; Thu, 11 Feb 2021 11:42:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lAAMo-00063s-64; Thu, 11 Feb 2021 11:42:38 +0000 Date: Thu, 11 Feb 2021 11:42:38 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com, linux-kernel@vger.kernel.org, kuba@kernel.org, mw@semihalf.com, andrew@lunn.ch, atenart@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition Message-ID: <20210211114238.GD1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-6-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1613040542-16500-6-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 12:48:52PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski > > This patch add PPv23 version definition. > PPv23 is new packet processor in CP115. > Everything that supported by PPv22, also supported by PPv23. > No functional changes in this stage. > > Signed-off-by: Stefan Chulski > Acked-by: Marcin Wojtas Reviewed-by: Russell King > @@ -7049,6 +7049,11 @@ static int mvpp2_probe(struct platform_device *pdev) > priv->port_map |= BIT(i); > } > > + if (priv->hw_version != MVPP21) { > + if (mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23) > + priv->hw_version = MVPP23; > + } > + The only minor comment I have on this is... the formatting of the above. Wouldn't: if (priv->hw_version >= MVPP22 && mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23) priv->hw_version = MVPP23; read better? Do we need to even check priv->hw_version here? Isn't this register implemented in PPv2.1 where it contains the value zero? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A13C433E0 for ; Thu, 11 Feb 2021 11:44:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02C3464E2F for ; Thu, 11 Feb 2021 11:44:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02C3464E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GmeNmwytZFxhu/wvTBgoTi0srZkHPBs//tkOR3NhqgI=; b=FhWqW2raz++vTfIAobMBriFY7 9j6b6SvdQwx8G9+bgif25uW8HTIgVEAmx0mhEc29tEQ8heYamZ4fFh4O6zKtCF4Oj2WfDHRDnorlI ATPlrQ60rmPt565z040IHTZGKgvLd0o8QhTomr/rx7U3NXiw2tBMEnyHEGYgqW5B1ro9SwYqte6wg DxAFqxGxu4zt/kqu3CLk1Sb230kAE+u9F0Gc4s0c3C1A3jKcdOoLyw0gdxfvjXCgC0puAwy2S9NKX Xre+3/p0N2ZrsPGdhxyhNOCof+TxgCjPeZB9WWQVhf7P4nzuF8Olg5NlN/a5YXXAP9Of6Mn8vKRqj UidxyJRiw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAAN4-0000pC-6Q; Thu, 11 Feb 2021 11:42:54 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAAN1-0000ol-7H for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 11:42:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=171MwOUvsWIHzLzoF2D6HOassCV+3rcVeB4dQ2ccn18=; b=k5ICOV/XdwTZJ4niWN8HTCoP/ 5ng/qZfsr3O8KnopiOljtDXzBDBRfEJ//77OY87zPaMX/gHd2Sg6DcbLbRKnsNVZ8In6UKhi604+q 39zsZnr1+3NDkD3lgfCDVX82oPffh7MneFYKZTynSG+e6M+rjp21iNuz4Wpg+SmpWpRK+7nHq4oZB nkwDHzQcCKiMP9bCE1bd+TniuFWGofkQxwk3zzktsdELvBVzJ+9s9eGgHZZDK/t1jko6J2wd1RaQw kVqyegJH9YRiAqswESTn2woWI7EJnbbMIqiXoWcAO+Tk4Ti2B7kTq/kpsgb64r3G2b55xgqbLkcI1 8ndn+QDSw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42010) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAAMr-00064X-RN; Thu, 11 Feb 2021 11:42:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lAAMo-00063s-64; Thu, 11 Feb 2021 11:42:38 +0000 Date: Thu, 11 Feb 2021 11:42:38 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Subject: Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition Message-ID: <20210211114238.GD1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-6-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613040542-16500-6-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_064251_288506_CABCC149 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, nadavh@marvell.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 12:48:52PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski > > This patch add PPv23 version definition. > PPv23 is new packet processor in CP115. > Everything that supported by PPv22, also supported by PPv23. > No functional changes in this stage. > > Signed-off-by: Stefan Chulski > Acked-by: Marcin Wojtas Reviewed-by: Russell King > @@ -7049,6 +7049,11 @@ static int mvpp2_probe(struct platform_device *pdev) > priv->port_map |= BIT(i); > } > > + if (priv->hw_version != MVPP21) { > + if (mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23) > + priv->hw_version = MVPP23; > + } > + The only minor comment I have on this is... the formatting of the above. Wouldn't: if (priv->hw_version >= MVPP22 && mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23) priv->hw_version = MVPP23; read better? Do we need to even check priv->hw_version here? Isn't this register implemented in PPv2.1 where it contains the value zero? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel