[PATCH] sbsa-ref: remove cortex-a53 from list of supported cpus

[PATCH] sbsa-ref: remove cortex-a53 from list of supported cpus

[Marcin Juszkiewicz]

Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts
above this limit.
---
 hw/arm/sbsa-ref.c | 1 -
 1 file changed, 1 deletion(-)

diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c
index 9f70735153..276243d122 100644
--- hw/arm/sbsa-ref.c
+++ hw/arm/sbsa-ref.c
@@ -145,7 +145,6 @@ static const int sbsa_ref_irqmap[] = {
 };
 
 static const char * const valid_cpus[] = {
-    ARM_CPU_TYPE_NAME("cortex-a53"),
     ARM_CPU_TYPE_NAME("cortex-a57"),
     ARM_CPU_TYPE_NAME("cortex-a72"),
 };
-- 
2.29.2

Re: [PATCH] sbsa-ref: remove cortex-a53 from list of supported cpus

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210211122022.1811362-1-marcin.juszkiewicz@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210211122022.1811362-1-marcin.juszkiewicz@linaro.org
Subject: [PATCH] sbsa-ref: remove cortex-a53 from list of supported cpus

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210211122022.1811362-1-marcin.juszkiewicz@linaro.org -> patchew/20210211122022.1811362-1-marcin.juszkiewicz@linaro.org
Switched to a new branch 'test'
81ea75b sbsa-ref: remove cortex-a53 from list of supported cpus

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 7 lines checked

Commit 81ea75b7e8bb (sbsa-ref: remove cortex-a53 from list of supported cpus) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210211122022.1811362-1-marcin.juszkiewicz@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

[PATCH 1/2] sbsa-ref: remove cortex-a53 from list of supported cpus

[Marcin Juszkiewicz]

Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts
above this limit.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 hw/arm/sbsa-ref.c | 1 -
 1 file changed, 1 deletion(-)

diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c
index 9f70735153..276243d122 100644
--- hw/arm/sbsa-ref.c
+++ hw/arm/sbsa-ref.c
@@ -145,7 +145,6 @@ static const int sbsa_ref_irqmap[] = {
 };
 
 static const char * const valid_cpus[] = {
-    ARM_CPU_TYPE_NAME("cortex-a53"),
     ARM_CPU_TYPE_NAME("cortex-a57"),
     ARM_CPU_TYPE_NAME("cortex-a72"),
 };
-- 
2.29.2

[PATCH 2/2] sbsa-ref: add 'max' to list of allowed cpus

[Marcin Juszkiewicz]

Let add 'max' cpu while work goes on adding newer CPU types than
Cortex-A72. This allows us to check SVE etc support.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 hw/arm/sbsa-ref.c | 1 +
 1 file changed, 1 insertion(+)

diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c
index 276243d122..88dfb2284c 100644
--- hw/arm/sbsa-ref.c
+++ hw/arm/sbsa-ref.c
@@ -147,6 +147,7 @@ static const int sbsa_ref_irqmap[] = {
 static const char * const valid_cpus[] = {
     ARM_CPU_TYPE_NAME("cortex-a57"),
     ARM_CPU_TYPE_NAME("cortex-a72"),
+    ARM_CPU_TYPE_NAME("max"),
 };
 
 static bool cpu_type_valid(const char *cpu)
-- 
2.29.2

Re: [PATCH 1/2] sbsa-ref: remove cortex-a53 from list of supported cpus

[Philippe Mathieu-Daudé]

Hi Marcin,

This is v2.

Please don't post new patch series as subthread in another one.

On 2/11/21 1:36 PM, Marcin Juszkiewicz wrote:
> Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts
> above this limit.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>  hw/arm/sbsa-ref.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH 2/2] sbsa-ref: add 'max' to list of allowed cpus

[Leif Lindholm]

On Thu, Feb 11, 2021 at 13:36:38 +0100, Marcin Juszkiewicz wrote:
> Let add 'max' cpu while work goes on adding newer CPU types than
> Cortex-A72. This allows us to check SVE etc support.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Acked-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  hw/arm/sbsa-ref.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c
> index 276243d122..88dfb2284c 100644
> --- hw/arm/sbsa-ref.c
> +++ hw/arm/sbsa-ref.c
> @@ -147,6 +147,7 @@ static const int sbsa_ref_irqmap[] = {
>  static const char * const valid_cpus[] = {
>      ARM_CPU_TYPE_NAME("cortex-a57"),
>      ARM_CPU_TYPE_NAME("cortex-a72"),
> +    ARM_CPU_TYPE_NAME("max"),
>  };
>  
>  static bool cpu_type_valid(const char *cpu)
> -- 
> 2.29.2
> 

Re: [PATCH 1/2] sbsa-ref: remove cortex-a53 from list of supported cpus

[Leif Lindholm]

On Thu, Feb 11, 2021 at 13:36:37 +0100, Marcin Juszkiewicz wrote:
> Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts
> above this limit.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Acked-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  hw/arm/sbsa-ref.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c
> index 9f70735153..276243d122 100644
> --- hw/arm/sbsa-ref.c
> +++ hw/arm/sbsa-ref.c
> @@ -145,7 +145,6 @@ static const int sbsa_ref_irqmap[] = {
>  };
>  
>  static const char * const valid_cpus[] = {
> -    ARM_CPU_TYPE_NAME("cortex-a53"),
>      ARM_CPU_TYPE_NAME("cortex-a57"),
>      ARM_CPU_TYPE_NAME("cortex-a72"),
>  };
> -- 
> 2.29.2
> 

Re: [PATCH 1/2] sbsa-ref: remove cortex-a53 from list of supported cpus

[Peter Maydell]

On Thu, 11 Feb 2021 at 12:36, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts
> above this limit.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Hi; could you resend your patches in the right format, please?
 * with a cover letter if it's a multi-patch series
 * with the cover letter not a reply-to or follow-up to any
   existing email
 * with each patch in the series being a follow-up to its cover letter
 * with a suitable '[PATCH v3]' in the subject if this is v3 of
   a patch(series), etc
 * with any accumulated reviewed-by, acked-by, etc tags

Otherwise it's pretty confusing to try to fish the right version
out of the mailing list; in particular the automated patch handling
tools and scripts have got confused by your patches here.

https://wiki.qemu.org/Contribute/SubmitAPatch has some notes.

thanks
-- PMM