From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27232C433DB for ; Thu, 11 Feb 2021 13:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8C8464DFF for ; Thu, 11 Feb 2021 13:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbhBKNNB (ORCPT ); Thu, 11 Feb 2021 08:13:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231437AbhBKMxU (ORCPT ); Thu, 11 Feb 2021 07:53:20 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4CAC061756; Thu, 11 Feb 2021 04:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=b+d/UsRJbDcvXOU7lVKV60HeDxwwY/1A5/qcbhLE4dA=; b=V+dTCIhJyFvGttNB4GvsqDqTn KiA3/PTaORHH143rcJyJtmQ3iU3Z0x2jRMchnwyhG/0Oz0je0x4iOOG8sHXNCgNwzmJmiz0HLc01m y/dizdLNf4YwtM5TwL0rkF8UNLKN018NKuPq8W8UZ6YrhIvif/rLEO1BBVHmDZz7wB5Rcf+IowNxT 5BHlhkzJE0G7xvdzdSk8U4oYZihX5cToyljYh1l0pGWpV7GyZguqkAYwQC4Bmx4SkCrcz4MXsOvM5 IMjEAVvqiCxtMEa/j8xgZuyJz53Te60ZBxL8nIlR94Pm1B2JCW6JDpA+zcDBRTHt89SkxbDSI0xt1 5dYqTcltA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42032) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lABSW-0006AO-P2; Thu, 11 Feb 2021 12:52:36 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lABSV-00066Z-Oe; Thu, 11 Feb 2021 12:52:35 +0000 Date: Thu, 11 Feb 2021 12:52:35 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com, linux-kernel@vger.kernel.org, kuba@kernel.org, mw@semihalf.com, andrew@lunn.ch, atenart@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control Message-ID: <20210211125235.GG1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-10-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1613040542-16500-10-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 12:48:56PM +0200, stefanc@marvell.com wrote: > +static void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data) > +{ > + writel(data, priv->cm3_base + offset); > +} > + > +static u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset) > +{ > + return readl(priv->cm3_base + offset); > +} > + Would it also make sense to have mvpp2_cm3_modify() ? You seem to be adding several instances of read-modify-write sequences to CM3 RAM in your series. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9730CC433E6 for ; Thu, 11 Feb 2021 12:53:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34F6F64E25 for ; Thu, 11 Feb 2021 12:53:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34F6F64E25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fBDwRkVkU7bujM9mRQvhG4rulxpwu/OCtRgY9GkKOxc=; b=UFHnmBhnY06QDpC/RW3Q9lRcs cLi3KU0Ei2Lw8F8rtRre2hwNf7r8yVCUs1M1Y0S3SnFWduWAdJN1MFYKAtYwVt/DUQGpE6tztDrHI LxovzgtNnEJHUKYtDzmDOlgteDINz8vKm73CfiXfCCIqDAAeqzqsb88Uu6QdR7hUDt1ru70tYbag5 ghWVqnmyPo+peRq1oaLEB4Q87Ij/SOocG4A907z4g1CQVLanBVjFh09n803UvOKQLqUHt0rDl8tfy DQkQd5LLT9pZRwhotzwe0vt6Z9Y5fVrOoXMTEfg5v+jqfQ+i4PTDyJAz3r5rpmrtUGaMHv3RfOWcm wgA5JnWjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lABSf-0001NF-Ak; Thu, 11 Feb 2021 12:52:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lABSc-0001MR-Hw for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 12:52:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=b+d/UsRJbDcvXOU7lVKV60HeDxwwY/1A5/qcbhLE4dA=; b=V+dTCIhJyFvGttNB4GvsqDqTn KiA3/PTaORHH143rcJyJtmQ3iU3Z0x2jRMchnwyhG/0Oz0je0x4iOOG8sHXNCgNwzmJmiz0HLc01m y/dizdLNf4YwtM5TwL0rkF8UNLKN018NKuPq8W8UZ6YrhIvif/rLEO1BBVHmDZz7wB5Rcf+IowNxT 5BHlhkzJE0G7xvdzdSk8U4oYZihX5cToyljYh1l0pGWpV7GyZguqkAYwQC4Bmx4SkCrcz4MXsOvM5 IMjEAVvqiCxtMEa/j8xgZuyJz53Te60ZBxL8nIlR94Pm1B2JCW6JDpA+zcDBRTHt89SkxbDSI0xt1 5dYqTcltA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42032) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lABSW-0006AO-P2; Thu, 11 Feb 2021 12:52:36 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lABSV-00066Z-Oe; Thu, 11 Feb 2021 12:52:35 +0000 Date: Thu, 11 Feb 2021 12:52:35 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Subject: Re: [PATCH v13 net-next 09/15] net: mvpp2: enable global flow control Message-ID: <20210211125235.GG1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-10-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613040542-16500-10-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_075242_619981_93496DB9 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, nadavh@marvell.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 12:48:56PM +0200, stefanc@marvell.com wrote: > +static void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data) > +{ > + writel(data, priv->cm3_base + offset); > +} > + > +static u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset) > +{ > + return readl(priv->cm3_base + offset); > +} > + Would it also make sense to have mvpp2_cm3_modify() ? You seem to be adding several instances of read-modify-write sequences to CM3 RAM in your series. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel