From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B02C433E9 for ; Thu, 11 Feb 2021 15:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3EC264F56 for ; Thu, 11 Feb 2021 15:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhBKPTz (ORCPT ); Thu, 11 Feb 2021 10:19:55 -0500 Received: from verein.lst.de ([213.95.11.211]:55791 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbhBKPRs (ORCPT ); Thu, 11 Feb 2021 10:17:48 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 26D0968CF0; Thu, 11 Feb 2021 16:16:57 +0100 (CET) Date: Thu, 11 Feb 2021 16:16:56 +0100 From: Christoph Hellwig To: Mike Christie Cc: hch@lst.de, loberman@redhat.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, mst@redhat.com, stefanha@redhat.com Subject: Re: [PATCH 13/14] tcm_fc: Convert to new submission API Message-ID: <20210211151656.GK22082@lst.de> References: <20210211122728.31721-1-michael.christie@oracle.com> <20210211122728.31721-14-michael.christie@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210211122728.31721-14-michael.christie@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org > + if (target_init_cmd(&cmd->se_cmd, cmd->sess->se_sess, > + &cmd->ft_sense_buffer[0], scsilun_to_int(&fcp->fc_lun), > + ntohl(fcp->fc_dl), task_attr, data_dir, It would be nice to avoid the overly long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig