From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1774C433E0 for ; Thu, 11 Feb 2021 20:18:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CA3A64DBA for ; Thu, 11 Feb 2021 20:18:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CA3A64DBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAIPi-0008GB-6R for qemu-devel@archiver.kernel.org; Thu, 11 Feb 2021 15:18:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAINK-0006pW-12 for qemu-devel@nongnu.org; Thu, 11 Feb 2021 15:15:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAINH-0003iB-T9 for qemu-devel@nongnu.org; Thu, 11 Feb 2021 15:15:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613074538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TcqYD6qxjiCWw64Hwo5hD9nnDj8rw4q0MFl20zfxP3M=; b=i4wFs7EIbEio0CbQjbyy+i/DeB0YckFiUkWDW1sK1hNx4B6Qg01KUVdekooWam5rSpbTjA pbUpGhjyKOKEW0UpbR7hL2kg44dMeSI2I7BmpJSYuptE4BXrrrdFi/ruoywUS4qvNZCpkQ Z0Z5wBJQCiNeCWWvtW2f991Xrq5q13I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-bNo4OQT-MjOnp71MGB2voA-1; Thu, 11 Feb 2021 15:15:37 -0500 X-MC-Unique: bNo4OQT-MjOnp71MGB2voA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DAB308EA369 for ; Thu, 11 Feb 2021 20:15:19 +0000 (UTC) Received: from horse.redhat.com (ovpn-115-229.rdu2.redhat.com [10.10.115.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B6111B5F8; Thu, 11 Feb 2021 20:15:19 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id DB929220BCF; Thu, 11 Feb 2021 15:15:18 -0500 (EST) Date: Thu, 11 Feb 2021 15:15:18 -0500 From: Vivek Goyal To: "Dr. David Alan Gilbert" Subject: Re: [PATCH 10/24] DAX: virtiofsd: Add setup/remove mappings fuse commands Message-ID: <20210211201518.GA32784@redhat.com> References: <20210209190224.62827-1-dgilbert@redhat.com> <20210209190224.62827-11-dgilbert@redhat.com> <20210211123738.GK247031@stefanha-x1.localdomain> <20210211183020.GA29443@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi , mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 11, 2021 at 07:50:37PM +0000, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgoyal@redhat.com) wrote: > > On Thu, Feb 11, 2021 at 04:39:22PM +0000, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefanha@redhat.com) wrote: > > > > On Tue, Feb 09, 2021 at 07:02:10PM +0000, Dr. David Alan Gilbert (git) wrote: > > > > > +static void do_removemapping(fuse_req_t req, fuse_ino_t nodeid, > > > > > + struct fuse_mbuf_iter *iter) > > > > > +{ > > > > > + struct fuse_removemapping_in *arg; > > > > > + struct fuse_removemapping_one *one; > > > > > + > > > > > + arg = fuse_mbuf_iter_advance(iter, sizeof(*arg)); > > > > > + if (!arg || arg->count <= 0) { > > > > > > > > arg->count is unsigned so < is tautologous. > > > > > > > > > + fuse_log(FUSE_LOG_ERR, "do_removemapping: invalid arg %p\n", arg); > > > > > + fuse_reply_err(req, EINVAL); > > > > > + return; > > > > > + } > > > > > + > > > > > + one = fuse_mbuf_iter_advance(iter, arg->count * sizeof(*one)); > > > > > > > > arg->count * sizeof(*one) is an integer overflow on 32-bit hosts. I > > > > think we should be more defensive here since this input comes from the > > > > guest. > > > > > > OK, so I've gone with: > > > > > > if (!arg || !arg->count || > > > (uint64_t)arg->count * sizeof(*one) >= SIZE_MAX) { > > > fuse_log(FUSE_LOG_ERR, "do_removemapping: invalid arg %p\n", arg); > > > fuse_reply_err(req, EINVAL); > > > return; > > > > If we did not want to get into unit64_t business, can we alternatively do. > > if (!arg || !arg->count || arg->count > SIZE_MAX/sizeof(*one)) { > > I tried that and the compiler moaned that it was always false; which on > a 64bit host it is since arg->count is uint32_t. Hmm.... May be something like. bool is_arg_count_valid() { if (!arg->count) return false; #if __WORDSIZE == 64 return true; #elif if (argc->count > SIZE_MAX/sizeof(*one)) return false; #fi return true; } if (!argc || !is_arg_count_valie()) { } Vivek From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 11 Feb 2021 15:15:18 -0500 From: Vivek Goyal Message-ID: <20210211201518.GA32784@redhat.com> References: <20210209190224.62827-1-dgilbert@redhat.com> <20210209190224.62827-11-dgilbert@redhat.com> <20210211123738.GK247031@stefanha-x1.localdomain> <20210211183020.GA29443@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Virtio-fs] [PATCH 10/24] DAX: virtiofsd: Add setup/remove mappings fuse commands List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: virtio-fs@redhat.com, marcandre.lureau@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Thu, Feb 11, 2021 at 07:50:37PM +0000, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgoyal@redhat.com) wrote: > > On Thu, Feb 11, 2021 at 04:39:22PM +0000, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefanha@redhat.com) wrote: > > > > On Tue, Feb 09, 2021 at 07:02:10PM +0000, Dr. David Alan Gilbert (git) wrote: > > > > > +static void do_removemapping(fuse_req_t req, fuse_ino_t nodeid, > > > > > + struct fuse_mbuf_iter *iter) > > > > > +{ > > > > > + struct fuse_removemapping_in *arg; > > > > > + struct fuse_removemapping_one *one; > > > > > + > > > > > + arg = fuse_mbuf_iter_advance(iter, sizeof(*arg)); > > > > > + if (!arg || arg->count <= 0) { > > > > > > > > arg->count is unsigned so < is tautologous. > > > > > > > > > + fuse_log(FUSE_LOG_ERR, "do_removemapping: invalid arg %p\n", arg); > > > > > + fuse_reply_err(req, EINVAL); > > > > > + return; > > > > > + } > > > > > + > > > > > + one = fuse_mbuf_iter_advance(iter, arg->count * sizeof(*one)); > > > > > > > > arg->count * sizeof(*one) is an integer overflow on 32-bit hosts. I > > > > think we should be more defensive here since this input comes from the > > > > guest. > > > > > > OK, so I've gone with: > > > > > > if (!arg || !arg->count || > > > (uint64_t)arg->count * sizeof(*one) >= SIZE_MAX) { > > > fuse_log(FUSE_LOG_ERR, "do_removemapping: invalid arg %p\n", arg); > > > fuse_reply_err(req, EINVAL); > > > return; > > > > If we did not want to get into unit64_t business, can we alternatively do. > > if (!arg || !arg->count || arg->count > SIZE_MAX/sizeof(*one)) { > > I tried that and the compiler moaned that it was always false; which on > a 64bit host it is since arg->count is uint32_t. Hmm.... May be something like. bool is_arg_count_valid() { if (!arg->count) return false; #if __WORDSIZE == 64 return true; #elif if (argc->count > SIZE_MAX/sizeof(*one)) return false; #fi return true; } if (!argc || !is_arg_count_valie()) { } Vivek