Re: [RFC PATCH 3/7] regulator: IRQ based event/error notification helpers

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2570 bytes --]

Hi Matti,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on regulator/for-next]
[also build test WARNING on v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Extend-regulator-notification-support/20210211-204336
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: i386-randconfig-s001-20210211 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://github.com/0day-ci/linux/commit/1844ad67f3ebe118184da7e83b30df9f4eb0caf0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matti-Vaittinen/Extend-regulator-notification-support/20210211-204336
        git checkout 1844ad67f3ebe118184da7e83b30df9f4eb0caf0
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/regulator/irq_helpers.c:286:5: warning: no previous prototype for 'dev_delayed_work_autocancel' [-Wmissing-prototypes]
     286 | int dev_delayed_work_autocancel(struct device *dev, struct delayed_work *w,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~


"sparse warnings: (new ones prefixed by >>)"
>> drivers/regulator/irq_helpers.c:286:5: sparse: sparse: symbol 'dev_delayed_work_autocancel' was not declared. Should it be static?

Please review and possibly fold the followup patch.

vim +/dev_delayed_work_autocancel +286 drivers/regulator/irq_helpers.c

   285	
 > 286	int dev_delayed_work_autocancel(struct device *dev, struct delayed_work *w,
   287					void (*worker)(struct work_struct *work))
   288	{
   289		struct delayed_work **ptr;
   290	
   291		ptr = devres_alloc(dev_delayed_work_drop, sizeof(*ptr), GFP_KERNEL);
   292		if (!ptr)
   293			return -ENOMEM;
   294	
   295		INIT_DELAYED_WORK(w, worker);
   296		*ptr = w;
   297		devres_add(dev, ptr);
   298	
   299		return 0;
   300	}
   301	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33850 bytes --]