From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, Jan Kara <jack@suse.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 1/2] quota: Add mountpath based quota support
Date: Fri, 12 Feb 2021 09:38:35 +0100 [thread overview]
Message-ID: <20210212083835.GF19583@pengutronix.de> (raw)
In-Reply-To: <20210211153813.GA2480649@infradead.org>
On Thu, Feb 11, 2021 at 03:38:13PM +0000, Christoph Hellwig wrote:
> > + if (!mountpoint)
> > + return -ENODEV;
> > +
> > + ret = user_path_at(AT_FDCWD, mountpoint,
> > + LOOKUP_FOLLOW | LOOKUP_AUTOMOUNT, &mountpath);
>
> user_path_at handles an empty path, although you'll get EFAULT instead.
> Do we care about the -ENODEV here?
The quotactl manpage documents EFAULT as error code for invalid addr or
special argument, so we really should return -EFAULT here.
Existing quotactl gets this wrong as well:
if (!special) {
if (cmds == Q_SYNC)
return quota_sync_all(type);
return -ENODEV;
}
Should we fix this or is there userspace code that is confused by a changed
return value?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-02-12 8:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 15:30 [PATCH v2 0/2] quota: Add mountpath based quota support Sascha Hauer
2021-02-11 15:30 ` [PATCH 1/2] " Sascha Hauer
2021-02-11 15:38 ` Christoph Hellwig
2021-02-12 8:38 ` Sascha Hauer [this message]
2021-02-12 10:05 ` Jan Kara
2021-02-12 10:29 ` Sascha Hauer
2021-02-12 10:41 ` Jan Kara
2021-02-12 5:45 ` kernel test robot
2021-02-12 5:45 ` kernel test robot
2021-02-14 13:48 ` Al Viro
2021-02-11 15:30 ` [PATCH 2/2] quota: wire up quotactl_path Sascha Hauer
2021-02-11 15:38 ` Christoph Hellwig
2021-02-11 19:56 ` kernel test robot
2021-02-11 19:56 ` kernel test robot
2021-02-12 0:10 ` kernel test robot
2021-02-12 0:10 ` kernel test robot
2021-02-11 15:30 ` [PATCH] quotactl.2: Add documentation for quotactl_path() Sascha Hauer
2021-02-12 10:16 ` [PATCH v2 0/2] quota: Add mountpath based quota support Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2021-03-04 12:35 [PATCH v3 " Sascha Hauer
2021-03-04 12:35 ` [PATCH 1/2] " Sascha Hauer
2021-01-28 14:17 [PATCH 0/2] " Sascha Hauer
2021-01-28 14:17 ` [PATCH 1/2] " Sascha Hauer
2021-01-28 14:35 ` Christoph Hellwig
2021-02-02 18:02 ` Jan Kara
2021-02-04 7:34 ` Christoph Hellwig
2021-02-04 12:53 ` Jan Kara
2021-02-09 8:51 ` Christoph Hellwig
2021-02-09 9:57 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212083835.GF19583@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.