From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC86C433E9 for ; Fri, 12 Feb 2021 09:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7353C64E8D for ; Fri, 12 Feb 2021 09:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbhBLJii (ORCPT ); Fri, 12 Feb 2021 04:38:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbhBLJia (ORCPT ); Fri, 12 Feb 2021 04:38:30 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50AD3C061788 for ; Fri, 12 Feb 2021 01:37:50 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id l17so336491wmq.2 for ; Fri, 12 Feb 2021 01:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PkIJB2P07r0I1a+6LmYfF/eJubpC6EF+zgj8b/X18t0=; b=eqRVHicKGReNXZNXMkWRBT0kFywqGplwhpjcUYlB+Dzf0i6cW4ak4i+4McZgmJiDxU qrcLAVDrynys9ejnB2JdhWeUwxwpesyBKOsqS28WeTxBLe/O8XZfxjSdPnL/Y5t0peNi yDM08OokUHlNIRwXFhjHYEZqY70UeuTxiiY+dQzuIaWkqIpwAfu2tbDXnUKmnGg3A/JM BmzedKCknGOD7v86cKOoEnA49Oa+EY0X217l2DnwuVg5eD0gNT3OOveC2ia01NRveZsm aI5Yrk+fFU+f1gZePAoti/0LbeM4BrPodYTHlpG/R4FnE3YtwJ1uZvsIC2Fd4YOpzJ6u P/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PkIJB2P07r0I1a+6LmYfF/eJubpC6EF+zgj8b/X18t0=; b=QFPiS6meS0TxFL8iGtvefCxjjZ5gtEkMOgmu0aaK1zIwCr8SIwjZ36j6+SfLqWDmJc 2Pu7u47Wb6WtFIuEelSxhlubk9/4tvl0iv2ewJY1LvxPVTWsD+Mdl5AQhFaBP3LUQDqK jmukXG9UM4jZxl5NiktM+Up/x+V24mSjB/Z0WV9xp70MeutTcbG98bv2ae4HZExPi59F Q2Wr656F+2rSgAfctTNOl+/Lf/GDJiITZdJ4GVDhRDynNNgg1IY417/QWWjTtzNclcu5 NsnnKAOrO0Cg4igt6zZZgGUVLG1ZmjT49bQD9PYnizdIQ4DOCGWOJ12IUfVpB9gGf8Bz XTSw== X-Gm-Message-State: AOAM531tMu5dodLJDWfyP2bezjy2bkAyK26O/KBb5ICT3oF478DKjKU0 8jzeTMg2iLKmMsnP3PHswkBzEg== X-Google-Smtp-Source: ABdhPJwDhFICyz/JghmhucGWJYKHNvfrNUqx6TUMtJd8PfA8C9At8/3JQNBc9Xkla9akgZ01OGXsSQ== X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr1879586wmc.168.1613122669035; Fri, 12 Feb 2021 01:37:49 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id u10sm12871354wmj.40.2021.02.12.01.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 01:37:48 -0800 (PST) Date: Fri, 12 Feb 2021 09:37:46 +0000 From: Lee Jones To: Timon Baetz Cc: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Rob Herring , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell Message-ID: <20210212093746.GH4572@dell> References: <20201222070520.710096-1-timon.baetz@protonmail.com> <20201222070520.710096-3-timon.baetz@protonmail.com> <20201222095522.GC53991@dell> <20210211221132.5e8d156c.timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210211221132.5e8d156c.timon.baetz@protonmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2021, Timon Baetz wrote: > On Tue, 22 Dec 2020 09:55:22 +0000, Lee Jones wrote: > > On Tue, 22 Dec 2020, Timon Baetz wrote: > > > > > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a > > > of_node set in the extcon driver. > > > > > > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure > > > the charger driver. > > > > > > Signed-off-by: Timon Baetz > > > --- > > > drivers/mfd/max8997.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Applied, thanks. > > Once https://lore.kernel.org/lkml/20210130172747.2022977-1-timon.baetz@protonmail.com/ > gets accepted, this is not needed anymore. Can this be reverted or > should I create a new patch? Please submit a revert with the reasons why. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE59BC433DB for ; Fri, 12 Feb 2021 09:38:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DD2B64E35 for ; Fri, 12 Feb 2021 09:38:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DD2B64E35 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OhMpPyM9iJZN9r1rI5Dvdx4y4Ms/eMVPqYL7MKB50xw=; b=azr3cTJKICSicG8qRF/t869ex +kwlFXfQX+b6zXvDdk3aVIwEwXBaNFkNadZpV7NHcgIDdQi3vsXIG6Ibk6t7fGFnPeK59MhCpXtIo rcWSVuRB0D3NrHkR/nHWLjgghUVmYfMZDMy74me/B+a033V8rnA6b41VH9CfOcyM3/Ax8oKsz1GgL zYagg0QCjRMQUYG1X6WUh4Zi5TRuD+TVEyRPWcaYeCXUGN3dI0jMOOOKfpZ1bngy2eM26VlzlnapV cL3GmxI5sQxwlL1eBSUf4Hc3g/Q0eBxgqdvBmLKPaUaxBHSna/JrIrcASOib3pSm3c1z/h10FQ7Kx ntXPJic0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAUtd-0003TB-Eo; Fri, 12 Feb 2021 09:37:54 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAUta-0003SK-HZ for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 09:37:51 +0000 Received: by mail-wm1-x334.google.com with SMTP id l17so336493wmq.2 for ; Fri, 12 Feb 2021 01:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PkIJB2P07r0I1a+6LmYfF/eJubpC6EF+zgj8b/X18t0=; b=eqRVHicKGReNXZNXMkWRBT0kFywqGplwhpjcUYlB+Dzf0i6cW4ak4i+4McZgmJiDxU qrcLAVDrynys9ejnB2JdhWeUwxwpesyBKOsqS28WeTxBLe/O8XZfxjSdPnL/Y5t0peNi yDM08OokUHlNIRwXFhjHYEZqY70UeuTxiiY+dQzuIaWkqIpwAfu2tbDXnUKmnGg3A/JM BmzedKCknGOD7v86cKOoEnA49Oa+EY0X217l2DnwuVg5eD0gNT3OOveC2ia01NRveZsm aI5Yrk+fFU+f1gZePAoti/0LbeM4BrPodYTHlpG/R4FnE3YtwJ1uZvsIC2Fd4YOpzJ6u P/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PkIJB2P07r0I1a+6LmYfF/eJubpC6EF+zgj8b/X18t0=; b=ACnSBM91L6bMsQ1YlA/XZeZfQZVCbxLINKmzWFIFiNWDJt7nF3oMtyjm2imY2elzIG PwU2zd+P1Xoy+CINdmqSm8IiHbzXzE2P7xepInO0xBNdPLiHGkgomG307gsd81U4Dh1x pbTWyi+peJIyVZda9V/f8PzVyrWB0dKNTKqVj8Ocr9DumKNO/aiihKisr27THqVm8bNQ LplqMZkwKQIO4O/MIwop/+dzQoLtRelwXYFFU3ui/kwdn+FvKV1QGNOIAhcpW4IqKAcm /O4xUg7/RcVlTJLzqK8JqQIVYsixRkWW/PuDVXFIjXTygFrmkuiRHw1yo3IUPAvtiZxh qAiw== X-Gm-Message-State: AOAM532Dv6Fbip96/EclC0rIbN6btUg1qQoKUj8/ZDFHwpCt2w5D9eVz btRgoT7ffJZ2PZG0Az1bPAmehg== X-Google-Smtp-Source: ABdhPJwDhFICyz/JghmhucGWJYKHNvfrNUqx6TUMtJd8PfA8C9At8/3JQNBc9Xkla9akgZ01OGXsSQ== X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr1879586wmc.168.1613122669035; Fri, 12 Feb 2021 01:37:49 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id u10sm12871354wmj.40.2021.02.12.01.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 01:37:48 -0800 (PST) Date: Fri, 12 Feb 2021 09:37:46 +0000 From: Lee Jones To: Timon Baetz Subject: Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell Message-ID: <20210212093746.GH4572@dell> References: <20201222070520.710096-1-timon.baetz@protonmail.com> <20201222070520.710096-3-timon.baetz@protonmail.com> <20201222095522.GC53991@dell> <20210211221132.5e8d156c.timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210211221132.5e8d156c.timon.baetz@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_043750_675615_C920386D X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Liam Girdwood , Krzysztof Kozlowski , Sebastian Reichel , Chanwoo Choi , Rob Herring , MyungJoo Ham , linux-arm-kernel@lists.infradead.org, ~postmarketos/upstreaming@lists.sr.ht Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxMSBGZWIgMjAyMSwgVGltb24gQmFldHogd3JvdGU6Cgo+IE9uIFR1ZSwgMjIgRGVj IDIwMjAgMDk6NTU6MjIgKzAwMDAsIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIFR1ZSwgMjIgRGVj IDIwMjAsIFRpbW9uIEJhZXR6IHdyb3RlOgo+ID4gCj4gPiA+IEFkZCBvZl9jb21wYXRpYmxlICgi bWF4aW0sbWF4ODk5Ny1tdWljIikgdG8gdGhlIG1mZF9jZWxsIHRvIGhhdmUgYQo+ID4gPiBvZl9u b2RlIHNldCBpbiB0aGUgZXh0Y29uIGRyaXZlci4KPiA+ID4KPiA+ID4gQWRkIG9mX2NvbXBhdGli bGUgKCJtYXhpbSxtYXg4OTk3LWJhdHRlcnkiKSB0byB0aGUgbWZkX2NlbGwgdG8gY29uZmlndXJl Cj4gPiA+IHRoZSBjaGFyZ2VyIGRyaXZlci4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogVGlt b24gQmFldHogPHRpbW9uLmJhZXR6QHByb3Rvbm1haWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRy aXZlcnMvbWZkL21heDg5OTcuYyB8IDQgKystLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkgIAo+ID4gCj4gPiBBcHBsaWVkLCB0aGFua3MuCj4g Cj4gT25jZSBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjEwMTMwMTcyNzQ3LjIwMjI5 NzctMS10aW1vbi5iYWV0ekBwcm90b25tYWlsLmNvbS8KPiBnZXRzIGFjY2VwdGVkLCB0aGlzIGlz IG5vdCBuZWVkZWQgYW55bW9yZS4gQ2FuIHRoaXMgYmUgcmV2ZXJ0ZWQgb3IKPiBzaG91bGQgSSBj cmVhdGUgYSBuZXcgcGF0Y2g/CgpQbGVhc2Ugc3VibWl0IGEgcmV2ZXJ0IHdpdGggdGhlIHJlYXNv bnMgd2h5LgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQg LSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUg Zm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK