From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593B0C433E0 for ; Fri, 12 Feb 2021 12:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2254364E23 for ; Fri, 12 Feb 2021 12:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbhBLM1n (ORCPT ); Fri, 12 Feb 2021 07:27:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:52696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbhBLM0E (ORCPT ); Fri, 12 Feb 2021 07:26:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 236E664E08; Fri, 12 Feb 2021 12:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613132723; bh=y5Zu5DaSe5YSQROZFDmQMEM/SLB1B4Zi5B+xZw/6laQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k7dRM6wj5IEwUVWtIdiRquEySnaehLrt5vu0S6Q6bywuN1ypraAYDHQ7hENK38lbd kppTPbO5Bkb0QkjY5vQB1ENG833TkhZqGGIWqG8Bzlw6BMaZnAw4Tb/UPj2MkQIaCd Fic2PwHCnNo7yom6cl9OnK5mAs5QJIpQBsGxxsUP/5DJsl7YmC+qKdhVMS9DwWfH85 Z2gOIKwqvp225UYEuPQ98BVTfP/S8E/1vehmyQ9MuxAj2yUuSv+AJJ//qu6jBX4biH tPiz69FMPfeKcI83jvo/tDWtXyqlM7uGUcXSlUBhVjG2W1Xyfd5l9Mmf86nJ8pAp4m +zi5guY1yPVhg== Date: Fri, 12 Feb 2021 13:25:21 +0100 From: Frederic Weisbecker To: Marcelo Tosatti Cc: Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [patch 2/3] nohz: change signal tick dependency to wakeup CPUs of member tasks Message-ID: <20210212122521.GA90839@lothringen> References: <20210128202134.608115362@fuller.cnet> <20210128202235.849263653@fuller.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210128202235.849263653@fuller.cnet> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 05:21:36PM -0300, Marcelo Tosatti wrote: > Rather than waking up all nohz_full CPUs on the system, only wakeup > the target CPUs of member threads of the signal. > > Reduces interruptions to nohz_full CPUs. > > Signed-off-by: Marcelo Tosatti > > Index: linux-2.6/kernel/time/tick-sched.c > =================================================================== > --- linux-2.6.orig/kernel/time/tick-sched.c > +++ linux-2.6/kernel/time/tick-sched.c > @@ -444,9 +444,20 @@ EXPORT_SYMBOL_GPL(tick_nohz_dep_clear_ta > * Set a per-taskgroup tick dependency. Posix CPU timers need this in order to elapse > * per process timers. > */ > -void tick_nohz_dep_set_signal(struct signal_struct *sig, enum tick_dep_bits > bit) Why not keeping the signal struct as a parameter? Thanks.