From: Frederic Weisbecker <frederic@kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/3] nohz: change signal tick dependency to wakeup CPUs of member tasks
Date: Fri, 12 Feb 2021 15:18:17 +0100 [thread overview]
Message-ID: <20210212141817.GA94816@lothringen> (raw)
In-Reply-To: <20210212140041.GA182392@fuller.cnet>
On Fri, Feb 12, 2021 at 11:00:41AM -0300, Marcelo Tosatti wrote:
> On Fri, Feb 12, 2021 at 01:25:21PM +0100, Frederic Weisbecker wrote:
> > On Thu, Jan 28, 2021 at 05:21:36PM -0300, Marcelo Tosatti wrote:
> > > Rather than waking up all nohz_full CPUs on the system, only wakeup
> > > the target CPUs of member threads of the signal.
> > >
> > > Reduces interruptions to nohz_full CPUs.
> > >
> > > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > >
> > > Index: linux-2.6/kernel/time/tick-sched.c
> > > ===================================================================
> > > --- linux-2.6.orig/kernel/time/tick-sched.c
> > > +++ linux-2.6/kernel/time/tick-sched.c
> > > @@ -444,9 +444,20 @@ EXPORT_SYMBOL_GPL(tick_nohz_dep_clear_ta
> > > * Set a per-taskgroup tick dependency. Posix CPU timers need this in order to elapse
> > > * per process timers.
> > > */
> > > -void tick_nohz_dep_set_signal(struct signal_struct *sig, enum tick_dep_bits
> > > bit)
> >
> > Why not keeping the signal struct as a parameter?
> >
> > Thanks.
>
> All callers use "struct signal_struct *sig = tsk->signal" as
> signal parameter anyway...
Sure, but that makes more sense with the function role and name.
>
> Can change parameters to (task, signal, bit) if you prefer.
That's ok I can do it, just wanted to make sure I wasn't missing
a reason behind it.
Thanks!
next prev parent reply other threads:[~2021-02-12 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 20:21 [patch 0/3] nohz_full: only wakeup target CPUs when notifying new tick dependency (v5) Marcelo Tosatti
2021-01-28 20:21 ` [patch 1/3] nohz: only wakeup a single target cpu when kicking a task Marcelo Tosatti
2021-01-28 20:21 ` [patch 2/3] nohz: change signal tick dependency to wakeup CPUs of member tasks Marcelo Tosatti
2021-02-12 12:25 ` Frederic Weisbecker
2021-02-12 14:00 ` Marcelo Tosatti
2021-02-12 14:18 ` Frederic Weisbecker [this message]
2021-01-28 20:21 ` [patch 3/3] nohz: tick_nohz_kick_task: only IPI if remote task is running Marcelo Tosatti
2021-02-12 14:19 ` [patch 0/3] nohz_full: only wakeup target CPUs when notifying new tick dependency (v5) Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2021-01-28 18:40 [patch 0/3] nohz_full: only wakeup target CPUs when notifying new tick dependency (v4) Marcelo Tosatti
2021-01-28 18:40 ` [patch 2/3] nohz: change signal tick dependency to wakeup CPUs of member tasks Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212141817.GA94816@lothringen \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.