From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBB7C433DB for ; Fri, 12 Feb 2021 16:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 984E164E08 for ; Fri, 12 Feb 2021 16:14:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbhBLQOv (ORCPT ); Fri, 12 Feb 2021 11:14:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35049 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbhBLQOr (ORCPT ); Fri, 12 Feb 2021 11:14:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613146399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L5Nb2hpHuSmEncyB7k8Kpd8+QlfZitjO1fAJZA9q6Ek=; b=c04pVCzCWxuAj4I8knnl2Fc94M4gxl+vhFqM+4N8r4Cm0A/BpGqOXwXqNEVxtHAYhVZb7T OobeeyS2WarBEiKts6MoyUTrSQytJ2ObQDHpnw+Uua1ooCDVEHs1vrNFB5V3bvaw97KC3R EYk0c8+lQt+x/A/VxwJcUl0fttwz2rs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-2ly9sgg-M8a8-Mt3Amhy4g-1; Fri, 12 Feb 2021 11:13:14 -0500 X-MC-Unique: 2ly9sgg-M8a8-Mt3Amhy4g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 271E51934100; Fri, 12 Feb 2021 16:13:12 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0204360BF1; Fri, 12 Feb 2021 16:13:05 +0000 (UTC) Date: Fri, 12 Feb 2021 11:13:05 -0500 From: Mike Snitzer To: Sergei Shtepa Cc: Damien.LeMoal@wdc.com, hare@suse.de, ming.lei@redhat.com, agk@redhat.com, corbet@lwn.net, axboe@kernel.dk, jack@suse.cz, johannes.thumshirn@wdc.com, gregkh@linuxfoundation.org, koct9i@gmail.com, steve@sk2.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, pavel.tide@veeam.com Subject: Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD Message-ID: <20210212161305.GB19424@redhat.com> References: <1612881028-7878-1-git-send-email-sergei.shtepa@veeam.com> <1612881028-7878-5-git-send-email-sergei.shtepa@veeam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612881028-7878-5-git-send-email-sergei.shtepa@veeam.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa wrote: > New ioctl DM_DEV_REMAP_CMD allow to remap bio requests > from regular block device to dm device. I really dislike the (ab)use of "REMAP" for this. DM is and always has been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD Similarly, all places documenting "remap" or variables with "remap" changed to "interpose". Also, any chance you'd be open to putting all these interposer specific changes in dm-interposer.[ch] ? (the various internal structs for DM core _should_ be available via dm-core.h) Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB67C433DB for ; Fri, 12 Feb 2021 16:13:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36E9864E08 for ; Fri, 12 Feb 2021 16:13:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36E9864E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613146404; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lYEbAeI2b+vdCYiUZyex74EJAHTszYpFiJ/fTpNcj8I=; b=S8ePLwdYsATu7HBqSjyE5MCnEj3wlzTTY0Wwa8JKQgCrDlVSPNyGCTKiArYBoyvOeXDA0s fbANfbDpJ2XWba0FYl3Wlv6Wav2nOPztwt3GRXwbxyp1oSxI2R3OHuJbiGzmBlc2p4YDgn i8TKfRzZNm3gD0+TZ77SNbrHs8EkJQE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-gzgX3RlCO9ORSZ4X5-kb1g-1; Fri, 12 Feb 2021 11:13:21 -0500 X-MC-Unique: gzgX3RlCO9ORSZ4X5-kb1g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5351F107ACC7; Fri, 12 Feb 2021 16:13:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B568B50A8B; Fri, 12 Feb 2021 16:13:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EFB8218095CB; Fri, 12 Feb 2021 16:13:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 11CGDCIL031671 for ; Fri, 12 Feb 2021 11:13:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2588060C17; Fri, 12 Feb 2021 16:13:12 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0204360BF1; Fri, 12 Feb 2021 16:13:05 +0000 (UTC) Date: Fri, 12 Feb 2021 11:13:05 -0500 From: Mike Snitzer To: Sergei Shtepa Message-ID: <20210212161305.GB19424@redhat.com> References: <1612881028-7878-1-git-send-email-sergei.shtepa@veeam.com> <1612881028-7878-5-git-send-email-sergei.shtepa@veeam.com> MIME-Version: 1.0 In-Reply-To: <1612881028-7878-5-git-send-email-sergei.shtepa@veeam.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: dm-devel@redhat.com Cc: axboe@kernel.dk, Damien.LeMoal@wdc.com, pavel.tide@veeam.com, jack@suse.cz, corbet@lwn.net, johannes.thumshirn@wdc.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, ming.lei@redhat.com, linux-block@vger.kernel.org, dm-devel@redhat.com, gregkh@linuxfoundation.org, steve@sk2.org, koct9i@gmail.com, agk@redhat.com Subject: Re: [dm-devel] [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa wrote: > New ioctl DM_DEV_REMAP_CMD allow to remap bio requests > from regular block device to dm device. I really dislike the (ab)use of "REMAP" for this. DM is and always has been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD Similarly, all places documenting "remap" or variables with "remap" changed to "interpose". Also, any chance you'd be open to putting all these interposer specific changes in dm-interposer.[ch] ? (the various internal structs for DM core _should_ be available via dm-core.h) Mike -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel