From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD90C433E0 for ; Fri, 12 Feb 2021 17:23:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFC064E56 for ; Fri, 12 Feb 2021 17:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhBLRXR (ORCPT ); Fri, 12 Feb 2021 12:23:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:43636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbhBLRXJ (ORCPT ); Fri, 12 Feb 2021 12:23:09 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3912064E42; Fri, 12 Feb 2021 17:22:27 +0000 (UTC) Date: Fri, 12 Feb 2021 17:22:24 +0000 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi Subject: Re: [PATCH v13 7/7] kasan: don't run tests in async mode Message-ID: <20210212172224.GF7718@arm.com> References: <20210211153353.29094-1-vincenzo.frascino@arm.com> <20210211153353.29094-8-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210211153353.29094-8-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 03:33:53PM +0000, Vincenzo Frascino wrote: > From: Andrey Konovalov > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be > detected immediately and causes tests to fail. Forbid running them > in asynchronous mode. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > --- > lib/test_kasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index f8c72d3aed64..77a60592d350 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > kunit_err(test, "can't run KASAN tests with KASAN disabled"); > return -1; > } > + if (kasan_flag_async) { > + kunit_err(test, "can't run KASAN tests in async mode"); > + return -1; > + } I think we have time to fix this properly ;), so I'd rather not add this patch at all. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D90C433E0 for ; Fri, 12 Feb 2021 17:23:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FA4764D79 for ; Fri, 12 Feb 2021 17:23:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FA4764D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gh+CsoYEhoVbYi11IRYM6upNrzThNGM7qsoeNsi76fo=; b=Na/mpDHbD6KFN2RHRpvYjnv0Q 81KaJmRZ1QyJj4o7ho+L9Dmecq8MQPL8NeZ7Xz31xjdLx/HQ3QkDf+KVvMo4lwyq0kfXT73cyBkv+ giAu7xfwHrX9qOP+KAm6uT6S7pH7oPLH21KPyri18wvH35fkFH/8jlKdBU3emt+4sEYoGOFFRBUEv 5ObnGfLhjnUZqIEc1Y9vFjQijKNOa/ypuLCC+5gFS+GZLFFvq6I5OK/FHFF2VJmFiOqsPkpzvxZRe SGK7yaX+t8cFySqVByZqc/+/8pvk41wULjLoT32eaouNqSqwqJ1m5v5FTTXua+nLu3g2De48l6IUs JITQQJMaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAc9I-0007jW-O0; Fri, 12 Feb 2021 17:22:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAc9G-0007in-75 for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 17:22:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3912064E42; Fri, 12 Feb 2021 17:22:27 +0000 (UTC) Date: Fri, 12 Feb 2021 17:22:24 +0000 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v13 7/7] kasan: don't run tests in async mode Message-ID: <20210212172224.GF7718@arm.com> References: <20210211153353.29094-1-vincenzo.frascino@arm.com> <20210211153353.29094-8-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210211153353.29094-8-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_122230_341813_15A9E855 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Lorenzo Pieralisi , Andrey Konovalov , Evgenii Stepanov , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Andrey Ryabinin , Andrew Morton , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 03:33:53PM +0000, Vincenzo Frascino wrote: > From: Andrey Konovalov > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be > detected immediately and causes tests to fail. Forbid running them > in asynchronous mode. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > --- > lib/test_kasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index f8c72d3aed64..77a60592d350 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > kunit_err(test, "can't run KASAN tests with KASAN disabled"); > return -1; > } > + if (kasan_flag_async) { > + kunit_err(test, "can't run KASAN tests in async mode"); > + return -1; > + } I think we have time to fix this properly ;), so I'd rather not add this patch at all. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel