Hi Bjarni,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Bjarni-Jonasson/net-phy-mscc-adding-LCPLL-reset-to-VSC8514/20210212-221024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 308daa19e2d0321ff8b037ea192c48358f9324f5
config: x86_64-randconfig-a014-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/fd70d86ef38269af43b612e70cc5edbf06b58db1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bjarni-Jonasson/net-phy-mscc-adding-LCPLL-reset-to-VSC8514/20210212-221024
        git checkout fd70d86ef38269af43b612e70cc5edbf06b58db1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:420:2: error: redefinition of enumerator 'FC_BUFFER'
           FC_BUFFER   = 0x04,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:64:2: note: previous definition is here
           FC_BUFFER   = 0x04,
           ^
   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:421:2: error: redefinition of enumerator 'HOST_MAC'
           HOST_MAC    = 0x05,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:65:2: note: previous definition is here
           HOST_MAC    = 0x05,
           ^
   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:422:2: error: redefinition of enumerator 'LINE_MAC'
           LINE_MAC    = 0x06,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:66:2: note: previous definition is here
           LINE_MAC    = 0x06,
           ^
   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:430:2: error: redefinition of enumerator 'PROC_0'
           PROC_0      = 0x0E,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:67:2: note: previous definition is here
           PROC_0      = 0x0e,
           ^
   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:431:2: error: redefinition of enumerator 'PROC_2'
           PROC_2      = 0x0F,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:68:2: note: previous definition is here
           PROC_2      = 0x0f,
           ^
   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:432:2: error: redefinition of enumerator 'MACSEC_INGR'
           MACSEC_INGR = 0x38,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:69:2: note: previous definition is here
           MACSEC_INGR = 0x38,
           ^
   In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:433:2: error: redefinition of enumerator 'MACSEC_EGR'
           MACSEC_EGR  = 0x3C,
           ^
   drivers/net/phy/mscc/mscc_macsec.h:70:2: note: previous definition is here
           MACSEC_EGR  = 0x3c,
           ^
   7 errors generated.


vim +/FC_BUFFER +420 drivers/net/phy/mscc/mscc.h

   418	
   419	enum csr_target {
 > 420		FC_BUFFER   = 0x04,
 > 421		HOST_MAC    = 0x05,
 > 422		LINE_MAC    = 0x06,
   423		MACRO_CTRL  = 0x07,
   424		ANA0_INGR   = 0x08,
   425		ANA0_EGR    = 0x09,
   426		ANA1_INGR   = 0x0A,
   427		ANA1_EGR    = 0x0B,
   428		ANA2_INGR   = 0x0C,
   429		ANA2_EGR    = 0x0D,
 > 430		PROC_0      = 0x0E,
 > 431		PROC_2      = 0x0F,
 > 432		MACSEC_INGR = 0x38,
 > 433		MACSEC_EGR  = 0x3C,
   434		SPI_IO      = 0x40,
   435	};
   436	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org