All of lore.kernel.org
 help / color / mirror / Atom feed
From: 胡玮文 <sehuww@mail.scut.edu.cn>
To: Gao Xiang <hsiangkao@aol.com>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v3] erofs-utils: fuse: fix random readlink error
Date: Sat, 13 Feb 2021 22:36:36 +0800	[thread overview]
Message-ID: <20210213143636.GA783545@laptop> (raw)
In-Reply-To: <20210209193845.GA13059@hsiangkao-HP-ZHAN-66-Pro-G1>

On Wed, Feb 10, 2021 at 03:38:50AM +0800, Gao Xiang wrote:

...

> From bfbd8ee056aca57a77034b8723f3f828f806747b Mon Sep 17 00:00:00 2001
> From: Hu Weiwen <sehuww@mail.scut.edu.cn>
> Date: Sat, 30 Jan 2021 02:07:47 +0800
> Subject: [PATCH v3] erofs-utils: fuse: fix random readlink error
> 
> readlink should fill a **null-terminated** string in the buffer [1].
> 
> To achieve this:
> 1) memset(0) for unmapped extents;
> 2) make erofsfuse_read() properly returning the actual bytes read;
> 3) insert a null character if the path is truncated.
> 
> [1] https://lore.kernel.org/r/20210121101233.GC6680@DESKTOP-N4CECTO.huww98.cn
> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
> Signed-off-by: Gao Xiang <hsiangkao@aol.com>

It looks good. I've run this patched version against previously failing tests.

Also now I understand the purpose of erofs_map_blocks_flatmode() better.

Thanks,
Hu Weiwen


  reply	other threads:[~2021-02-13 14:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 10:12 fuse returns ENOENT to openat() for symlink probabilistically 胡玮文
2021-01-21 11:27 ` Gao Xiang
2021-01-21 16:31   ` [PATCH] erofs-utils: fuse: fix random readlink error Hu Weiwen
2021-01-22  0:34     ` Gao Xiang
2021-01-22  1:00       ` 胡玮文
2021-01-22  1:49         ` Gao Xiang
2021-01-23 13:18           ` 胡玮文
2021-01-23 15:22             ` Gao Xiang
2021-01-23 15:36               ` Gao Xiang
2021-01-29 18:07               ` [PATCH v2] " Hu Weiwen
2021-02-09 19:38                 ` Gao Xiang via Linux-erofs
2021-02-13 14:36                   ` 胡玮文 [this message]
2021-02-28 13:30                   ` Li GuiFu via Linux-erofs
2021-02-28 13:53                   ` [PATCH v4] " Gao Xiang via Linux-erofs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210213143636.GA783545@laptop \
    --to=sehuww@mail.scut.edu.cn \
    --cc=hsiangkao@aol.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.