From: Vladimir Oltean <olteanv@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
George McCollister <george.mccollister@gmail.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
DENG Qingfang <dqfext@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hauke Mehrtens <hauke@hauke-m.de>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Oleksij Rempel <linux@rempel-privat.de>
Subject: [PATCH net-next 0/4] Software fallback for bridging in DSA
Date: Sun, 14 Feb 2021 17:53:22 +0200 [thread overview]
Message-ID: <20210214155326.1783266-1-olteanv@gmail.com> (raw)
From: Vladimir Oltean <vladimir.oltean@nxp.com>
As was discussed here:
https://patchwork.kernel.org/project/netdevbpf/patch/20201202091356.24075-3-tobias@waldekranz.com/
it is desirable to not reject a LAG interface (bonding, team) even if
the switch isn't able to offload bridging towards that link aggregation
group. At least the DSA setups I have are not that unbalanced between
the horsepower of the CPU and the horsepower of the switch such that
software forwarding to be completely impractical.
This series makes all switch drivers theoretically able to do the right
thing when they are configured in a way similar to this (credits to
Tobias Waldekranz for the drawing):
br0
/ \
team0 \
/ \ \
swp0 swp1 swp2
although in practice there is one more prerequisite: for software
fallback mode, they need to disable address learning. It is preferable
that they do this by implementing the .port_pre_bridge_join and
.port_bridge_join methods.
Vladimir Oltean (4):
net: dsa: don't offload switchdev objects on ports that don't offload
the bridge
net: dsa: reject switchdev objects centrally from
dsa_slave_port_obj_{add,del}
net: dsa: return -EOPNOTSUPP if .port_lag_join is not implemented
net: dsa: don't set skb->offload_fwd_mark when not offloading the
bridge
net/dsa/dsa_priv.h | 16 ++++++++++++++++
net/dsa/slave.c | 21 +++++++++++----------
net/dsa/switch.c | 13 ++++++++++---
net/dsa/tag_brcm.c | 2 +-
net/dsa/tag_dsa.c | 9 +++++----
net/dsa/tag_hellcreek.c | 2 +-
net/dsa/tag_ksz.c | 2 +-
net/dsa/tag_lan9303.c | 4 +++-
net/dsa/tag_mtk.c | 2 +-
net/dsa/tag_ocelot.c | 2 +-
net/dsa/tag_ocelot_8021q.c | 2 +-
net/dsa/tag_rtl4_a.c | 2 +-
net/dsa/tag_sja1105.c | 4 ++--
net/dsa/tag_xrs700x.c | 3 +--
14 files changed, 55 insertions(+), 29 deletions(-)
--
2.25.1
next reply other threads:[~2021-02-14 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 15:53 Vladimir Oltean [this message]
2021-02-14 15:53 ` [PATCH net-next 1/4] net: dsa: don't offload switchdev objects on ports that don't offload the bridge Vladimir Oltean
2021-02-25 19:23 ` Tobias Waldekranz
2021-02-14 15:53 ` [PATCH net-next 2/4] net: dsa: reject switchdev objects centrally from dsa_slave_port_obj_{add,del} Vladimir Oltean
2021-02-25 19:24 ` Tobias Waldekranz
2021-02-14 15:53 ` [PATCH net-next 3/4] net: dsa: return -EOPNOTSUPP if .port_lag_join is not implemented Vladimir Oltean
2021-02-25 19:24 ` Tobias Waldekranz
2021-02-14 15:53 ` [PATCH net-next 4/4] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge Vladimir Oltean
2021-02-15 15:48 ` George McCollister
2021-02-15 17:19 ` Vladimir Oltean
2021-02-25 19:25 ` Tobias Waldekranz
2021-02-26 18:14 ` Vladimir Oltean
2021-02-14 16:28 ` [PATCH net-next 0/4] Software fallback for bridging in DSA Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214155326.1783266-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=sean.wang@mediatek.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.