From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFFE0C433DB for ; Mon, 15 Feb 2021 06:02:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89C8B64E68 for ; Mon, 15 Feb 2021 06:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229616AbhBOGCx (ORCPT ); Mon, 15 Feb 2021 01:02:53 -0500 Received: from mail-eopbgr80049.outbound.protection.outlook.com ([40.107.8.49]:64580 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229569AbhBOGCx (ORCPT ); Mon, 15 Feb 2021 01:02:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S3aQ9GKOyCOxAKKaePrFUjkLnUo2FAOoIEsU1LiPwyb0bGBsQ2Iqpjpgl7gUAv7CQM3gY1pmrx+/Np0xB/tIBFYZVhZqqn88O5yEIOIn2gPD3bdwROKeUN1eopjWURVeQ7EwHVKE2SqJaieCcMWJ23SBROyL/rdy6yUo0NVXBsn96LIfYNBAYygVND31jExA84lVozlWUXwkYdP/o8QhFcQIaNntVKyewNf2VeiVePGpLwHv1r5Im5qP89upgFqjatgeFYyfFjhmsVvttrG3aAZ+S98AZA+GDkc+NC3T94hYbM673kXBjyDRcT+RREUWSsodhr0sKssxJRe+oosayQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gt0ZHm4qI06up/RdJ9rfzS2K5ODNGkSd6b2kj90ZkTU=; b=nQbh9BnCSUD4xS9mrRbOw4OzWf35Bxy/Ee0YesQ7B3wc8+Md/1v6Se4ZXUGHNrM/SimFIlxBuoLO9heq+yDosf9ZEnO8QUdn4MunvryXoc031pOxgqm/vd54mtz4PfSmS/oCWCo4UrxNKDnjHqaUiD76Wj9Hmn3aYAU2tr7rLq61fwozQd9CRoO06h7+9QEYItXBzfMzEkJmuUxlaNE75ZPBJ/I2Lb6CaJZTKu24SLiSQZtoycpJIMyObWc+amQcwLJewqEPVYzVTgP+o1erndRhnblv1k33gXqlQ5M6IRsgIddXxleZCAy02jLMWE7B28KZkOEtu4QDCMwB4gMF4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gt0ZHm4qI06up/RdJ9rfzS2K5ODNGkSd6b2kj90ZkTU=; b=T+YBvb2U9yzW+GVb/2ZM84aSsP+aOrWrV/RMyJAMXlwF6rA8PC+lXJG9ueCXA412ascmrrv4HnAMFxrmBTPrtGWzaVFYVqeqECoraO4L7jTJ5pnlS9j6rYHZZlBctQDIAutH/VN9ulM7LdUR5iXA34Rnyqto0xwOdngbFcKLA6c= Authentication-Results: armlinux.org.uk; dkim=none (message not signed) header.d=none;armlinux.org.uk; dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5636.eurprd04.prod.outlook.com (2603:10a6:208:130::22) by AM0PR04MB3953.eurprd04.prod.outlook.com (2603:10a6:208:5b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.26; Mon, 15 Feb 2021 06:02:03 +0000 Received: from AM0PR04MB5636.eurprd04.prod.outlook.com ([fe80::e90e:b1d6:18a2:2d42]) by AM0PR04MB5636.eurprd04.prod.outlook.com ([fe80::e90e:b1d6:18a2:2d42%6]) with mapi id 15.20.3846.042; Mon, 15 Feb 2021 06:02:03 +0000 Date: Mon, 15 Feb 2021 11:31:42 +0530 From: Calvin Johnson To: Russell King - ARM Linux admin Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Andy Shevchenko , Florian Fainelli , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Laurentiu Tudor , linux-kernel@vger.kernel.org, linux.cj@gmail.com, Diana Madalina Craciun , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, "David S. Miller" , Heiner Kallweit , Jakub Kicinski Subject: Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() Message-ID: <20210215060142.GA21977@lsv03152.swis.in-blr01.nxp.com> References: <20210208151244.16338-1-calvin.johnson@oss.nxp.com> <20210208151244.16338-14-calvin.johnson@oss.nxp.com> <20210208153111.GK1463@shell.armlinux.org.uk> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208153111.GK1463@shell.armlinux.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [14.142.151.118] X-ClientProxiedBy: SG2PR01CA0132.apcprd01.prod.exchangelabs.com (2603:1096:4:40::36) To AM0PR04MB5636.eurprd04.prod.outlook.com (2603:10a6:208:130::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv03152.swis.in-blr01.nxp.com (14.142.151.118) by SG2PR01CA0132.apcprd01.prod.exchangelabs.com (2603:1096:4:40::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Mon, 15 Feb 2021 06:01:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6fd2010a-b121-4446-3074-08d8d177377f X-MS-TrafficTypeDiagnostic: AM0PR04MB3953: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1751; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GVvqvKKqVywAN1sbXTB2uhbhZWEGdpXHeTwVZ8uQbBBJATGNSSY0UbWoY/fjo3HvkODHMTZ6WkgLTsPJCqwpCV7bVLBWmnBgdpiYw1Wdw03k7jOD47rd94m8LBNK3j4roti+QCzcTz+r4GWvf+p3jWPGIz4GFk6sPy3ejj4mKQW/YbV3KmbX5orv72VXb5WZ1ZPVNJgy1+Qdx4XKjBFRRiLE+nFh8xVm5u9qT1xOBf9BuNXKrEZoMB5EXvz1tZq+alUuUGwoIPHPbd19arV6rmjz/3g19wzo4P4vBJ5ekdJTTXbJ26JZP8bNTTJ6RmtrKIngA7lH117fVG4kmcAQkmBnghs+WqiXrXxyFVaBWNH9sBHT+tjPORTJh4Cw15Q34xNywndXYKhvqZoBoA5F42ywXAbJ+44iHZsFY3go8ZsrugH3DFe6Sh24jz8oOj3XYR2afcftyGEYk1XtneGuVBLcx+ifFujDnp90QPuK2doHkzaiFi7XV4TSiZgWchj9C8ShRkAYW5ZW+sERNN+rfLMLAayINUNZixtnnxFjjhFP9vseoAaE9LBe9LAe4N9l X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5636.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(33656002)(83380400001)(4326008)(54906003)(2906002)(55236004)(8936002)(55016002)(956004)(86362001)(6506007)(9686003)(316002)(16526019)(26005)(186003)(66476007)(66946007)(6916009)(7416002)(478600001)(66556008)(7696005)(6666004)(52116002)(44832011)(1006002)(1076003)(8676002)(5660300002)(110426009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?iVW0A35bTumNExxwm5qtZeA5MBqxLA0NGjBBRgoQu3rd68HqSARSOMV40eMq?= =?us-ascii?Q?TPyzwg7sca0b3Yxkgk6JLjFDhG4QrCdohLg2ZK/uYpwLqtYUHpDyGq0POebd?= =?us-ascii?Q?783djvtE7rrUL//F2bHEiejS9/fTtJUUoHnoUCb76R11CjeQ5D7njcDU9ken?= =?us-ascii?Q?Z5Wp39lUaWwG+PnDR4pTKWAJNyCB6HUfZYKj2WgiFSHUhyLU17z4KF+gmUZP?= =?us-ascii?Q?IkcwyMK08/NIX+8lkz7HPVx3+H9n4IromyLNXf5bPrDZMb924QPL/yELzicJ?= =?us-ascii?Q?7PsNAnIKOOZXKv5pu5/KyRgSNNQ6v15zO/9yrK6fQfgxfntKHWcdBJwBAPnu?= =?us-ascii?Q?B/XcXgZ6iQL9IdmIOxlZP1XwTM9jIu+Cjy1hHUrCD+hFsdGfNU+kbTGpCEl3?= =?us-ascii?Q?SyCtvEFSTUVKZwhMdN8YWFp7AUFW9C1E4wTdvu/4giSp/aKzTBLUwqUu1nAj?= =?us-ascii?Q?BPdWTJTHTwnksmCfxBtxHA+cHpG3nk2uc3Zz8ga0y2RZYpd7qV8TxFwrFM7c?= =?us-ascii?Q?7esvdoPS7wNhhgoGp/OxGmueOHgwDeuRTNXCjcfIgtUU9VPTA7nm+QzdJafY?= =?us-ascii?Q?223WCJXNd0HoPkcSOD0rFI9EfbLUIWtALKRONbhPXeEZWHcFE7sKzjMafU4P?= =?us-ascii?Q?grziIijiwY0TBMLX6/Argk0dL30IliyBAteY8Dsj3GiRriGLSU+idGqYCzN4?= =?us-ascii?Q?ueC+Xt2nJ/AE+P6FAt74p6+AuVFpkvneEggkDCNeE3xzaNAELclbnxQXf56R?= =?us-ascii?Q?MSiui9oq6/NuYVZrmOr6q8iuKnyRtmHyVyHBzKS7HHSh3eR+Hn4icq9ed1xs?= =?us-ascii?Q?ULZcoHi2of5uhi7vvwQtvoLIEws0PEWhuP4+/frhVFUw623SxcXp8pd74ffY?= =?us-ascii?Q?W3K1W7/q6zEBmZvgUwTt4txALgVRV4m8YYeA5FMPDUoC2HPLi4tPKc3MpxQO?= =?us-ascii?Q?YkfBI7z4yb1Mevnot3dOow06ZxTX6zmRKVmICTa2DViqsbEAwFdJMYNy+vE+?= =?us-ascii?Q?P8KTMQwYCKJ8b+/l0w/T1x2RUmdWm7qSZsPq2hdDdkrTyZ/R6y4ro3lPWUoP?= =?us-ascii?Q?Fx+ZtEkiC5zbjciX33wr4hse+pEMXY3Xhca6CsunEDLemnTr72Oy+y+iePA7?= =?us-ascii?Q?S/7f6UP3OedNlh47yhI63Z+QdXXKWYlJRe+idDej47BKGggxM9sTo7edMGZL?= =?us-ascii?Q?4jii1YTM7SiDHwtxsQcwagRXybPYEoxQT/p1KSVNl35XhE2WcWJufQsE37K7?= =?us-ascii?Q?7gA/QnhorUtSz09jNU2q8s+Z1gTW/SMW0Tdd8wDBn+cfXAQSnz+TnbFn+3BB?= =?us-ascii?Q?zptVyc5/ZDrLxG8UiORGt82OqF+0cGuRW0gGar197Ky9sQ=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd2010a-b121-4446-3074-08d8d177377f X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5636.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2021 06:02:03.7829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A0X/i7LfB4i7qu0WS/NcrUQRlEvSAfWzWYYtj4o/bDNWLOvAPex9P6bxsfFpoNBB4cWOVEkS6dLinE4soR/gbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB3953 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 08, 2021 at 03:31:11PM +0000, Russell King - ARM Linux admin wrote: > On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > > +int phylink_fwnode_phy_connect(struct phylink *pl, > > + struct fwnode_handle *fwnode, > > + u32 flags) > > +{ > > + struct fwnode_handle *phy_fwnode; > > + struct phy_device *phy_dev; > > + int ret; > > + > > + if (is_of_node(fwnode)) { > > + /* Fixed links and 802.3z are handled without needing a PHY */ > > + if (pl->cfg_link_an_mode == MLO_AN_FIXED || > > + (pl->cfg_link_an_mode == MLO_AN_INBAND && > > + phy_interface_mode_is_8023z(pl->link_interface))) > > + return 0; > > This difference between ACPI and DT really needs to be described in the > commit description. > > For example, why is it acceptable to have a PHY in fixed-link mode if > we're using ACPI, and not DT? > > If we look at the phylink code, accepting a PHY when in fixed-link mode > is basically not supported... so why should ACPI allow this? DT and ACPI should handle fixed-link in similar manner. I'll remove the OF check. Thanks Calvin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D32C433DB for ; Mon, 15 Feb 2021 06:03:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7169664DF0 for ; Mon, 15 Feb 2021 06:03:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7169664DF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PJxu1J3jc3oV+EQqFFed+cCxoJ6sCbFZC365h7i6inI=; b=moCiXB6XUZm1IWCtVk0xwnlbK Abpohwm7SysIdHHY1fTvAOu3eKSp1FucOrShUHNc3Nz9nGIEEgVv/aDI3ITdLv2+Jo7DwuRMgz1QC ntzww+w1DSqdxD9FWt6lP9Z6jwoEVZw4oWuZC43/Z28YFLB/3S3kH+ycYNXIQzWdfnLexIx19vpMY fql2DbLVd+TGPY+dGmX0YZIR8Brn03CW6cpM6hVvJ2a4QcFiTxDJLNO3YIqtsXpiyx5GcMYuwB2EO 8gLn9zHv3fCl0kzbQ5wlrpl+MJkIHGIPd33zYZNa1e6Grsn9Obs17oCKmnBnoNO9LoX/jj34FPHkB Jp8Yd7Qiw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBWxW-0005gv-8A; Mon, 15 Feb 2021 06:02:10 +0000 Received: from mail-eopbgr80043.outbound.protection.outlook.com ([40.107.8.43] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBWxT-0005fu-7G for linux-arm-kernel@lists.infradead.org; Mon, 15 Feb 2021 06:02:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S3aQ9GKOyCOxAKKaePrFUjkLnUo2FAOoIEsU1LiPwyb0bGBsQ2Iqpjpgl7gUAv7CQM3gY1pmrx+/Np0xB/tIBFYZVhZqqn88O5yEIOIn2gPD3bdwROKeUN1eopjWURVeQ7EwHVKE2SqJaieCcMWJ23SBROyL/rdy6yUo0NVXBsn96LIfYNBAYygVND31jExA84lVozlWUXwkYdP/o8QhFcQIaNntVKyewNf2VeiVePGpLwHv1r5Im5qP89upgFqjatgeFYyfFjhmsVvttrG3aAZ+S98AZA+GDkc+NC3T94hYbM673kXBjyDRcT+RREUWSsodhr0sKssxJRe+oosayQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gt0ZHm4qI06up/RdJ9rfzS2K5ODNGkSd6b2kj90ZkTU=; b=nQbh9BnCSUD4xS9mrRbOw4OzWf35Bxy/Ee0YesQ7B3wc8+Md/1v6Se4ZXUGHNrM/SimFIlxBuoLO9heq+yDosf9ZEnO8QUdn4MunvryXoc031pOxgqm/vd54mtz4PfSmS/oCWCo4UrxNKDnjHqaUiD76Wj9Hmn3aYAU2tr7rLq61fwozQd9CRoO06h7+9QEYItXBzfMzEkJmuUxlaNE75ZPBJ/I2Lb6CaJZTKu24SLiSQZtoycpJIMyObWc+amQcwLJewqEPVYzVTgP+o1erndRhnblv1k33gXqlQ5M6IRsgIddXxleZCAy02jLMWE7B28KZkOEtu4QDCMwB4gMF4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gt0ZHm4qI06up/RdJ9rfzS2K5ODNGkSd6b2kj90ZkTU=; b=T+YBvb2U9yzW+GVb/2ZM84aSsP+aOrWrV/RMyJAMXlwF6rA8PC+lXJG9ueCXA412ascmrrv4HnAMFxrmBTPrtGWzaVFYVqeqECoraO4L7jTJ5pnlS9j6rYHZZlBctQDIAutH/VN9ulM7LdUR5iXA34Rnyqto0xwOdngbFcKLA6c= Authentication-Results: armlinux.org.uk; dkim=none (message not signed) header.d=none;armlinux.org.uk; dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5636.eurprd04.prod.outlook.com (2603:10a6:208:130::22) by AM0PR04MB3953.eurprd04.prod.outlook.com (2603:10a6:208:5b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.26; Mon, 15 Feb 2021 06:02:03 +0000 Received: from AM0PR04MB5636.eurprd04.prod.outlook.com ([fe80::e90e:b1d6:18a2:2d42]) by AM0PR04MB5636.eurprd04.prod.outlook.com ([fe80::e90e:b1d6:18a2:2d42%6]) with mapi id 15.20.3846.042; Mon, 15 Feb 2021 06:02:03 +0000 Date: Mon, 15 Feb 2021 11:31:42 +0530 From: Calvin Johnson To: Russell King - ARM Linux admin Subject: Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() Message-ID: <20210215060142.GA21977@lsv03152.swis.in-blr01.nxp.com> References: <20210208151244.16338-1-calvin.johnson@oss.nxp.com> <20210208151244.16338-14-calvin.johnson@oss.nxp.com> <20210208153111.GK1463@shell.armlinux.org.uk> Content-Disposition: inline In-Reply-To: <20210208153111.GK1463@shell.armlinux.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [14.142.151.118] X-ClientProxiedBy: SG2PR01CA0132.apcprd01.prod.exchangelabs.com (2603:1096:4:40::36) To AM0PR04MB5636.eurprd04.prod.outlook.com (2603:10a6:208:130::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv03152.swis.in-blr01.nxp.com (14.142.151.118) by SG2PR01CA0132.apcprd01.prod.exchangelabs.com (2603:1096:4:40::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Mon, 15 Feb 2021 06:01:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6fd2010a-b121-4446-3074-08d8d177377f X-MS-TrafficTypeDiagnostic: AM0PR04MB3953: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1751; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GVvqvKKqVywAN1sbXTB2uhbhZWEGdpXHeTwVZ8uQbBBJATGNSSY0UbWoY/fjo3HvkODHMTZ6WkgLTsPJCqwpCV7bVLBWmnBgdpiYw1Wdw03k7jOD47rd94m8LBNK3j4roti+QCzcTz+r4GWvf+p3jWPGIz4GFk6sPy3ejj4mKQW/YbV3KmbX5orv72VXb5WZ1ZPVNJgy1+Qdx4XKjBFRRiLE+nFh8xVm5u9qT1xOBf9BuNXKrEZoMB5EXvz1tZq+alUuUGwoIPHPbd19arV6rmjz/3g19wzo4P4vBJ5ekdJTTXbJ26JZP8bNTTJ6RmtrKIngA7lH117fVG4kmcAQkmBnghs+WqiXrXxyFVaBWNH9sBHT+tjPORTJh4Cw15Q34xNywndXYKhvqZoBoA5F42ywXAbJ+44iHZsFY3go8ZsrugH3DFe6Sh24jz8oOj3XYR2afcftyGEYk1XtneGuVBLcx+ifFujDnp90QPuK2doHkzaiFi7XV4TSiZgWchj9C8ShRkAYW5ZW+sERNN+rfLMLAayINUNZixtnnxFjjhFP9vseoAaE9LBe9LAe4N9l X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB5636.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(33656002)(83380400001)(4326008)(54906003)(2906002)(55236004)(8936002)(55016002)(956004)(86362001)(6506007)(9686003)(316002)(16526019)(26005)(186003)(66476007)(66946007)(6916009)(7416002)(478600001)(66556008)(7696005)(6666004)(52116002)(44832011)(1006002)(1076003)(8676002)(5660300002)(110426009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?iVW0A35bTumNExxwm5qtZeA5MBqxLA0NGjBBRgoQu3rd68HqSARSOMV40eMq?= =?us-ascii?Q?TPyzwg7sca0b3Yxkgk6JLjFDhG4QrCdohLg2ZK/uYpwLqtYUHpDyGq0POebd?= =?us-ascii?Q?783djvtE7rrUL//F2bHEiejS9/fTtJUUoHnoUCb76R11CjeQ5D7njcDU9ken?= =?us-ascii?Q?Z5Wp39lUaWwG+PnDR4pTKWAJNyCB6HUfZYKj2WgiFSHUhyLU17z4KF+gmUZP?= =?us-ascii?Q?IkcwyMK08/NIX+8lkz7HPVx3+H9n4IromyLNXf5bPrDZMb924QPL/yELzicJ?= =?us-ascii?Q?7PsNAnIKOOZXKv5pu5/KyRgSNNQ6v15zO/9yrK6fQfgxfntKHWcdBJwBAPnu?= =?us-ascii?Q?B/XcXgZ6iQL9IdmIOxlZP1XwTM9jIu+Cjy1hHUrCD+hFsdGfNU+kbTGpCEl3?= =?us-ascii?Q?SyCtvEFSTUVKZwhMdN8YWFp7AUFW9C1E4wTdvu/4giSp/aKzTBLUwqUu1nAj?= =?us-ascii?Q?BPdWTJTHTwnksmCfxBtxHA+cHpG3nk2uc3Zz8ga0y2RZYpd7qV8TxFwrFM7c?= =?us-ascii?Q?7esvdoPS7wNhhgoGp/OxGmueOHgwDeuRTNXCjcfIgtUU9VPTA7nm+QzdJafY?= =?us-ascii?Q?223WCJXNd0HoPkcSOD0rFI9EfbLUIWtALKRONbhPXeEZWHcFE7sKzjMafU4P?= =?us-ascii?Q?grziIijiwY0TBMLX6/Argk0dL30IliyBAteY8Dsj3GiRriGLSU+idGqYCzN4?= =?us-ascii?Q?ueC+Xt2nJ/AE+P6FAt74p6+AuVFpkvneEggkDCNeE3xzaNAELclbnxQXf56R?= =?us-ascii?Q?MSiui9oq6/NuYVZrmOr6q8iuKnyRtmHyVyHBzKS7HHSh3eR+Hn4icq9ed1xs?= =?us-ascii?Q?ULZcoHi2of5uhi7vvwQtvoLIEws0PEWhuP4+/frhVFUw623SxcXp8pd74ffY?= =?us-ascii?Q?W3K1W7/q6zEBmZvgUwTt4txALgVRV4m8YYeA5FMPDUoC2HPLi4tPKc3MpxQO?= =?us-ascii?Q?YkfBI7z4yb1Mevnot3dOow06ZxTX6zmRKVmICTa2DViqsbEAwFdJMYNy+vE+?= =?us-ascii?Q?P8KTMQwYCKJ8b+/l0w/T1x2RUmdWm7qSZsPq2hdDdkrTyZ/R6y4ro3lPWUoP?= =?us-ascii?Q?Fx+ZtEkiC5zbjciX33wr4hse+pEMXY3Xhca6CsunEDLemnTr72Oy+y+iePA7?= =?us-ascii?Q?S/7f6UP3OedNlh47yhI63Z+QdXXKWYlJRe+idDej47BKGggxM9sTo7edMGZL?= =?us-ascii?Q?4jii1YTM7SiDHwtxsQcwagRXybPYEoxQT/p1KSVNl35XhE2WcWJufQsE37K7?= =?us-ascii?Q?7gA/QnhorUtSz09jNU2q8s+Z1gTW/SMW0Tdd8wDBn+cfXAQSnz+TnbFn+3BB?= =?us-ascii?Q?zptVyc5/ZDrLxG8UiORGt82OqF+0cGuRW0gGar197Ky9sQ=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd2010a-b121-4446-3074-08d8d177377f X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5636.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2021 06:02:03.7829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A0X/i7LfB4i7qu0WS/NcrUQRlEvSAfWzWYYtj4o/bDNWLOvAPex9P6bxsfFpoNBB4cWOVEkS6dLinE4soR/gbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB3953 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210215_010207_448960_B5FDB1B2 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J . Wysocki" , Grant Likely , Ioana Ciornei , Florian Fainelli , Saravana Kannan , Jon , Diana Madalina Craciun , linux-acpi@vger.kernel.org, Andy Shevchenko , Jakub Kicinski , Florin Laurentiu Chiculita , Madalin Bucur , Pieter Jansen Van Vuuren , Marcin Wojtas , linux-arm-kernel@lists.infradead.org, Laurentiu Tudor , netdev@vger.kernel.org, Randy Dunlap , linux-kernel@vger.kernel.org, Jeremy Linton , Cristi Sovaiala , linux.cj@gmail.com, "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 03:31:11PM +0000, Russell King - ARM Linux admin wrote: > On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > > +int phylink_fwnode_phy_connect(struct phylink *pl, > > + struct fwnode_handle *fwnode, > > + u32 flags) > > +{ > > + struct fwnode_handle *phy_fwnode; > > + struct phy_device *phy_dev; > > + int ret; > > + > > + if (is_of_node(fwnode)) { > > + /* Fixed links and 802.3z are handled without needing a PHY */ > > + if (pl->cfg_link_an_mode == MLO_AN_FIXED || > > + (pl->cfg_link_an_mode == MLO_AN_INBAND && > > + phy_interface_mode_is_8023z(pl->link_interface))) > > + return 0; > > This difference between ACPI and DT really needs to be described in the > commit description. > > For example, why is it acceptable to have a PHY in fixed-link mode if > we're using ACPI, and not DT? > > If we look at the phylink code, accepting a PHY when in fixed-link mode > is basically not supported... so why should ACPI allow this? DT and ACPI should handle fixed-link in similar manner. I'll remove the OF check. Thanks Calvin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel