All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Alexandra Winter <wintera@linux.ibm.com>
Cc: David Ahern <dsahern@gmail.com>,
	netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
	DENG Qingfang <dqfext@gmail.com>,
	Tobias Waldekranz <tobias@waldekranz.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <nikolay@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add"
Date: Mon, 15 Feb 2021 14:13:42 +0200	[thread overview]
Message-ID: <20210215121342.driolhmaow7ads5g@skbuf> (raw)
In-Reply-To: <5530c6b8-4824-64da-f5a9-f8a790c46c3b@linux.ibm.com>

On Mon, Feb 15, 2021 at 11:53:42AM +0100, Alexandra Winter wrote:
> Actually, I found your first (more verbose) proposal more helpful.

Sorry, I don't understand. Do you want me to copy the whole explanation
from bridge fdb add to bridge link set?

> >> Maybe I misunderstand this sentence, but I can do a 'bridge fdb add' without 'self'
> >> on the bridge device. And the address shows up under 'bridge fdb show'.
> >> So what does mandatory mean here?
> >
> > It's right in the next sentence:
> >
> >> The flag is set by default if "master" is not specified.
> >
> > It's mandatory and implicit if "master" is not specified, ergo 'bridge
> > fdb add dev br0' will work because 'master' is not specified (it is
> > implicitly 'bridge fdb add dev br0 self'. But 'bridge fdb add dev br0
> > master' will fail, because the 'self' flag is no longer implicit (since
> > 'master' was specified) but mandatory and absent.
> >
> > I'm not sure what I can do to improve this.
> >
> Maybe the sentence under 'master':
> " If the specified
> +device is a master itself, such as a bridge, this flag is invalid."
> is sufficient to defien this situation. And no need to explain mandatory implicit defaults
> in the first paragraph?

I don't understand this either. Could you paste here how you think this
paragraph should read?

  reply	other threads:[~2021-02-15 12:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 10:44 [PATCH iproute2 0/6] Clarifications to bridge man page Vladimir Oltean
2021-02-11 10:44 ` [PATCH iproute2 1/6] man8/bridge.8: document the "permanent" flag for "bridge fdb add" Vladimir Oltean
2021-02-11 10:44 ` [PATCH iproute2 2/6] man8/bridge.8: document that "local" is default " Vladimir Oltean
2021-02-11 10:44 ` [PATCH iproute2 3/6] man8/bridge.8: explain what a local FDB entry is Vladimir Oltean
2021-02-11 10:45 ` [PATCH iproute2 4/6] man8/bridge.8: fix which one of self/master is default for "bridge fdb" Vladimir Oltean
2021-02-11 10:45 ` [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add" Vladimir Oltean
2021-02-15  8:22   ` Alexandra Winter
2021-02-15 10:32     ` Vladimir Oltean
2021-02-15 10:53       ` Alexandra Winter
2021-02-15 12:13         ` Vladimir Oltean [this message]
2021-02-15 12:33           ` Alexandra Winter
2021-02-11 10:45 ` [PATCH iproute2 6/6] man8/bridge.8: be explicit that "flood" is an egress setting Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210215121342.driolhmaow7ads5g@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=dqfext@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@idosch.org \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=tobias@waldekranz.com \
    --cc=vivien.didelot@gmail.com \
    --cc=wintera@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.