From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D08C433E0 for ; Mon, 15 Feb 2021 13:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C6564E40 for ; Mon, 15 Feb 2021 13:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230384AbhBON6r (ORCPT ); Mon, 15 Feb 2021 08:58:47 -0500 Received: from mga12.intel.com ([192.55.52.136]:54240 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230142AbhBON6m (ORCPT ); Mon, 15 Feb 2021 08:58:42 -0500 IronPort-SDR: gkRB5Bnv847FhE1w+SBAWD5r7xsNS/vJ2XF38NlxcOCDDSuDThmcsIsg2CNBa30BvLxC8KvPqL bC0KpyGuQ8gA== X-IronPort-AV: E=McAfee;i="6000,8403,9895"; a="161821380" X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="161821380" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:56:55 -0800 IronPort-SDR: MCMVenlFtazkKpfPbx4Daz53OkltSvdknM8NTJ5obPb3zrvw6toEcdwjMcEZssL6gBW0lDrEWA NQJeQrFvrZiA== X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="512208434" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:56:52 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 5AA8D20345; Mon, 15 Feb 2021 15:56:50 +0200 (EET) Date: Mon, 15 Feb 2021 15:56:50 +0200 From: Sakari Ailus To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Petr Mladek , Dave Stevenson , dri-devel@lists.freedesktop.org, hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Sergey Senozhatsky , Steven Rostedt , Joe Perches , Jani Nikula , Rasmus Villemoes Subject: Re: [PATCH v7 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs Message-ID: <20210215135650.GI3@paasikivi.fi.intel.com> References: <20210215114030.11862-1-sakari.ailus@linux.intel.com> <20210215114030.11862-2-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote: > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding is the same for both > > so the same implementation can be used. > > This version I almost like, feel free to add > Reviewed-by: From: Andy Shevchenko > after considering addressing below nit-picks. > > > Suggested-by: Mauro Carvalho Chehab > > Signed-off-by: Sakari Ailus > > Reviewed-by: Petr Mladek > > Reviewed-by: Sergey Senozhatsky > > --- > > Documentation/core-api/printk-formats.rst | 16 ++++++++++ > > lib/test_printf.c | 17 ++++++++++ > > lib/vsprintf.c | 39 +++++++++++++++++++++++ > > scripts/checkpatch.pl | 6 ++-- > > 4 files changed, 76 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > > index 160e710d992f..da2aa065dc42 100644 > > --- a/Documentation/core-api/printk-formats.rst > > +++ b/Documentation/core-api/printk-formats.rst > > @@ -567,6 +567,22 @@ For printing netdev_features_t. > > > > Passed by reference. > > > > +V4L2 and DRM FourCC code (pixel format) > > +--------------------------------------- > > + > > +:: > > + > > + %p4cc > > + > > +Print a FourCC code used by V4L2 or DRM, including format endianness and > > +its numerical value as hexadecimal. > > + > > +Passed by reference. > > + > > +Examples:: > > + > > + %p4cc BG12 little-endian (0x32314742) > > No examples with spaces / non-printable / non-ascii characters I can sure add an example that has a space. But do you think I really should add an example where invalid information is being printed? > > > + > > Thanks > > ====== > > > > diff --git a/lib/test_printf.c b/lib/test_printf.c > > index 7d60f24240a4..9848510a2786 100644 > > --- a/lib/test_printf.c > > +++ b/lib/test_printf.c > > @@ -647,6 +647,22 @@ static void __init fwnode_pointer(void) > > software_node_unregister_nodes(softnodes); > > } > > > > +static void __init fourcc_pointer(void) > > +{ > > + struct { > > + u32 code; > > + char *str; > > + } const try[] = { > > + { 0x3231564e, "NV12 little-endian (0x3231564e)", }, > > + { 0xb231564e, "NV12 big-endian (0xb231564e)", }, > > + { 0x10111213, ".... little-endian (0x10111213)", }, > > + }; > > + unsigned int i; > > + > > + for (i = 0; i < ARRAY_SIZE(try); i++) > > + test(try[i].str, "%p4cc", &try[i].code); > > +} > > + > > static void __init > > errptr(void) > > { > > @@ -692,6 +708,7 @@ test_pointer(void) > > flags(); > > errptr(); > > fwnode_pointer(); > > + fourcc_pointer(); > > } > > > > static void __init selftest(void) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > index 3b53c73580c5..432b5a2d1e90 100644 > > --- a/lib/vsprintf.c > > +++ b/lib/vsprintf.c > > @@ -1733,6 +1733,42 @@ char *netdev_bits(char *buf, char *end, const void *addr, > > return special_hex_number(buf, end, num, size); > > } > > > > +static noinline_for_stack > > +char *fourcc_string(char *buf, char *end, const u32 *fourcc, > > + struct printf_spec spec, const char *fmt) > > +{ > > + char output[sizeof("1234 little-endian (0x01234567)")]; > > 1234 -> ABCD ? (Or XY12 to be closer to the reality) I count in numbers... albeit the hexadecimal number there starts from zero. I guess both would work though. 0123 would be consistent. -- Regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D4BC433DB for ; Mon, 15 Feb 2021 13:56:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1522764E31 for ; Mon, 15 Feb 2021 13:56:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1522764E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DE396E283; Mon, 15 Feb 2021 13:56:57 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33AF66E283 for ; Mon, 15 Feb 2021 13:56:56 +0000 (UTC) IronPort-SDR: 07HmCY2E5X0HohDVCTYJMKcNCUXMbpp8RyUu2VZ7Xt19+Mc2fkV27oRulMlrH49HiFEmiZOWGu k2mYxs13Q4yg== X-IronPort-AV: E=McAfee;i="6000,8403,9895"; a="170344222" X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="170344222" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:56:55 -0800 IronPort-SDR: MCMVenlFtazkKpfPbx4Daz53OkltSvdknM8NTJ5obPb3zrvw6toEcdwjMcEZssL6gBW0lDrEWA NQJeQrFvrZiA== X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="512208434" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:56:52 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 5AA8D20345; Mon, 15 Feb 2021 15:56:50 +0200 (EET) Date: Mon, 15 Feb 2021 15:56:50 +0200 From: Sakari Ailus To: Andy Shevchenko Subject: Re: [PATCH v7 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs Message-ID: <20210215135650.GI3@paasikivi.fi.intel.com> References: <20210215114030.11862-1-sakari.ailus@linux.intel.com> <20210215114030.11862-2-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Dave Stevenson , Rasmus Villemoes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hverkuil@xs4all.nl, Sergey Senozhatsky , Steven Rostedt , laurent.pinchart@ideasonboard.com, Joe Perches , mchehab@kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Andy, On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote: > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding is the same for both > > so the same implementation can be used. > > This version I almost like, feel free to add > Reviewed-by: From: Andy Shevchenko > after considering addressing below nit-picks. > > > Suggested-by: Mauro Carvalho Chehab > > Signed-off-by: Sakari Ailus > > Reviewed-by: Petr Mladek > > Reviewed-by: Sergey Senozhatsky > > --- > > Documentation/core-api/printk-formats.rst | 16 ++++++++++ > > lib/test_printf.c | 17 ++++++++++ > > lib/vsprintf.c | 39 +++++++++++++++++++++++ > > scripts/checkpatch.pl | 6 ++-- > > 4 files changed, 76 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > > index 160e710d992f..da2aa065dc42 100644 > > --- a/Documentation/core-api/printk-formats.rst > > +++ b/Documentation/core-api/printk-formats.rst > > @@ -567,6 +567,22 @@ For printing netdev_features_t. > > > > Passed by reference. > > > > +V4L2 and DRM FourCC code (pixel format) > > +--------------------------------------- > > + > > +:: > > + > > + %p4cc > > + > > +Print a FourCC code used by V4L2 or DRM, including format endianness and > > +its numerical value as hexadecimal. > > + > > +Passed by reference. > > + > > +Examples:: > > + > > + %p4cc BG12 little-endian (0x32314742) > > No examples with spaces / non-printable / non-ascii characters I can sure add an example that has a space. But do you think I really should add an example where invalid information is being printed? > > > + > > Thanks > > ====== > > > > diff --git a/lib/test_printf.c b/lib/test_printf.c > > index 7d60f24240a4..9848510a2786 100644 > > --- a/lib/test_printf.c > > +++ b/lib/test_printf.c > > @@ -647,6 +647,22 @@ static void __init fwnode_pointer(void) > > software_node_unregister_nodes(softnodes); > > } > > > > +static void __init fourcc_pointer(void) > > +{ > > + struct { > > + u32 code; > > + char *str; > > + } const try[] = { > > + { 0x3231564e, "NV12 little-endian (0x3231564e)", }, > > + { 0xb231564e, "NV12 big-endian (0xb231564e)", }, > > + { 0x10111213, ".... little-endian (0x10111213)", }, > > + }; > > + unsigned int i; > > + > > + for (i = 0; i < ARRAY_SIZE(try); i++) > > + test(try[i].str, "%p4cc", &try[i].code); > > +} > > + > > static void __init > > errptr(void) > > { > > @@ -692,6 +708,7 @@ test_pointer(void) > > flags(); > > errptr(); > > fwnode_pointer(); > > + fourcc_pointer(); > > } > > > > static void __init selftest(void) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > index 3b53c73580c5..432b5a2d1e90 100644 > > --- a/lib/vsprintf.c > > +++ b/lib/vsprintf.c > > @@ -1733,6 +1733,42 @@ char *netdev_bits(char *buf, char *end, const void *addr, > > return special_hex_number(buf, end, num, size); > > } > > > > +static noinline_for_stack > > +char *fourcc_string(char *buf, char *end, const u32 *fourcc, > > + struct printf_spec spec, const char *fmt) > > +{ > > + char output[sizeof("1234 little-endian (0x01234567)")]; > > 1234 -> ABCD ? (Or XY12 to be closer to the reality) I count in numbers... albeit the hexadecimal number there starts from zero. I guess both would work though. 0123 would be consistent. -- Regards, Sakari Ailus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel