From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E275FC433DB for ; Mon, 15 Feb 2021 14:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA48964E94 for ; Mon, 15 Feb 2021 14:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbhBOO6M (ORCPT ); Mon, 15 Feb 2021 09:58:12 -0500 Received: from mga06.intel.com ([134.134.136.31]:32291 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbhBOO6G (ORCPT ); Mon, 15 Feb 2021 09:58:06 -0500 IronPort-SDR: XRI2YHDWqF8aa+hTcEIArE6k8iUp3SG+wtluY8jAm3/qdwpxCoak9EXLunCrifu0gOwuNPkKqG 1O04mI+0fA8g== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="244178902" X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="244178902" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 06:56:08 -0800 IronPort-SDR: S7XowDQdxgA5uxRsT+QP62wODlyNuF97EOFONflFt9+Fd5LtAxq1kDpKR582+4G6ld0RQyNdxf EDBvWR9/Xu7g== X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="383396088" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 06:56:03 -0800 Received: by lahna (sSMTP sendmail emulation); Mon, 15 Feb 2021 16:56:01 +0200 Date: Mon, 15 Feb 2021 16:56:01 +0200 From: "mika.westerberg@linux.intel.com" To: Sergei Miroshnichenko Cc: "David.Laight@aculab.com" , "christian@kellner.me" , "christian.koenig@amd.com" , "rajatja@google.com" , "YehezkelShB@gmail.com" , "mario.limonciello@dell.com" , "helgaas@kernel.org" , "linux@yadro.com" , "linux-pci@vger.kernel.org" , "sr@denx.de" , "lukas@wunner.de" , "andy.lavr@gmail.com" Subject: Re: [PATCH v9 00/26] PCI: Allow BAR movement during boot and hotplug Message-ID: <20210215145601.GZ2542@lahna.fi.intel.com> References: <20210128145316.GA3052488@bjorn-Precision-5520> <20210128203929.GB6613@wunner.de> <20210201125523.GN2542@lahna.fi.intel.com> <44ce19d112b97930b1a154740c2e15f3f2d10818.camel@yadro.com> <20210204104912.GE2542@lahna.fi.intel.com> <20210211113941.GF2542@lahna.fi.intel.com> <52dd963fc697059d3db39c25eda222f4b7197761.camel@yadro.com> <20210212125233.GS2542@lahna.fi.intel.com> <460947ac479281677cdc42e69fc60dccd19dfe94.camel@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <460947ac479281677cdc42e69fc60dccd19dfe94.camel@yadro.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Feb 12, 2021 at 08:54:18PM +0000, Sergei Miroshnichenko wrote: > On Fri, 2021-02-12 at 14:52 +0200, mika.westerberg@linux.intel.com > wrote: > > Hi, > > > > On Thu, Feb 11, 2021 at 05:45:20PM +0000, Sergei Miroshnichenko > > wrote: > > > What a pity. Yes, please, I would of course like to take a look why > > > that happened, and compare, what went wrong (before and after the > > > hotplug: lspci -tv, dmesg -t and /proc/iomem with /proc/ioports, if > > > it > > > wouldn't be too much trouble). > > > > I just sent these logs to you in a separate email. Let me know if you > > need more. > > Thanks, from them it's clear that the "full rescan" apprach currently > doesn't involve the pci_bus_distribute_available_resources(), that's > why hot-adding a second nested switch breaks: because of non- > distributed free bus numbers. The first switch seems was hot-added just > fine, with BARs being moved a bit. > > This is to be fixed in v10, along with the > mpt3sas+pci_dev_is_disconnected() moment Lukas had found (thanks > Lukas!), CONFIG_DEBUG_LOCK_ALLOC macro, and a more useful debug > messages. Great, thanks! :)