From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D24C433DB for ; Mon, 15 Feb 2021 17:58:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57047601FD for ; Mon, 15 Feb 2021 17:58:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57047601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBi8k-0004IE-D2 for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 12:58:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBi7Z-0003rf-Aa for qemu-devel@nongnu.org; Mon, 15 Feb 2021 12:57:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBi7W-0004O2-8n for qemu-devel@nongnu.org; Mon, 15 Feb 2021 12:57:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613411833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NzKpPej4oZ9KzdDxeOfhvFyebhtyrKOFHTV8D6tCj1M=; b=RiIejA4ZN3ch/xaggyTDyvZpQraLmd3VI1wG7o/UjK4d7Zx6oiLjd1EPID4+goLQp7FIiO xtQuezLRbbcXpbx7UkNFW5CY9QFasg5W1awAOYNZrknDRk4xMlT4l80GmBKZBhK10NIVum ZLS04ooL4/uGUozClEKrCAKLdJA1qqk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-en3peMaFMVCNZF2GwPxmsw-1; Mon, 15 Feb 2021 12:57:08 -0500 X-MC-Unique: en3peMaFMVCNZF2GwPxmsw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ACBB5801962; Mon, 15 Feb 2021 17:57:06 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-28.rdu2.redhat.com [10.10.114.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E98E31002382; Mon, 15 Feb 2021 17:56:58 +0000 (UTC) Date: Mon, 15 Feb 2021 12:56:57 -0500 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length Message-ID: <20210215175657.GB72984@localhost.localdomain> References: <20210203172357.1422425-1-crosa@redhat.com> <20210203172357.1422425-8-crosa@redhat.com> <8735ycq80u.fsf@linaro.org> <2c1a58b2-e023-4aca-16c7-c850f6069657@redhat.com> <87k0rha2mu.fsf@linaro.org> <2bacef90-7533-d439-cf7d-8fba51e64c1a@redhat.com> <87h7ml9z7g.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Beraldo Leal , Wainer dos Santos Moschetta , John Snow , qemu-devel@nongnu.org, Max Reitz , Eric Auger , Willian Rampazzo , Thomas Huth , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Alex =?iso-8859-1?Q?Benn=E9e?= , Aurelien Jarno , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 09, 2021 at 06:15:26PM +0100, Philippe Mathieu-Daud=E9 wrote: > >=20 > > I've actually done this with some Xen patches I'm working on at the > > moment. I'll probably decorate the test with: > >=20 > > @skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted cod= e') > >=20 > > with a comment explaining what's waiting to be upstreamed. Once there > > are upstream binaries I plan on transitioning the test to those. >=20 > Instead of a binary AVOCADO_ALLOW_UNTRUSTED_CODE variable, we could > have a list allowed domains/namespaces, that can be increased on the > tester discretion. >=20 > For example these are assumed trusted: >=20 > . archives.fedoraproject.org > . archive.debian.org > . cdn.netbsd.org > . github.com/torvalds > . people.debian.org/~aurel32 > . snapshot.debian.org > . storage.kernelci.org > . www.qemu-advent-calendar.org >=20 > Then personally interested in testing ARM boards I'd amend: >=20 > . apt.armbian.com > . github.com/philmd > . github.com/groeck > . github.com/hskinnemoen > . github.com/pbatard >=20 > and Max's repo since I'm interested in testing virtiofs_submounts. >=20 Hi Phil, I think I follow your idea, but I see two issues here: 1) Functional area (subsystem / architecture / machine type, etc) 2) Trustfulness of the code WRT 1, the domains do not contain meaning onto themselves, so a secondary mapping of subsystem/architecture/machine to the domain would be needed. Also, wouldn't it be common to end up needing a N:N mapping between domains and subsystem/architecture/machine? WRT 2, while limiting download from a number of domains can add some protection, the ultimate trust is achieved by setting a hash to the exact code we will download/run. If those points seem valid, then I believe it's better to continue thinking of subsystem/architecture/machine because of the usability aspects, and possibly improve the perceived level of trust/stability of the assets by adding a "tier" classification. That one, one could pick, say: * board|machine_type =3D=3D "foo" AND * tier =3D=3D 1 And exclude what is considered inferior tiers. How does that sound? Regards, - Cleber. --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeruW64tGuU1eD+m7ZX6NM6XyCfMFAmAqteYACgkQZX6NM6Xy CfP5mQ//VbSbqB5ddPI52xXCpigAeFuEXFUJB9BupSsOVq0pzyoC/DbH2KRN+mMS DVN0YA5ybQh7BOhg+nworAec88GxZXW/YwuwIIqmhghp4yFQHEc6smXLzIlxeMbT o+YEecw3I3MaD7c4tuioYzPWoZMbO+fkJXJgQwF9SeyGu00xhLuHZkK6u55ro81s nv0O0C2iBa5Hv91OZdGARd1pcj4eaOGjmHrHV2l9wrJ3goaQijEaFanvehOVPmPM a5VUDkajn3iorh03G5mM9g+PzItdSphTZaTDAAqQdE2q2EWw07ORx4OMNcuQDYmY zpkFyYGhkkDgUVIM0zRlVg9kbj0RXSk82uMNy0v2U89BOGaHYR4tx5MSYXOQFY37 5UGHJGshAOP7/7gkGGgC4iN+iQsmzfmGlxzrLuXj3AWp6dOtncy99hW3/nwG4uVS 7Oxy+v8EQiuAoRjImoJL2ue8ebRzieSM/Vz4B5R9L50imKjL3XnGcbELHKWQt7Ck 5idN5wxlP5aexquQ/R237/UzOz/SrUU8OgfisG7RfLnYMk1O2rzl6eQSwu2JGtnd 7YZp8Wk0Rtm4nZmYYWxERF5zNHVCkdQvpbhD34w1QzbN53bMsv4xUYoPXIp7qidh I4njUcS0HRvVL8zORk21tQbdyE9Pu5Dutffs2O6nZn4KFS39Oj8= =hWAo -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW--