From: Mark Brown <broonie@kernel.org>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Subject: Re: [PATCH 2/3] ASoC: soc-pcm: add soc_pcm_hw_update_chan()
Date: Mon, 15 Feb 2021 20:45:27 +0000 [thread overview]
Message-ID: <20210215204527.GC4378@sirena.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2102142311050.864696@eliteleevi.tm.intel.com>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
On Sun, Feb 14, 2021 at 11:17:03PM +0200, Kai Vehmanen wrote:
> On Fri, 12 Feb 2021, Pierre-Louis Bossart wrote:
> > > We have soc_pcm_hw_update_rate() now.
> > > This patch creates same function for chan.
> > This patch seems to break all SOF platforms. I tested manually to try and
> > reproduce the CI results and it's indeed not so good:
> ouch -- I think this will impact also non-SOF platforms.
> The new helper functions seem all correct, but the problem would seem to
> be in the dpcm_init_runtime_hw() as some of the inputs are not initialized
> as expected here. I'll try to send a fixup patch asap. In case 5.11 is
> released later today, this regression needs to be fixed for first 5.12
> pull req.
I've applied the fixup patch, if someone could confirm that the CI looks
good I'll send the pull request for this release.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-15 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:50 [PATCH 0/3] ASoC: soc-pcm: add soc_pcm_hw_update_xxx() Kuninori Morimoto
2021-02-03 23:50 ` [PATCH 1/3] ASoC: soc-pcm: add soc_pcm_hw_update_rate() Kuninori Morimoto
2021-02-03 23:51 ` [PATCH 2/3] ASoC: soc-pcm: add soc_pcm_hw_update_chan() Kuninori Morimoto
2021-02-12 23:48 ` Pierre-Louis Bossart
2021-02-14 21:17 ` Kai Vehmanen
2021-02-14 23:21 ` Kuninori Morimoto
2021-02-15 20:45 ` Mark Brown [this message]
2021-02-16 6:52 ` Kai Vehmanen
2021-02-16 7:26 ` Kuninori Morimoto
2021-02-16 8:30 ` Kai Vehmanen
2021-02-16 11:22 ` Kai Vehmanen
2021-02-16 17:17 ` Mark Brown
2021-02-03 23:52 ` [PATCH 3/3] ASoC: soc-pcm: add soc_pcm_hw_update_format() Kuninori Morimoto
2021-02-05 7:27 ` [PATCH 0/3] ASoC: soc-pcm: add soc_pcm_hw_update_xxx() Kai Vehmanen
2021-02-12 14:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215204527.GC4378@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.