From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B92FC433DB for ; Tue, 16 Feb 2021 08:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A45B364DFF for ; Tue, 16 Feb 2021 08:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbhBPItP (ORCPT ); Tue, 16 Feb 2021 03:49:15 -0500 Received: from verein.lst.de ([213.95.11.211]:40382 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbhBPItI (ORCPT ); Tue, 16 Feb 2021 03:49:08 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 2302E6736F; Tue, 16 Feb 2021 09:48:26 +0100 (CET) Date: Tue, 16 Feb 2021 09:48:25 +0100 From: Christoph Hellwig To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , David Howells , Al Viro , linux-fsdevel@vger.kernel.org, Christian Brauner , "David P . Quigley" , James Morris Subject: Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns Message-ID: <20210216084825.GA23845@lst.de> References: <20210216042929.8931-1-rdunlap@infradead.org> <20210216042929.8931-2-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216042929.8931-2-rdunlap@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > Fix kernel-doc warning in libfs.c. > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not described in 'simple_setattr' Shouldn't the subject say simple_setattr instead of mnt_userns? Otherwise looks good: Reviewed-by: Christoph Hellwig