All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Du Cheng <ducheng2@gmail.com>,
	Manish Chopra <manishc@marvell.com>,
	devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c
Date: Tue, 16 Feb 2021 12:35:10 +0300	[thread overview]
Message-ID: <20210216093510.GY2087@kadam> (raw)
In-Reply-To: <f9f2ed25-8903-450b-0971-a5eb292380cf@gmail.com>

On Tue, Feb 16, 2021 at 10:20:22AM +0100, Heiner Kallweit wrote:
> On 16.02.2021 09:53, Du Cheng wrote:
> > align * in block comments on each line
> > 
> > changes v3:
> > - add SUBSYSTEM in subject line
> > - add explanation to past version of this patch
> > 
> > changes v2:
> > - move closing of comment to the same line
> > 
> > changes v1:
> > - align * in block comments
> > 
> > Signed-off-by: Du Cheng <ducheng2@gmail.com>
> > ---
> >  drivers/staging/qlge/qlge_main.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> > index 5516be3af898..2682a0e474bd 100644
> > --- a/drivers/staging/qlge/qlge_main.c
> > +++ b/drivers/staging/qlge/qlge_main.c
> > @@ -3815,8 +3815,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
> >  
> >  	qlge_tx_ring_clean(qdev);
> >  
> > -	/* Call netif_napi_del() from common point.
> > -	*/
> > +	/* Call netif_napi_del() from common point. */
> >  	for (i = 0; i < qdev->rss_ring_count; i++)
> >  		netif_napi_del(&qdev->rx_ring[i].napi);
> >  
> > 
> Typically such trivial patches aren't much appreciated for staging drivers.
> In the case here I have doubts that the comment as such provides any benefit.

Huh?  What?  I think you have mixed up staging and non-staging.  In
staging we apply this sort of patch all the time.

This patch improves the code.  It's the only warning of this type in the
file.  We will apply it.

If you start down the path of worrying about "is this worth doing" then
you end up wasting maintainer time and developer time.  That's like an
ambiguous thing, right?  We try to avoid ambiguity and be mechanical and
predictable.

We won't apply patches which fix checkpatch warnings if the result is
worse looking code.  This might seem like an ambiguous judgement call to
newbies but it is actually 100% predictable to oldbies.  :P

Anyway the v2 v3 stuff is supposed to be below the --- cut off so please
fix that and resend.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org, Manish Chopra <manishc@marvell.com>,
	Du Cheng <ducheng2@gmail.com>
Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c
Date: Tue, 16 Feb 2021 12:35:10 +0300	[thread overview]
Message-ID: <20210216093510.GY2087@kadam> (raw)
In-Reply-To: <f9f2ed25-8903-450b-0971-a5eb292380cf@gmail.com>

On Tue, Feb 16, 2021 at 10:20:22AM +0100, Heiner Kallweit wrote:
> On 16.02.2021 09:53, Du Cheng wrote:
> > align * in block comments on each line
> > 
> > changes v3:
> > - add SUBSYSTEM in subject line
> > - add explanation to past version of this patch
> > 
> > changes v2:
> > - move closing of comment to the same line
> > 
> > changes v1:
> > - align * in block comments
> > 
> > Signed-off-by: Du Cheng <ducheng2@gmail.com>
> > ---
> >  drivers/staging/qlge/qlge_main.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> > index 5516be3af898..2682a0e474bd 100644
> > --- a/drivers/staging/qlge/qlge_main.c
> > +++ b/drivers/staging/qlge/qlge_main.c
> > @@ -3815,8 +3815,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
> >  
> >  	qlge_tx_ring_clean(qdev);
> >  
> > -	/* Call netif_napi_del() from common point.
> > -	*/
> > +	/* Call netif_napi_del() from common point. */
> >  	for (i = 0; i < qdev->rss_ring_count; i++)
> >  		netif_napi_del(&qdev->rx_ring[i].napi);
> >  
> > 
> Typically such trivial patches aren't much appreciated for staging drivers.
> In the case here I have doubts that the comment as such provides any benefit.

Huh?  What?  I think you have mixed up staging and non-staging.  In
staging we apply this sort of patch all the time.

This patch improves the code.  It's the only warning of this type in the
file.  We will apply it.

If you start down the path of worrying about "is this worth doing" then
you end up wasting maintainer time and developer time.  That's like an
ambiguous thing, right?  We try to avoid ambiguity and be mechanical and
predictable.

We won't apply patches which fix checkpatch warnings if the result is
worse looking code.  This might seem like an ambiguous judgement call to
newbies but it is actually 100% predictable to oldbies.  :P

Anyway the v2 v3 stuff is supposed to be below the --- cut off so please
fix that and resend.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2021-02-16  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  8:53 [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c Du Cheng
2021-02-16  8:53 ` Du Cheng
2021-02-16  9:20 ` Heiner Kallweit
2021-02-16  9:20   ` Heiner Kallweit
2021-02-16  9:35   ` Dan Carpenter [this message]
2021-02-16  9:35     ` Dan Carpenter
2021-02-16  9:20 ` Greg Kroah-Hartman
2021-02-16  9:20   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210216093510.GY2087@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ducheng2@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.