From: Dan Carpenter <dan.carpenter@oracle.com>
To: Du Cheng <ducheng2@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] staging: greybus: fix coding style of greybus/loopback.c
Date: Tue, 16 Feb 2021 14:25:07 +0300 [thread overview]
Message-ID: <20210216112507.GZ2087@kadam> (raw)
In-Reply-To: <20210216111353.190238-1-ducheng2@gmail.com>
On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote:
> fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
> inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng <ducheng2@gmail.com>
> ---
> changes v2:
> * relign backslashes with tabstop=8
> * improve description and subject
>
> changes v1:
> * fix coding style of the macro
>
This breaks the build.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-16 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 11:13 [PATCH v2] staging: greybus: fix coding style of greybus/loopback.c Du Cheng
2021-02-16 11:25 ` Dan Carpenter [this message]
2021-02-16 11:28 ` Greg Kroah-Hartman
2021-02-16 13:12 ` Du Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216112507.GZ2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ducheng2@gmail.com \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.