From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60494C433E0 for ; Tue, 16 Feb 2021 11:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FB2964D9F for ; Tue, 16 Feb 2021 11:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230081AbhBPLeh (ORCPT ); Tue, 16 Feb 2021 06:34:37 -0500 Received: from m12-12.163.com ([220.181.12.12]:37134 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbhBPLdw (ORCPT ); Tue, 16 Feb 2021 06:33:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=ft9IV CaIYYlZGapAVYO7212ce06jLN0YlvxVzsj0xjs=; b=ld6Lc4zjVTWhHFuyf5x3x CgwNiokKW5zEPgYZ+Qg65tankdhoR9Lmv5lH+IZAa2cW7SEKgLTQ3CK3x9kX0HvO YmPoDJ9X+8JtuvbbObtjRxKWQh8B44xGPeAxYl7PdModQJ1Wvwf12zw0rleP5dfP RfmMm5FgNxrg95FQ5YhFHg= Received: from yangjunlin.ccdomain.com (unknown [218.17.89.92]) by smtp8 (Coremail) with SMTP id DMCowAA3WvgZrStgEbKIQw--.17887S2; Tue, 16 Feb 2021 19:31:38 +0800 (CST) From: angkery To: agross@kernel.org, bjorn.andersson@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Junlin Yang Subject: [PATCH] bus: qcom-ebi2: add missing of_node_put Date: Tue, 16 Feb 2021 19:30:53 +0800 Message-Id: <20210216113053.1722-1-angkery@163.com> X-Mailer: git-send-email 2.24.0.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DMCowAA3WvgZrStgEbKIQw--.17887S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF1kur15GryDZw1kCryUZFb_yoW3urgEkr Z2vFWxWrnY9rs2ywnFqws8Xr9ayr4kurW8WFWIqa43Za4UAa1DGF4kZr95u34xurW8tr93 Cr98AF1rCr18GjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUn4rW7UUUUU== X-Originating-IP: [218.17.89.92] X-CM-SenderInfo: 5dqjyvlu16il2tof0z/xtbBRho7I13l+nb9mQAAsU Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Junlin Yang Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle returns. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Signed-off-by: Junlin Yang --- drivers/bus/qcom-ebi2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c index 03ddcf4..0b8f53a 100644 --- a/drivers/bus/qcom-ebi2.c +++ b/drivers/bus/qcom-ebi2.c @@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev) /* Figure out the chipselect */ ret = of_property_read_u32(child, "reg", &csindex); - if (ret) + if (ret) { + of_node_put(child); return ret; + } if (csindex > 5) { dev_err(dev, -- 1.9.1