* [PATCH v2] staging: hikey9xx: fix styling issues
@ 2021-02-16 12:42 ` Alaa Emad
0 siblings, 0 replies; 4+ messages in thread
From: Alaa Emad @ 2021-02-16 12:42 UTC (permalink / raw)
To: mchehab+huawei, gregkh; +Cc: devel, linux-kernel, Alaa Emad
In hi6421-spmi-pmic.c, there are some warnings and Check:
"WARNING: please, no space before tabs" in lines 51,52,53 and 69.
"CHECK: Alignment should match open parenthesis" in lines 180 and 238.
Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
---
Changes in v2:
- Make the commit message more clearer.
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
/*
* The IRQs are mapped as:
*
- * ====================== ============= ============ =====
- * IRQ MASK REGISTER IRQ REGISTER BIT
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
+ * IRQ MASK REGISTER IRQ REGISTER BIT
+ * ====================== ============= ============ =====
* OTMP 0x0202 0x212 bit 0
* VBUS_CONNECT 0x0202 0x212 bit 1
* VBUS_DISCONNECT 0x0202 0x212 bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
* SIM0_HPD_F 0x0203 0x213 bit 3
* SIM1_HPD_R 0x0203 0x213 bit 4
* SIM1_HPD_F 0x0203 0x213 bit 5
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
*/
#define SOC_PMIC_IRQ_MASK_0_ADDR 0x0202
#define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct hi6421_spmi_pmic *ddata)
for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
- HISI_MASK);
+ HISI_MASK);
for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;
ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
- &hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] staging: hikey9xx: fix styling issues
@ 2021-02-16 12:42 ` Alaa Emad
0 siblings, 0 replies; 4+ messages in thread
From: Alaa Emad @ 2021-02-16 12:42 UTC (permalink / raw)
To: mchehab+huawei, gregkh; +Cc: devel, linux-kernel, Alaa Emad
In hi6421-spmi-pmic.c, there are some warnings and Check:
"WARNING: please, no space before tabs" in lines 51,52,53 and 69.
"CHECK: Alignment should match open parenthesis" in lines 180 and 238.
Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
---
Changes in v2:
- Make the commit message more clearer.
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 9c5e113e1a81..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
/*
* The IRQs are mapped as:
*
- * ====================== ============= ============ =====
- * IRQ MASK REGISTER IRQ REGISTER BIT
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
+ * IRQ MASK REGISTER IRQ REGISTER BIT
+ * ====================== ============= ============ =====
* OTMP 0x0202 0x212 bit 0
* VBUS_CONNECT 0x0202 0x212 bit 1
* VBUS_DISCONNECT 0x0202 0x212 bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
* SIM0_HPD_F 0x0203 0x213 bit 3
* SIM1_HPD_R 0x0203 0x213 bit 4
* SIM1_HPD_F 0x0203 0x213 bit 5
- * ====================== ============= ============ =====
+ * ====================== ============= ============ =====
*/
#define SOC_PMIC_IRQ_MASK_0_ADDR 0x0202
#define SOC_PMIC_IRQ0_ADDR 0x0212
@@ -177,7 +177,7 @@ static void hi6421_spmi_pmic_irq_init(struct hi6421_spmi_pmic *ddata)
for (i = 0; i < HISI_IRQ_ARRAY; i++)
regmap_write(ddata->regmap, SOC_PMIC_IRQ_MASK_0_ADDR + i,
- HISI_MASK);
+ HISI_MASK);
for (i = 0; i < HISI_IRQ_ARRAY; i++) {
regmap_read(ddata->regmap, SOC_PMIC_IRQ0_ADDR + i, &pending);
@@ -235,7 +235,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
return -ENOMEM;
ddata->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,
- &hi6421_spmi_domain_ops, ddata);
+ &hi6421_spmi_domain_ops, ddata);
if (!ddata->domain) {
dev_err(dev, "Failed to create IRQ domain\n");
return -ENODEV;
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: hikey9xx: fix styling issues
2021-02-16 12:42 ` Alaa Emad
@ 2021-02-19 8:11 ` Greg KH
-1 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-02-19 8:11 UTC (permalink / raw)
To: Alaa Emad; +Cc: mchehab+huawei, devel, linux-kernel
On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote:
> In hi6421-spmi-pmic.c, there are some warnings and Check:
>
> "WARNING: please, no space before tabs" in lines 51,52,53 and 69.
> "CHECK: Alignment should match open parenthesis" in lines 180 and 238.
>
> Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
That is doing 2 different things in the same patch, please make this a
patch series and do only one type of logical thing per patch and resend
them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: hikey9xx: fix styling issues
@ 2021-02-19 8:11 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-02-19 8:11 UTC (permalink / raw)
To: Alaa Emad; +Cc: mchehab+huawei, devel, linux-kernel
On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote:
> In hi6421-spmi-pmic.c, there are some warnings and Check:
>
> "WARNING: please, no space before tabs" in lines 51,52,53 and 69.
> "CHECK: Alignment should match open parenthesis" in lines 180 and 238.
>
> Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
That is doing 2 different things in the same patch, please make this a
patch series and do only one type of logical thing per patch and resend
them.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-19 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 12:42 [PATCH v2] staging: hikey9xx: fix styling issues Alaa Emad
2021-02-16 12:42 ` Alaa Emad
2021-02-19 8:11 ` Greg KH
2021-02-19 8:11 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.