* [Buildroot] [PATCH] package/tcpdump: remove duplicated binary
@ 2021-02-16 12:50 Thomas De Schampheleire
2021-02-16 19:46 ` Peter Korsgaard
2021-02-16 19:46 ` Baruch Siach
0 siblings, 2 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2021-02-16 12:50 UTC (permalink / raw)
To: buildroot
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in
/usr/sbin but in /usr/bin. This change invalidates the Buildroot hook
'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size
increase as a result.
Update the path inside this hook.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
package/tcpdump/tcpdump.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/tcpdump/tcpdump.mk b/package/tcpdump/tcpdump.mk
index f8ea6576ee..c562034a4e 100644
--- a/package/tcpdump/tcpdump.mk
+++ b/package/tcpdump/tcpdump.mk
@@ -22,7 +22,7 @@ TCPDUMP_SELINUX_MODULES = netutils
# make install installs an unneeded extra copy of the tcpdump binary
define TCPDUMP_REMOVE_DUPLICATED_BINARY
- rm -f $(TARGET_DIR)/usr/sbin/tcpdump.$(TCPDUMP_VERSION)
+ rm -f $(TARGET_DIR)/usr/bin/tcpdump.$(TCPDUMP_VERSION)
endef
TCPDUMP_POST_INSTALL_TARGET_HOOKS += TCPDUMP_REMOVE_DUPLICATED_BINARY
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/tcpdump: remove duplicated binary
2021-02-16 12:50 [Buildroot] [PATCH] package/tcpdump: remove duplicated binary Thomas De Schampheleire
@ 2021-02-16 19:46 ` Peter Korsgaard
2021-02-16 19:46 ` Baruch Siach
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-02-16 19:46 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in
> /usr/sbin but in /usr/bin. This change invalidates the Buildroot hook
> 'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size
> increase as a result.
> Update the path inside this hook.
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/tcpdump: remove duplicated binary
2021-02-16 12:50 [Buildroot] [PATCH] package/tcpdump: remove duplicated binary Thomas De Schampheleire
2021-02-16 19:46 ` Peter Korsgaard
@ 2021-02-16 19:46 ` Baruch Siach
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2021-02-16 19:46 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Tue, Feb 16 2021, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in
> /usr/sbin but in /usr/bin. This change invalidates the Buildroot hook
> 'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size
> increase as a result.
>
> Update the path inside this hook.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> package/tcpdump/tcpdump.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/tcpdump/tcpdump.mk b/package/tcpdump/tcpdump.mk
> index f8ea6576ee..c562034a4e 100644
> --- a/package/tcpdump/tcpdump.mk
> +++ b/package/tcpdump/tcpdump.mk
> @@ -22,7 +22,7 @@ TCPDUMP_SELINUX_MODULES = netutils
>
> # make install installs an unneeded extra copy of the tcpdump binary
> define TCPDUMP_REMOVE_DUPLICATED_BINARY
> - rm -f $(TARGET_DIR)/usr/sbin/tcpdump.$(TCPDUMP_VERSION)
> + rm -f $(TARGET_DIR)/usr/bin/tcpdump.$(TCPDUMP_VERSION)
> endef
>
> TCPDUMP_POST_INSTALL_TARGET_HOOKS += TCPDUMP_REMOVE_DUPLICATED_BINARY
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-16 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 12:50 [Buildroot] [PATCH] package/tcpdump: remove duplicated binary Thomas De Schampheleire
2021-02-16 19:46 ` Peter Korsgaard
2021-02-16 19:46 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.