From: Jacopo Mondi <jacopo+renesas@jmondi.org> To: kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization Date: Tue, 16 Feb 2021 18:41:39 +0100 [thread overview] Message-ID: <20210216174146.106639-10-jacopo+renesas@jmondi.org> (raw) In-Reply-To: <20210216174146.106639-1-jacopo+renesas@jmondi.org> The OV10640 image sensor reset and powerdown on signals are controlled by the embedded OV490 ISP. The current reset procedure does not respect the 1 millisecond power-up delay and releases the reset signal before the powerdown one. Fix the OV10640 power up sequence by releasing the powerdown signal, waiting the mandatory 1 millisecond power up delay and then releasing the reset signal. The reset delay is not characterized in the chip manual if not as "255 XVCLK + initialization". Wait for at least 3 milliseconds to guarantee the SCCB bus is available. This commit fixes a sporadic start-up error triggered by a failure to read the OV10640 chip ID: rdacm21 8-0054: OV10640 ID mismatch: (0x01) Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- drivers/media/i2c/rdacm21.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c index b22a2ca5340b..c420a6b96879 100644 --- a/drivers/media/i2c/rdacm21.c +++ b/drivers/media/i2c/rdacm21.c @@ -333,13 +333,15 @@ static int ov10640_initialize(struct rdacm21_device *dev) { u8 val; - /* Power-up OV10640 by setting RESETB and PWDNB pins high. */ + /* Power-up OV10640 by setting PWDNB and RESETB pins high. */ ov490_write_reg(dev, OV490_GPIO_SEL0, OV490_GPIO0); ov490_write_reg(dev, OV490_GPIO_SEL1, OV490_SPWDN0); ov490_write_reg(dev, OV490_GPIO_DIRECTION0, OV490_GPIO0); ov490_write_reg(dev, OV490_GPIO_DIRECTION1, OV490_SPWDN0); - ov490_write_reg(dev, OV490_GPIO_OUTPUT_VALUE0, OV490_GPIO0); + ov490_write_reg(dev, OV490_GPIO_OUTPUT_VALUE0, OV490_SPWDN0); + usleep_range(1500, 3000); + ov490_write_reg(dev, OV490_GPIO_OUTPUT_VALUE0, OV490_GPIO0); usleep_range(3000, 5000); /* Read OV10640 ID to test communications. */ -- 2.30.0
next prev parent reply other threads:[~2021-02-16 17:45 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 17:41 [PATCH 00/16] media: i2c: GMSL reliability improvements Jacopo Mondi 2021-02-16 17:41 ` [PATCH 01/16] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi 2021-02-17 12:55 ` Kieran Bingham 2021-02-22 0:49 ` Laurent Pinchart 2021-02-22 14:59 ` Jacopo Mondi 2021-02-24 20:35 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 02/16] media: i2c: rdacm20: Embedded 'serializer' field Jacopo Mondi 2021-02-17 12:56 ` Kieran Bingham 2021-02-22 0:58 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop Jacopo Mondi 2021-02-17 13:01 ` Kieran Bingham 2021-02-22 1:05 ` Laurent Pinchart 2021-02-22 15:06 ` Jacopo Mondi 2021-02-24 20:27 ` Laurent Pinchart 2021-02-25 8:56 ` Kieran Bingham 2021-02-16 17:41 ` [PATCH 04/16] media: i2c: rdacm20: Report camera module name Jacopo Mondi 2021-02-17 13:02 ` Kieran Bingham 2021-02-22 1:06 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 05/16] media: i2c: rdacm20: Check return values Jacopo Mondi 2021-02-17 13:08 ` Kieran Bingham 2021-02-22 1:09 ` Laurent Pinchart 2021-02-22 15:08 ` Jacopo Mondi 2021-02-16 17:41 ` [PATCH 06/16] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi 2021-02-17 13:22 ` Kieran Bingham 2021-02-22 1:15 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 07/16] media: i2c: rdacm2x: Fix wake up delay Jacopo Mondi 2021-02-17 8:02 ` Geert Uytterhoeven 2021-02-17 13:33 ` Kieran Bingham 2021-02-22 1:18 ` Laurent Pinchart 2021-02-22 15:11 ` Jacopo Mondi 2021-02-24 20:29 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 08/16] media: i2c: max9286: Adjust parameters indent Jacopo Mondi 2021-02-17 13:36 ` Kieran Bingham 2021-02-22 1:20 ` Laurent Pinchart 2021-02-16 17:41 ` Jacopo Mondi [this message] 2021-02-17 8:06 ` [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization Geert Uytterhoeven 2021-02-17 13:55 ` Kieran Bingham 2021-02-22 1:27 ` Laurent Pinchart 2021-02-22 15:19 ` Jacopo Mondi 2021-02-24 20:30 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 10/16] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi 2021-02-17 8:07 ` Geert Uytterhoeven 2021-02-18 15:06 ` Kieran Bingham 2021-02-22 1:29 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 11/16] media: i2c: max9286: Cache channel amplitude Jacopo Mondi 2021-02-17 8:08 ` Geert Uytterhoeven 2021-02-18 15:39 ` Kieran Bingham 2021-02-22 1:33 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 12/16] media: i2c: max9286: Define high " Jacopo Mondi 2021-02-18 15:39 ` Kieran Bingham 2021-02-22 1:35 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 13/16] media: i2c: rdacm2x: Implement .init() subdev op Jacopo Mondi 2021-02-17 8:17 ` Geert Uytterhoeven 2021-02-18 16:13 ` Kieran Bingham 2021-02-22 1:52 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 14/16] media: i2c: max9286: Initialize remotes when bound Jacopo Mondi 2021-02-17 8:19 ` Geert Uytterhoeven 2021-02-18 16:00 ` Kieran Bingham 2021-02-22 2:03 ` Laurent Pinchart 2021-02-16 17:41 ` [PATCH 15/16] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi 2021-02-18 16:03 ` Kieran Bingham 2021-02-16 17:41 ` [PATCH 16/16] media: i2c: gmsl: Use 339Kbps I2C bit-rate Jacopo Mondi 2021-02-17 8:19 ` Geert Uytterhoeven 2021-02-18 16:07 ` Kieran Bingham 2021-02-22 2:06 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210216174146.106639-10-jacopo+renesas@jmondi.org \ --to=jacopo+renesas@jmondi.org \ --cc=geert@linux-m68k.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=niklas.soderlund+renesas@ragnatech.se \ --subject='Re: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.