From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 16 Feb 2021 13:14:57 -0500 Subject: [PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test In-Reply-To: <20210125122357.414742-5-olteanv@gmail.com> References: <20210125122357.414742-1-olteanv@gmail.com> <20210125122357.414742-5-olteanv@gmail.com> Message-ID: <20210216181457.GX10169@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jan 25, 2021 at 02:23:54PM +0200, Vladimir Oltean wrote: > From: Claudiu Manoil > > The DSA sandbox driver is used for unit testing the DSA class code. > It implements a simple 2 port switch plus 1 CPU port, and uses a very > simple tag to identify the ports. > The DSA sandbox device is connected via CPU port to a regular Ethernet > sandbox device, called 'dsa-test-eth, managed by the existing eth sandbox > driver. The 'dsa-test-eth' is not intended for testing the eth class > code however, but it is used to emulate traffic through the 'lan0' and > 'lan1' front pannel switch ports. To achieve this the dsa sandbox driver > registers a tx handler for the 'dsa-test-eth' device. The switch ports, > labeled as 'lan0' and 'lan1', are also registered as eth devices by the > dsa class code this time. So pinging through these switch ports is as > easy as: > => setenv ethact lan0 > => ping 1.2.3.5 > > Unit tests for the dsa class code were also added. The 'dsa_probe' > test exercises most API functions from dsa.h. The 'dsa' unit test > simply exercises ARP/ICMP traffic through the two switch ports, > including tag injection and extraction, with the help of the dsa > sandbox driver. > I took care to minimize the impact on the existing eth unit tests, > though some adjustments needed to be made with the addition of > extra eth interfaces used by the dsa unit tests. The additional eth > interfaces also require MAC addresses, these have been added to the > sandbox default environment. > > Signed-off-by: Alex Marginean > Signed-off-by: Claudiu Manoil > Reviewed-by: Simon Glass > Signed-off-by: Vladimir Oltean This test does not pass for me. This can be seen at: https://gitlab.denx.de/u-boot/u-boot/-/jobs/223660 Note that I'm still reviewing the rest of the series right now. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: