All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
	David Laight <david.laight@aculab.com>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kbuild: remove ld-version macro
Date: Tue, 16 Feb 2021 11:57:42 -0700	[thread overview]
Message-ID: <20210216185742.GA64801@24bbad8f3778> (raw)
In-Reply-To: <20210216031004.552417-1-masahiroy@kernel.org>

On Tue, Feb 16, 2021 at 12:10:03PM +0900, Masahiro Yamada wrote:
> There is no direct user of ld-version; you can use CONFIG_LD_VERSION
> if needed.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
> 
>  scripts/Kbuild.include | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index 08e011175b4c..509e0856d653 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -141,13 +141,9 @@ cc-ifversion = $(shell [ $(CONFIG_GCC_VERSION)0 $(1) $(2)000 ] && echo $(3) || e
>  # Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y)
>  ld-option = $(call try-run, $(LD) $(KBUILD_LDFLAGS) $(1) -v,$(1),$(2),$(3))
>  
> -# ld-version
> -# Note this is mainly for HJ Lu's 3 number binutil versions
> -ld-version = $(shell $(LD) --version | $(srctree)/scripts/ld-version.sh)
> -
>  # ld-ifversion
>  # Usage:  $(call ld-ifversion, -ge, 22252, y)
> -ld-ifversion = $(shell [ $(ld-version) $(1) $(2) ] && echo $(3) || echo $(4))
> +ld-ifversion = $(shell [ $(CONFIG_LD_VERSION)0 $(1) $(2)0 ] && echo $(3) || echo $(4))
>  
>  ######
>  
> -- 
> 2.27.0
> 

      parent reply	other threads:[~2021-02-16 18:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  3:10 [PATCH 1/2] kbuild: remove ld-version macro Masahiro Yamada
2021-02-16  3:10 ` [PATCH 2/2] kbuild: check the minimum linker version in Kconfig Masahiro Yamada
2021-02-16 17:49   ` Nick Desaulniers
2021-02-16 19:07   ` Nathan Chancellor
2021-02-21 17:10   ` Masahiro Yamada
2021-02-16 18:57 ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210216185742.GA64801@24bbad8f3778 \
    --to=nathan@kernel.org \
    --cc=david.laight@aculab.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.