From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55988C433DB for ; Tue, 16 Feb 2021 20:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D8FE64EAE for ; Tue, 16 Feb 2021 20:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbhBPUSs (ORCPT ); Tue, 16 Feb 2021 15:18:48 -0500 Received: from smtp-17.italiaonline.it ([213.209.10.17]:32929 "EHLO libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229572AbhBPUSo (ORCPT ); Tue, 16 Feb 2021 15:18:44 -0500 Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([87.20.116.197]) by smtp-17.iol.local with ESMTPA id C6n9lYZr1lChfC6nIldwZ7; Tue, 16 Feb 2021 21:18:02 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2014; t=1613506682; bh=E6mT1eLy2BbvLR20EYpVVGUzTe4X8rj8sSx2cY7U1BQ=; h=From; b=Syk1io4d3Z645NJYJYZmITmczoU6ZfK5Gisxywo5C1ApjO1QDGJ16t4taOOPdS+Nh uFzb3xfKhiCMBgRPdXnMbFJeUaYfLBOuX6HMnTPYX4ERRLWNIAu9NIamWd15+u/o/s r5CEl5KU33W45yXVSYVIl4oP+M6UPm+FXq6h4GCBAn+YFhCcgslQSP3ceaFgw4tgjr c0iwB3GH2dfubBEqqD/lueqd3X12+NWW7DFSvJRzv5vXsXPtfDQuImXwnSMR36bqmE as6GqT+kSSFzTwDqIA0nt+1lk2+jo7ZiblrPozd8CzJGcrJJew1nooYbURqZN0l1zi N+IxnaRBiyYfw== X-CNFS-Analysis: v=2.4 cv=S6McfKgP c=1 sm=1 tr=0 ts=602c287a cx=a_exe a=AVqmXbCQpuNSdJmApS5GbQ==:117 a=AVqmXbCQpuNSdJmApS5GbQ==:17 a=toUk0IfjeMrTqMqL6ioA:9 From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Daniel Vetter , David Airlie , Jyri Sarha , Tomi Valkeinen , dri-devel@lists.freedesktop.org Subject: [RESEND PATCH] drm/tilcdc: fix raster control register setting Date: Tue, 16 Feb 2021 21:17:38 +0100 Message-Id: <20210216201738.11946-1-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4xfP8GmNc6lqtNCx9AjdaZ6CT32yIdeq+RBmhw1tSqvBDTixLFsbu+OzjxxIiTE2+sUIzwho6mk1P5VIhmwYZ7EVGWKE0j4GR3lo1wn6o/JN+JsYJ3PA0y 9eMEgBt0CHyDKEF74hm9UyUWsQNanESrpCta5XHmZfoM4N5WtHjs9jxDgSHiKdMqfWs02vmqoh6B7KJDZF4VEf14pNFkNMwRVzesgEhbc373TtOgOb6couTd VRlJLqR9M/wzEYHGRGD8AknuU3ssduvrqgeeuBt7WN7l2acUB8Ew9ybPVJyoIUsEFBfN0eLFGtN1bLweycpRHI/Xytv6kQCeZa7OU7vkQ1Nw1MhXleXgRk/S 4ReprtnPVFF/RXZs+q2JawbojElQznifi27/OhHN3dZcdPFkFzKZNswtpEk0TfT3ALOgAW1ok+Ltj4i0IOxyw5s6uKPodA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..238068e28729 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) return; } } - reg |= info->fdd < 12; + reg |= info->fdd << 12; tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); if (info->invert_pxl_clk) -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AB0C433E0 for ; Tue, 16 Feb 2021 20:18:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4B3564E7A for ; Tue, 16 Feb 2021 20:18:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B3564E7A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=libero.it Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 698B36E49F; Tue, 16 Feb 2021 20:18:06 +0000 (UTC) Received: from libero.it (smtp-17.italiaonline.it [213.209.10.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id C90466E49F for ; Tue, 16 Feb 2021 20:18:04 +0000 (UTC) Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([87.20.116.197]) by smtp-17.iol.local with ESMTPA id C6n9lYZr1lChfC6nIldwZ7; Tue, 16 Feb 2021 21:18:02 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2014; t=1613506682; bh=E6mT1eLy2BbvLR20EYpVVGUzTe4X8rj8sSx2cY7U1BQ=; h=From; b=Syk1io4d3Z645NJYJYZmITmczoU6ZfK5Gisxywo5C1ApjO1QDGJ16t4taOOPdS+Nh uFzb3xfKhiCMBgRPdXnMbFJeUaYfLBOuX6HMnTPYX4ERRLWNIAu9NIamWd15+u/o/s r5CEl5KU33W45yXVSYVIl4oP+M6UPm+FXq6h4GCBAn+YFhCcgslQSP3ceaFgw4tgjr c0iwB3GH2dfubBEqqD/lueqd3X12+NWW7DFSvJRzv5vXsXPtfDQuImXwnSMR36bqmE as6GqT+kSSFzTwDqIA0nt+1lk2+jo7ZiblrPozd8CzJGcrJJew1nooYbURqZN0l1zi N+IxnaRBiyYfw== X-CNFS-Analysis: v=2.4 cv=S6McfKgP c=1 sm=1 tr=0 ts=602c287a cx=a_exe a=AVqmXbCQpuNSdJmApS5GbQ==:117 a=AVqmXbCQpuNSdJmApS5GbQ==:17 a=toUk0IfjeMrTqMqL6ioA:9 From: Dario Binacchi To: linux-kernel@vger.kernel.org Subject: [RESEND PATCH] drm/tilcdc: fix raster control register setting Date: Tue, 16 Feb 2021 21:17:38 +0100 Message-Id: <20210216201738.11946-1-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4xfP8GmNc6lqtNCx9AjdaZ6CT32yIdeq+RBmhw1tSqvBDTixLFsbu+OzjxxIiTE2+sUIzwho6mk1P5VIhmwYZ7EVGWKE0j4GR3lo1wn6o/JN+JsYJ3PA0y 9eMEgBt0CHyDKEF74hm9UyUWsQNanESrpCta5XHmZfoM4N5WtHjs9jxDgSHiKdMqfWs02vmqoh6B7KJDZF4VEf14pNFkNMwRVzesgEhbc373TtOgOb6couTd VRlJLqR9M/wzEYHGRGD8AknuU3ssduvrqgeeuBt7WN7l2acUB8Ew9ybPVJyoIUsEFBfN0eLFGtN1bLweycpRHI/Xytv6kQCeZa7OU7vkQ1Nw1MhXleXgRk/S 4ReprtnPVFF/RXZs+q2JawbojElQznifi27/OhHN3dZcdPFkFzKZNswtpEk0TfT3ALOgAW1ok+Ltj4i0IOxyw5s6uKPodA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Tomi Valkeinen , Jyri Sarha , Dario Binacchi MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..238068e28729 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) return; } } - reg |= info->fdd < 12; + reg |= info->fdd << 12; tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); if (info->invert_pxl_clk) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel